From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy Date: Mon, 27 Nov 2017 13:42:32 -0800 Message-ID: <20171127214232.GT983427@devbig577.frc2.facebook.com> References: <1507324230-22996-1-git-send-email-longman@redhat.com> <20171127210411.GS983427@devbig577.frc2.facebook.com> <8a5ba419-2b02-5b6a-462f-34106cc575ab@redhat.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gHVxHiJY601bd6HmUO34IkNz8Ij/tanYzsoyferH/k0=; b=gCivkxNHMPGWZDiQWDotQGQ2RXz/JnbBnVyoBBVaYSaj2TOCzJ3NITUdKHuBO2sk2p XYRlXq6OEib3pH9FK/u0KuPXdZw0fKyQtlLr5pMyg2phgVxGb6/cgRqIHM2FAj1zJmpD c1cu4u9h68BcWzEtF+1jw5262X/irmHIt5g5dwny2IlkJf0t7275BJ85wBEkmYHz0TsA 8699/wqIdQvnnIfzzTcbU6VvWkRYE9KNLSWi7m8+iXJ7ks66JBOLC3yqi7xYY54mc6et fYZpDE1YwTUf0Gol4DSV5ZQoEQWdZMojC7tYgZLXa1p8+DO1W2yDLqn4J5Rgo4vDi/vY 6row== Content-Disposition: inline In-Reply-To: <8a5ba419-2b02-5b6a-462f-34106cc575ab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Waiman Long Cc: Li Zefan , Johannes Weiner , Jonathan Corbet , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mike Galbraith , Christian Brauner , =?iso-8859-1?Q?St=E9phane?= Graber , Serge Hallyn Hello, Waiman. On Mon, Nov 27, 2017 at 04:19:57PM -0500, Waiman Long wrote: > > Let's start just with [e]cpus and [e]mems. The flags interface looks > > fine but the implementations of these features are really bad and > > cgroup2 doesn't migrate resources for other controllers either anyway. > > That is added because the mem_migrate feature is used in libvirt, I > think. I am thinking of add a "[EXPERIMENTAL]" tag to the flags to > indicate that it is subject to change. I see. Do you happen to know what it's used for and why that's necessary just so that we can evaluate it better? I'm not quite sure what adding [EXPERIMENTAL] tag would achieve. If we expose the feature and people use it, we just have to keep it anyway. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753188AbdK0Vmh (ORCPT ); Mon, 27 Nov 2017 16:42:37 -0500 Received: from mail-qt0-f180.google.com ([209.85.216.180]:38828 "EHLO mail-qt0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752390AbdK0Vmf (ORCPT ); Mon, 27 Nov 2017 16:42:35 -0500 X-Google-Smtp-Source: AGs4zMb8Y7wBGHAXxS/hD9dJKfWxNOBmYeu4LPE0Kjuo2h52HR00l0W2pDAWDYVIR3QiCm9n63uIpA== Date: Mon, 27 Nov 2017 13:42:32 -0800 From: Tejun Heo To: Waiman Long Cc: Li Zefan , Johannes Weiner , Jonathan Corbet , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, Mike Galbraith , Christian Brauner , =?iso-8859-1?Q?St=E9phane?= Graber , Serge Hallyn Subject: Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy Message-ID: <20171127214232.GT983427@devbig577.frc2.facebook.com> References: <1507324230-22996-1-git-send-email-longman@redhat.com> <20171127210411.GS983427@devbig577.frc2.facebook.com> <8a5ba419-2b02-5b6a-462f-34106cc575ab@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a5ba419-2b02-5b6a-462f-34106cc575ab@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Waiman. On Mon, Nov 27, 2017 at 04:19:57PM -0500, Waiman Long wrote: > > Let's start just with [e]cpus and [e]mems. The flags interface looks > > fine but the implementations of these features are really bad and > > cgroup2 doesn't migrate resources for other controllers either anyway. > > That is added because the mem_migrate feature is used in libvirt, I > think. I am thinking of add a "[EXPERIMENTAL]" tag to the flags to > indicate that it is subject to change. I see. Do you happen to know what it's used for and why that's necessary just so that we can evaluate it better? I'm not quite sure what adding [EXPERIMENTAL] tag would achieve. If we expose the feature and people use it, we just have to keep it anyway. Thanks. -- tejun