All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Gimcuan Hui <gimcuan@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
	gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: Clean up the return values of read_reg and write_reg
Date: Tue, 28 Nov 2017 09:47:15 +0100	[thread overview]
Message-ID: <20171128084715.GF9862@localhost> (raw)
In-Reply-To: <20171127153651.2115-1-gimcuan@gmail.com>

On Mon, Nov 27, 2017 at 03:36:51PM +0000, Gimcuan Hui wrote:
> write_reg returns 0 on success, we can make it more explicit by returning
> number 0 instead of result variable.
> 
> read_reg should return 0 on success since this is a more common pattern.
> 
> The user of read_reg has been clean-up and should be at the same commit.
> 
> Signed-off-by: Gimcuan Hui <gimcuan@gmail.com>

Thanks for the update. Now applied for -next with a slightly modified
summary:

	USB: serial: ark3116: clean up return values of register accessors

Johan

  reply	other threads:[~2017-11-28  8:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-27 15:36 [PATCH] USB: serial: Clean up the return values of read_reg and write_reg Gimcuan Hui
2017-11-28  8:47 ` Johan Hovold [this message]
2017-11-28 11:25   ` Gimcuan Hui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171128084715.GF9862@localhost \
    --to=johan@kernel.org \
    --cc=gimcuan@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.