From: Jiri Olsa <jolsa@redhat.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v2 07/10] perf stat: Allocate shadow stats buffer for threads
Date: Tue, 28 Nov 2017 12:12:16 +0100 [thread overview]
Message-ID: <20171128111216.GA2732@krava> (raw)
In-Reply-To: <1511791650-24072-8-git-send-email-yao.jin@linux.intel.com>
On Mon, Nov 27, 2017 at 10:07:27PM +0800, Jin Yao wrote:
> After perf_evlist__create_maps() being executed, we can get all
> threads from /proc. And via thread_map__nr(), we can also get
> the number of threads.
>
> With the number of threads, the patch allocates a buffer which
> will record the shadow stats for these threads.
>
> The buffer pointer is saved in stat_config.
why don't you add struct perf_stat_config::*stats|stats_num in this patch?
I dont see any reason it's introduced earlier
jirka
next prev parent reply other threads:[~2017-11-28 11:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 14:07 [PATCH v2 00/10] perf stat: Enable '--per-thread' on all threads Jin Yao
2017-11-27 14:07 ` [PATCH v2 01/10] perf util: Create rblist__reset() function Jin Yao
2017-11-27 14:07 ` [PATCH v2 02/10] perf util: Define a structure for runtime shadow metrics stats Jin Yao
2017-11-27 14:07 ` [PATCH v2 03/10] perf util: Extend rbtree to support shadow stats Jin Yao
2017-11-27 14:07 ` [PATCH v2 04/10] perf util: Add rbtree node_delete ops Jin Yao
2017-11-28 11:12 ` Jiri Olsa
2017-11-28 12:14 ` Jin, Yao
2017-11-28 11:12 ` Jiri Olsa
2017-11-28 12:19 ` Jin, Yao
2017-11-27 14:07 ` [PATCH v2 05/10] perf util: Update and print per-thread shadow stats Jin Yao
2017-11-27 14:07 ` [PATCH v2 06/10] perf util: Remove a set of shadow stats static variables Jin Yao
2017-11-27 14:07 ` [PATCH v2 07/10] perf stat: Allocate shadow stats buffer for threads Jin Yao
2017-11-28 11:12 ` Jiri Olsa [this message]
2017-11-28 12:23 ` Jin, Yao
2017-11-27 14:07 ` [PATCH v2 08/10] perf util: Reuse thread_map__new_by_uid to enumerate threads from /proc Jin Yao
2017-11-27 14:07 ` [PATCH v2 09/10] perf stat: Remove --per-thread pid/tid limitation Jin Yao
2017-11-27 14:07 ` [PATCH v2 10/10] perf stat: Resort '--per-thread' result Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128111216.GA2732@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.