All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Chase Metzger <chasemetzger15@gmail.com>
Cc: Marcus Wolf <linux@Wolf-Entwicklungen.de>,
	Joseph Wright <rjosephwright@gmail.com>,
	Colin Ian King <colin.king@canonical.com>,
	Haneen Mohammed <hamohammed.sa@gmail.com>,
	Elia Geretto <elia.f.geretto@gmail.com>,
	Srishti Sharma <srishtishar@gmail.com>,
	Xiangyang Zhang <xyz.sun.ok@gmail.com>,
	Derek Robson <robsonde@gmail.com>,
	Cihangir Akturk <cakturk@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: pi433_if.c: fix if/else if and brace coding style issues
Date: Tue, 28 Nov 2017 14:01:54 +0100	[thread overview]
Message-ID: <20171128130154.GA20829@kroah.com> (raw)
In-Reply-To: <20171114200357.4628-1-chasemetzger15@gmail.com>

On Tue, Nov 14, 2017 at 12:03:51PM -0800, Chase Metzger wrote:
> Fix if/else if and braces in function DIO0_irq_handler to comply with
> the kernel coding style.
> 
> Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
> ---
>  drivers/staging/pi433/pi433_if.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index d946838450d4..dee70c47629c 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -133,19 +133,14 @@ static irqreturn_t DIO0_irq_handler(int irq, void *dev_id)
>  {
>  	struct pi433_device *device = dev_id;
>  
> -	if      (device->irq_state[DIO0] == DIO_PacketSent)
> -	{
> +	if      (device->irq_state[DIO0] == DIO_PacketSent) {

When you are touching the line, be sure to fix the obvious space issue
here as well.

thanks,

greg k-h

      reply	other threads:[~2017-11-28 13:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-14 20:03 [PATCH] staging: pi433: pi433_if.c: fix if/else if and brace coding style issues Chase Metzger
2017-11-28 13:01 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171128130154.GA20829@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=cakturk@gmail.com \
    --cc=chasemetzger15@gmail.com \
    --cc=colin.king@canonical.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=elia.f.geretto@gmail.com \
    --cc=hamohammed.sa@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@Wolf-Entwicklungen.de \
    --cc=rjosephwright@gmail.com \
    --cc=robsonde@gmail.com \
    --cc=srishtishar@gmail.com \
    --cc=xyz.sun.ok@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.