From: Andrew Lunn <andrew@lunn.ch>
To: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: rmk@armlinux.org.uk, f.fainelli@gmail.com, davem@davemloft.net,
Yan Markman <ymarkman@marvell.com>,
gregory.clement@free-electrons.com,
thomas.petazzoni@free-electrons.com,
miquel.raynal@free-electrons.com, nadavh@marvell.com,
mw@semihalf.com, stefanc@marvell.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: phylink: fix link state on phy-connect
Date: Tue, 28 Nov 2017 14:56:10 +0100 [thread overview]
Message-ID: <20171128135610.GD20797@lunn.ch> (raw)
In-Reply-To: <20171128132932.27196-1-antoine.tenart@free-electrons.com>
> + /* On _disconnect, the phy state machine and phylink resolve
> + * are stopped before executing full gracefull down/reset state.
> + * The further _connect starts with incorrect init state. Let's set
> + * init values here.
> + */
> + pl->phy_state.link = false;
> + pl->link_config.pause = MLO_PAUSE_AN;
> + pl->link_config.speed = SPEED_UNKNOWN;
> + pl->link_config.duplex = DUPLEX_UNKNOWN;
Hi Antoine
Looks sensible. My only comment would be, maybe it makes sense to
reduce the duplication by adding a little helper which is called here,
and in phylink_create()?
Andrew
next prev parent reply other threads:[~2017-11-28 13:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 13:29 [PATCH net] net: phylink: fix link state on phy-connect Antoine Tenart
2017-11-28 13:56 ` Andrew Lunn [this message]
2017-11-28 14:10 ` Antoine Tenart
2017-11-28 15:53 ` Russell King
2017-11-28 15:56 ` Russell King
2017-11-29 7:22 ` Antoine Tenart
2017-11-29 19:33 ` [EXT] " Yan Markman
2017-11-29 19:59 ` Russell King - ARM Linux
2017-11-29 21:06 ` [EXT] " Yan Markman
2017-11-29 21:20 ` Russell King - ARM Linux
2017-11-30 8:51 ` Yan Markman
2017-11-30 10:10 ` Russell King - ARM Linux
2017-11-30 13:28 ` Russell King - ARM Linux
2017-12-01 17:07 ` Grygorii Strashko
2017-12-01 17:24 ` Russell King - ARM Linux
2017-12-01 17:36 ` Florian Fainelli
2017-12-01 17:47 ` Russell King - ARM Linux
2017-12-02 11:08 ` Yan Markman
2017-12-02 14:58 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128135610.GD20797@lunn.ch \
--to=andrew@lunn.ch \
--cc=antoine.tenart@free-electrons.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@free-electrons.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=rmk@armlinux.org.uk \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ymarkman@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.