From: Vivek Goyal <vgoyal@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: overlayfs <linux-unionfs@vger.kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: [RFC PATCH v8 00/15] overlayfs: Delayed copy up of data
Date: Tue, 28 Nov 2017 13:22:01 -0500 [thread overview]
Message-ID: <20171128182200.GE4101@redhat.com> (raw)
In-Reply-To: <CAOQ4uxidkS6=M9M55Tss1mWQdxdvSp0ZLQ5_5XtUqZhiSr_FhA@mail.gmail.com>
On Tue, Nov 28, 2017 at 07:04:33PM +0200, Amir Goldstein wrote:
> On Tue, Nov 28, 2017 at 5:59 PM, Vivek Goyal <vgoyal@redhat.com> wrote:
> > Hi,
> >
> > Here is the V8 of the patches. Primarily I have taken care of comments
> > from Amir.
> >
> > This applies on top of the fix I posted with subject "ovl: Pass
> > ovl_get_nlink() parameters in right order"
> >
> > Amir, I have added one more patch int series where I pass index dentry
> > to ovl_get_nlink() to get rid of a warning during testing.
Amir, can you please have a look at patch 1 in the series. That's new patch
as compared to V7.
> >
> > I think only outstanding concern with this patch series now is how to
> > detect that metacopy feature was ever enabled and there are some
> > metacopy only files present. In that case we probably don't want to
> > allow user to mount with metacopy=off. We currently don't seem to have
> > a generic infrastructure which keeps track of features and backward
> > compatibility stuff etc. Discussion still seems to be on upstream.
> >
> > Is this a blocker for this patch series or this is something we can
> > live with? Only downside of mounting a file system which has metacopied
> > files (with metacopy=off), is that user will see truncated files.
>
> IMO it is fine to mount with metacopy=off, but user should not see
> truncated file. IMO if metacopy=off, overlayfs still needs to copy up
> data from origin if origin can be decoded and if origin cannot be decoded
> user should get -EIO.
Right. That's the current behavior with the patch. I forgot to mention
that user will see truncated files only with old kernels.
> Mounting an overlayfs with metacopies with kernel that does not support
> metacopy will have unexpected results, same as with redirect_dir.
Right. As of now old kernel should see truncated files.
Vivek
prev parent reply other threads:[~2017-11-28 18:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 15:59 [RFC PATCH v8 00/15] overlayfs: Delayed copy up of data Vivek Goyal
2017-11-28 15:59 ` [PATCH v8 01/15] ovl: Do not look for OVL_XATTR_NLINK if index is not there Vivek Goyal
2017-11-28 19:09 ` Amir Goldstein
2017-11-28 15:59 ` [PATCH v8 02/15] ovl: disable redirect_dir and index when no xattr support Vivek Goyal
2017-11-28 15:59 ` [PATCH v8 03/15] ovl: ovl_check_setxattr() get rid of redundant -EOPNOTSUPP check Vivek Goyal
2017-11-28 15:59 ` [PATCH v8 04/15] ovl: Create origin xattr on copy up for all files Vivek Goyal
2017-11-28 15:59 ` [PATCH v8 05/15] ovl: Provide a mount option metacopy=on/off for metadata copyup Vivek Goyal
2017-11-28 19:15 ` Amir Goldstein
2017-11-28 15:59 ` [PATCH v8 06/15] ovl: During copy up, first copy up metadata and then data Vivek Goyal
2017-11-28 15:59 ` [PATCH v8 07/15] ovl: Move the copy up helpers to copy_up.c Vivek Goyal
2017-11-28 19:16 ` Amir Goldstein
2017-11-28 15:59 ` [PATCH v8 08/15] ovl: Copy up only metadata during copy up where it makes sense Vivek Goyal
2017-11-28 15:59 ` [PATCH v8 09/15] ovl: Add helper ovl_already_copied_up() Vivek Goyal
2017-11-28 15:59 ` [PATCH v8 10/15] ovl: A new xattr OVL_XATTR_METACOPY for file on upper Vivek Goyal
2017-11-28 19:53 ` Amir Goldstein
2017-11-28 15:59 ` [PATCH v8 11/15] ovl: Fix ovl_getattr() to get number of blocks from lower Vivek Goyal
2017-11-28 15:59 ` [PATCH v8 12/15] ovl: Set OVL_UPPERDATA flag during ovl_lookup() Vivek Goyal
2017-11-28 15:59 ` [PATCH v8 13/15] ovl: Do not expose metacopy only upper dentry from d_real() Vivek Goyal
2017-11-28 15:59 ` [PATCH v8 14/15] ovl: Fix encryption/compression status of a metacopy only file Vivek Goyal
2017-11-28 15:59 ` [PATCH v8 15/15] ovl: Enable metadata only feature Vivek Goyal
2017-11-28 17:04 ` [RFC PATCH v8 00/15] overlayfs: Delayed copy up of data Amir Goldstein
2017-11-28 18:22 ` Vivek Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128182200.GE4101@redhat.com \
--to=vgoyal@redhat.com \
--cc=amir73il@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.