From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v6 04/11] x86: define IA32_FEATUE_CONTROL.SGX_LC Date: Wed, 29 Nov 2017 00:21:41 +0200 Message-ID: <20171128222141.pljpvoou7bglbzid@linux.intel.com> References: <20171125193132.24321-1-jarkko.sakkinen@linux.intel.com> <20171125193132.24321-5-jarkko.sakkinen@linux.intel.com> <1511889371.9392.58.camel@intel.com> <1511893683.9392.100.camel@intel.com> <20171128205324.pqojyfqbet3h7re4@linux.intel.com> <20171128212407.lky32cdghxqsxd4e@linux.intel.com> <1511904794.18982.7.camel@intel.com> <20171128215513.qp2bs6462eq4pkz4@linux.intel.com> <1511906403.18982.17.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <1511906403.18982.17.camel@intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Sean Christopherson Cc: platform-driver-x86@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Borislav Petkov , Janakarajan Natarajan , Paolo Bonzini , "Kirill A. Shutemov" , Kyle Huey , Vikas Shivappa , Piotr Luc , Grzegorz Andrejczuk List-Id: platform-driver-x86.vger.kernel.org On Tue, Nov 28, 2017 at 02:00:03PM -0800, Sean Christopherson wrote: > What about SGX_LC_ENABLE?  The title in the MSR section of the SDM is > "SGX Launch Control Enable", and it's more consistent with the other > bits defined in feature control.  I'd also prefer that name for the > actual #define too, SGX_LAUNCH_CONTROL_ENABLE is overly verbose IMO. This is a bit ugly name but it is also very clear: FEATURE_CONTROL_SGX_LEPUBKEYHASH_WRITE_ENABLE Just pushed update to the le branch. SGX_LC_ENABLE is a nice short name but it does not reflect the semantics. Maybe we could combine these and name it as FEATURE_CONTROL_SGX_LC_WRITE_ENABLE It is not as ugly and is very clear what it does. /Jarkko