From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
Thomas Richter <tmricht@linux.vnet.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Adrian Hunter <adrian.hunter@intel.com>,
David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Wang Nan <wangnan0@huawei.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [FIX] perf tools broken for s/390
Date: Wed, 29 Nov 2017 10:17:06 +0100 [thread overview]
Message-ID: <20171129091706.GA4061@osiris> (raw)
In-Reply-To: <20171128144611.GF3298@kernel.org>
On Tue, Nov 28, 2017 at 11:46:11AM -0300, Arnaldo Carvalho de Melo wrote:
> Hi,
>
> While preparing a pull request to Ingo for this merge window, I
> noticed a regression in one of my cross build containers, specifically:
>
> ubuntu:16.04-x-s390: FAIL
>
> LINK /tmp/build/perf/plugin_jbd2.so
> In file included from util/perf_regs.h:27:0,
> from util/event.h:11,
> from util/symbol.h:16,
> from util/block-range.h:5,
> from util/block-range.c:2:
> /git/linux/tools/perf/arch/s390/include/perf_regs.h:6:62: fatal error: ../../../../arch/s390/include/uapi/asm/perf_regs.h: No such file or directory
> compilation terminated.
> In file included from util/perf_regs.h:27:0,
> from util/event.h:11,
> from util/symbol.h:16,
> from util/sort.h:12,
> from util/annotate.c:14:
> /git/linux/tools/perf/arch/s390/include/perf_regs.h:6:62: fatal error: ../../../../arch/s390/include/uapi/asm/perf_regs.h: No such file or directory
> compilation terminated.
...
> +#ifndef ARCH_PERF_REGS_H
> +#define ARCH_PERF_REGS_H
> +
> +#include <stdlib.h>
> +#include <linux/types.h>
> +#include <../../../../arch/s390/include/uapi/asm/perf_regs.h>
>
> ------------------------------------------
>
> That will try to include a file from the kernel sources, directly,
> something we long decided to be verbotten to avoid disturbing kernel
> development (and perf's and other tools/) when, say, a kernel hacker
> adds something, tests everything but tools/ and have tools/ build
> broken.
...
Sorry about that, and thanks for fixing it!
> In the future, please send patches that touch tools/perf/ to me,
>
> The resulting patch is at:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/urgent&id=12507d0fc07ce2fa6ccdcdde819f26c4acb0d839
Will do. Thanks!
prev parent reply other threads:[~2017-11-29 9:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 14:46 [FIX] perf tools broken for s/390 Arnaldo Carvalho de Melo
2017-11-29 9:17 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129091706.GA4061@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=brueckner@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=tmricht@linux.vnet.ibm.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.