From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-s390@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v3] s390/virtio: add BSD license to virtio-ccw
Date: Wed, 29 Nov 2017 10:22:55 +0100 [thread overview]
Message-ID: <20171129092255.GB4061@osiris> (raw)
In-Reply-To: <20171128145119.2866d7a7.cohuck@redhat.com>
On Tue, Nov 28, 2017 at 02:51:19PM +0100, Cornelia Huck wrote:
> On Tue, 28 Nov 2017 15:17:52 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > The original intent of the virtio header relicensing
> > from 2008 was to make sure anyone can implement compatible
> > devices/drivers. The virtio-ccw was omitted by mistake.
> >
> > We have an ack from the only contributor as well as the
> > maintainer from IBM, so it's not too late to fix that.
> >
> > Make it dual-licensed with GPLv2, as the whole kernel is GPL2.
> >
> > Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
> > Acked-by: Cornelia Huck <cohuck@redhat.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > arch/s390/include/uapi/asm/virtio-ccw.h | 6 +-----
> > arch/s390/kernel/setup.c | 1 -
> > 2 files changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/arch/s390/include/uapi/asm/virtio-ccw.h b/arch/s390/include/uapi/asm/virtio-ccw.h
> > index 967aad3..2b605f7 100644
> > --- a/arch/s390/include/uapi/asm/virtio-ccw.h
> > +++ b/arch/s390/include/uapi/asm/virtio-ccw.h
> > @@ -1,13 +1,9 @@
> > -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> > +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */
> > /*
> > * Definitions for virtio-ccw devices.
> > *
> > * Copyright IBM Corp. 2013
> > *
> > - * This program is free software; you can redistribute it and/or modify
> > - * it under the terms of the GNU General Public License (version 2 only)
> > - * as published by the Free Software Foundation.
> > - *
> > * Author(s): Cornelia Huck <cornelia.huck@de.ibm.com>
> > */
> > #ifndef __KVM_VIRTIO_CCW_H
> > diff --git a/arch/s390/kernel/setup.c b/arch/s390/kernel/setup.c
> > index 164a1e1..c022007 100644
> > --- a/arch/s390/kernel/setup.c
> > +++ b/arch/s390/kernel/setup.c
> > @@ -60,7 +60,6 @@
> > #include <asm/ptrace.h>
> > #include <asm/sections.h>
> > #include <asm/ebcdic.h>
> > -#include <asm/kvm_virtio.h>
> > #include <asm/diag.h>
> > #include <asm/os_info.h>
> > #include <asm/sclp.h>
>
> Shouldn't the second hunk already be in master?
>
> Still ack otherwise.
The removal of the license text is also already in linux-next, however no
need to send an updated version. I'll fix it up ;)
next prev parent reply other threads:[~2017-11-29 9:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 13:17 [PATCH v3] s390/virtio: add BSD license to virtio-ccw Michael S. Tsirkin
2017-11-28 13:51 ` Cornelia Huck
2017-11-29 9:22 ` Heiko Carstens
2017-11-29 9:22 ` Heiko Carstens [this message]
2017-11-28 13:51 ` Cornelia Huck
-- strict thread matches above, loose matches on Subject: below --
2017-11-28 13:17 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129092255.GB4061@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mst@redhat.com \
--cc=schwidefsky@de.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.