From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [PATCH] mm, memcg: fix mem_cgroup_swapout() for THPs Date: Wed, 29 Nov 2017 10:17:13 +0000 Message-ID: <20171129101713.GA28244@cmpxchg.org> References: <20171128161941.20931-1-shakeelb@google.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=cmpxchg.org ; s=x; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject: Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=v3mEICMWWdxZdhxMQP8wumpnws5IR+m7a4JlgcSTCnQ=; b=2p0aMEAH8gTQw5XN5jr+lHKCeY x/gv6cHa/d0phhfKzBd/Gwz7+E+/zHWjMD/pGMXIk81rEyvw/SuqgGW2iXTva76fx7M8/ouUx3k6J M1W6UqHIsKBBw4UXPUs8wz3t+6PcBSbmzGRbcViIba2uyoZ5CYBJMQPFP4zrx38ocZOw=; Content-Disposition: inline In-Reply-To: <20171128161941.20931-1-shakeelb@google.com> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Shakeel Butt Cc: Huang Ying , Vladimir Davydov , Michal Hocko , Greg Thelen , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, stable@vger.kernel.org On Tue, Nov 28, 2017 at 08:19:41AM -0800, Shakeel Butt wrote: > The commit d6810d730022 ("memcg, THP, swap: make mem_cgroup_swapout() > support THP") changed mem_cgroup_swapout() to support transparent huge > page (THP). However the patch missed one location which should be > changed for correctly handling THPs. The resulting bug will cause the > memory cgroups whose THPs were swapped out to become zombies on > deletion. > > Fixes: d6810d730022 ("memcg, THP, swap: make mem_cgroup_swapout() support THP") > Signed-off-by: Shakeel Butt > Cc: stable@vger.kernel.org Acked-by: Johannes Weiner -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932281AbdK2KRb (ORCPT ); Wed, 29 Nov 2017 05:17:31 -0500 Received: from gum.cmpxchg.org ([85.214.110.215]:51732 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754233AbdK2KR1 (ORCPT ); Wed, 29 Nov 2017 05:17:27 -0500 Date: Wed, 29 Nov 2017 10:17:13 +0000 From: Johannes Weiner To: Shakeel Butt Cc: Huang Ying , Vladimir Davydov , Michal Hocko , Greg Thelen , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mm, memcg: fix mem_cgroup_swapout() for THPs Message-ID: <20171129101713.GA28244@cmpxchg.org> References: <20171128161941.20931-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171128161941.20931-1-shakeelb@google.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2017 at 08:19:41AM -0800, Shakeel Butt wrote: > The commit d6810d730022 ("memcg, THP, swap: make mem_cgroup_swapout() > support THP") changed mem_cgroup_swapout() to support transparent huge > page (THP). However the patch missed one location which should be > changed for correctly handling THPs. The resulting bug will cause the > memory cgroups whose THPs were swapped out to become zombies on > deletion. > > Fixes: d6810d730022 ("memcg, THP, swap: make mem_cgroup_swapout() support THP") > Signed-off-by: Shakeel Butt > Cc: stable@vger.kernel.org Acked-by: Johannes Weiner