From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH v2] Replace 'uint32_t' with 'u32' and 'uint64_t' with 'u64'
Date: Wed, 29 Nov 2017 11:41:25 +0100 [thread overview]
Message-ID: <20171129104125.GA14678@kroah.com> (raw)
In-Reply-To: <20171117114618.GA26318@home>
On Fri, Nov 17, 2017 at 02:46:18PM +0300, Roman Storozhenko wrote:
> There are two reasons for that:
> 1) As Linus Torvalds said we should use kernel types:
> http://lkml.iu.edu/hypermail//linux/kernel/1506.0/00160.html
>
> 2) There are only few places in the lustre codebase that use such types.
> In the most cases it uses 'u32' and 'u64'.
>
> Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
>
> ---
> In the first version of this patch I replaced 'uint32_t' with '__u32' and
> 'uint64_t' with '__u64'. I was suggested to fix that by Greg K-H:
>
> "The __ types are only needed for when you cross the user/kernel boundry.
> Otherwise just use the "normal" types of u32 and u64.
>
> Do the changes you made here all cross that boundry? If not, please fix
> this up."
>
> I asked lustre community whether those code used only in the kernel
> space and Andreas Dilger said:
>
> "These headers are for kernel code only, so should use the "u32" and
> similar
> types, rather than the "__u32" that are used for user-kernel
> structures."
>
> So I have replaced my first patch version with this one.
Please fix up the subject to have the subsystem and driver name in it:
Subject: [PATCH] staging: lustre: ...
thanks,
greg k-h
prev parent reply other threads:[~2017-11-29 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 11:46 [lustre-devel] [PATCH v2] Replace 'uint32_t' with 'u32' and 'uint64_t' with 'u64' Roman Storozhenko
2017-11-17 22:27 ` Dilger, Andreas
2017-11-29 10:41 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129104125.GA14678@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.