From: msrb@suse.com
To: dri-devel@lists.freedesktop.org
Subject: [PATCH] drm: hibmc: Initialize the hibmc_bo_driver.io_mem_pfn
Date: Wed, 29 Nov 2017 12:33:24 +0100 [thread overview]
Message-ID: <20171129113324.20041-1-msrb@suse.com> (raw)
From: Michal Srb <msrb@suse.com>
The io_mem_pfn field was added in ea642c3216cb2a60d1c0e760ae47ee85c9c16447 and
is used unconditionally. Most drivers were updated to set it to the default
implementation ttm_bo_default_io_mem_pfn, but hibmc was not.
This fixes crash in ttm_bo_vm_fault when hibmc driver is used.
Signed-off-by: Michal Srb <msrb@suse.com>
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c
index 3518167a7dc4..0b165ce4ee00 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c
@@ -243,6 +243,7 @@ struct ttm_bo_driver hibmc_bo_driver = {
.verify_access = hibmc_bo_verify_access,
.io_mem_reserve = &hibmc_ttm_io_mem_reserve,
.io_mem_free = NULL,
+ .io_mem_pfn = ttm_bo_default_io_mem_pfn,
};
int hibmc_mm_init(struct hibmc_drm_private *hibmc)
--
2.13.6
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2017-11-29 11:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 11:33 msrb [this message]
2017-11-29 14:47 ` [PATCH] drm: hibmc: Initialize the hibmc_bo_driver.io_mem_pfn Sean Paul
2017-11-29 14:54 ` Michal Srb
2017-11-29 15:20 ` [PATCH] drm/ttm: Use ttm_bo_default_io_mem_pfn if io_mem_pfn is NULL Michal Srb
2017-11-29 15:24 ` Christian König
2017-11-29 15:29 ` Michal Srb
2017-11-29 15:36 ` Sean Paul
2017-11-29 15:40 ` Christian König
2017-11-29 15:44 ` Sean Paul
2017-11-29 15:59 ` Christian König
2017-11-29 16:13 ` Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129113324.20041-1-msrb@suse.com \
--to=msrb@suse.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.