From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Richard Henderson <rth@twiddle.net>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions
Date: Wed, 29 Nov 2017 16:39:08 +0100 [thread overview]
Message-ID: <20171129163908.38ae0bd9.cohuck@redhat.com> (raw)
In-Reply-To: <39bdd9f7-9510-48ab-9a17-1a53bcc7f029@redhat.com>
On Wed, 29 Nov 2017 16:38:03 +0100
David Hildenbrand <david@redhat.com> wrote:
> On 29.11.2017 16:35, Cornelia Huck wrote:
> > On Wed, 29 Nov 2017 16:14:40 +0100
> > David Hildenbrand <david@redhat.com> wrote:
> >
> >> On 29.11.2017 16:13, Cornelia Huck wrote:
> >>> On Tue, 28 Nov 2017 21:33:14 +0100
> >>> David Hildenbrand <david@redhat.com> wrote:
> >>>
> >>>> TCG needs the retaddr when injecting an interrupt. Let's just pass it
> >>>> along and use 0 for KVM. The value will be completely ignored for KVM.
> >>>
> >>> Can we get a #define for that? Just to make it clear at a glance that
> >>> we're passing an ignored value and not some magic thing.
> >>
> >> If you can come up with a good name, I can't :)
> >
> > KVM_FAKE_RA
> > KVM_RA_UNUSED
> > KVM_RA_IGNORED
> >
> > ?
> >
>
> KVM_RA ? (to keep lines short?)
>
That sounds too much like a magic value IMO (and not something that is
ignored).
next prev parent reply other threads:[~2017-11-29 15:39 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 20:33 [Qemu-devel] [PATCH v1 for-2.12 00/15] s390x/tcg: cleanup and fix program interrupts David Hildenbrand
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 01/15] s390x/tcg: introduce and use program_interrupt_ra() David Hildenbrand
2017-11-29 14:55 ` Cornelia Huck
2017-11-29 15:13 ` David Hildenbrand
2017-11-29 17:16 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 02/15] s390x/tcg: get rid of runtime_exception() David Hildenbrand
2017-11-29 17:17 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 03/15] s390x/tcg: rip out dead tpi code David Hildenbrand
2017-11-29 3:10 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2017-11-29 17:28 ` [Qemu-devel] " Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions David Hildenbrand
2017-11-29 15:13 ` Cornelia Huck
2017-11-29 15:14 ` David Hildenbrand
2017-11-29 15:35 ` Cornelia Huck
2017-11-29 15:38 ` David Hildenbrand
2017-11-29 15:39 ` Cornelia Huck [this message]
2017-11-29 15:45 ` David Hildenbrand
2017-11-29 15:57 ` Cornelia Huck
2017-11-29 16:05 ` David Hildenbrand
2017-11-29 17:35 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 05/15] s390x/pci: pass the retaddr to all PCI instructions David Hildenbrand
2017-11-29 17:37 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 06/15] s390x/diag: pass the retaddr into handle_diag_308() David Hildenbrand
2017-11-29 17:38 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 07/15] s390x: handle exceptions during s390_cpu_virt_mem_rw() correctly (TCG) David Hildenbrand
2017-11-29 15:50 ` Cornelia Huck
2017-11-29 15:54 ` David Hildenbrand
2017-11-29 15:59 ` Cornelia Huck
2017-11-29 16:25 ` David Hildenbrand
2017-11-29 17:52 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 08/15] s390x/tcg: io instructions don't need potential_page_fault() David Hildenbrand
2017-11-29 17:53 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 09/15] s390x/tcg: use program_interrupt_ra() in SCLP Service Call David Hildenbrand
2017-11-29 18:10 ` Richard Henderson
2017-11-29 19:01 ` David Hildenbrand
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 10/15] s390x/tcg: use program_interrupt_ra() in DIAG David Hildenbrand
2017-11-29 18:11 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 11/15] s390x/tcg: use program_interrupt_ra() in per_check_exception() David Hildenbrand
2017-11-29 18:13 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 12/15] s390x/tcg: use program_interrupt_ra() in SACF David Hildenbrand
2017-11-29 18:13 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 13/15] s390x/tcg: use program_interrupt_ra() in STSI David Hildenbrand
2017-11-29 15:53 ` Cornelia Huck
2017-11-29 15:56 ` David Hildenbrand
2017-11-29 18:14 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 14/15] s390x/tcg: drop program_interrupt() David Hildenbrand
2017-11-29 15:55 ` Cornelia Huck
2017-11-29 18:18 ` Richard Henderson
2017-11-29 18:57 ` David Hildenbrand
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 15/15] s390x/tcg: drop potential_page_fault() David Hildenbrand
2017-11-29 18:20 ` Richard Henderson
2017-11-29 13:51 ` [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.12 00/15] s390x/tcg: cleanup and fix program interrupts Thomas Huth
2017-11-29 14:06 ` David Hildenbrand
2017-11-29 14:44 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129163908.38ae0bd9.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.