From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH v3 5/5] arm64: dts: rockchip: update mipi node for RK3399 Date: Wed, 29 Nov 2017 10:37:33 -0800 Message-ID: <20171129183732.GA74243@google.com> References: <1511868006-27130-1-git-send-email-nickey.yang@rock-chips.com> <1511868006-27130-6-git-send-email-nickey.yang@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1511868006-27130-6-git-send-email-nickey.yang@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nickey Yang Cc: mark.rutland@arm.com, Doug Anderson , airlied@linux.ie, hoegsberg@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, philippe.cornu@st.com, yannick.fertre@st.com, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, zyw@rock-chips.com, xbl@rock-chips.com, mka@chromium.org, hl@rock-chips.com List-Id: linux-rockchip.vger.kernel.org KyBEb3VnLCBzaW5jZSBoZSB3YXMgYXNraW5nIHRoZXNlIHRoaW5ncyBlbHNld2hlcmUKCk9uIFR1 ZSwgTm92IDI4LCAyMDE3IGF0IDA3OjIwOjA2UE0gKzA4MDAsIE5pY2tleSBZYW5nIHdyb3RlOgo+ IFRoaXMgcGF0Y2ggdXBkYXRlIG1pcGkgbm9kZSBmb3IgUkszMzk5IERTSSBjb250cm9sbGVyCj4g YmFzZWQgb24gdGhlIFN5bm9wc3lzIERlc2lnbldhcmUgTUlQSSBEU0kgaG9zdCBjb250cm9sbGVy Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IE5pY2tleSBZYW5nIDxuaWNrZXkueWFuZ0Byb2NrLWNoaXBz LmNvbT4KPiAtLS0KPiAgYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazMzOTkuZHRzaSB8 IDggKysrKystLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlv bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazMz OTkuZHRzaSBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LmR0c2kKPiBpbmRl eCBkMzQwYjU4YS4uMGFjNjdhOSAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3Jv Y2tjaGlwL3JrMzM5OS5kdHNpCj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9y azMzOTkuZHRzaQo+IEBAIC0xNjUyLDkgKzE2NTIsMTEgQEAKPiAgCQlzdGF0dXMgPSAiZGlzYWJs ZWQiOwo+ICAKPiAgCQlwb3J0cyB7Cj4gLQkJCW1pcGlfaW46IHBvcnQgewo+IC0JCQkJI2FkZHJl c3MtY2VsbHMgPSA8MT47Cj4gLQkJCQkjc2l6ZS1jZWxscyA9IDwwPjsKPiArCQkJI2FkZHJlc3Mt Y2VsbHMgPSA8MT47Cj4gKwkJCSNzaXplLWNlbGxzID0gPDA+OwoKXl4gSXQncyBnb29kIHRvIGFk ZCB0aGVzZSBoZXJlLCBzaW5jZSBjaGlsZCBub2RlcyBhcmUgZ29pbmcgdG8gaGF2ZSB1bml0CmFk ZHJlc3Nlcy4KCj4gKwo+ICsJCQltaXBpX2luOiBwb3J0QDAgewo+ICsJCQkJcmVnID0gPDA+OwoK Xl4gQnV0IHlvdSdyZSByZW1vdmluZyB0aGUgI3thZGRyZXNzLHNpemV9LWNlbGxzIGZyb20gdGhl IHBvcnQsIHdoaWxlCnN0aWxsIHVzaW5nIHVuaXQgYWRkcmVzc2VzIG9uIGl0cyBzdWJub2RlcyAo dGhlIGVuZHBvaW50QC4uLiBub2RlcykuIFlvdQpzaG91bGQga2VlcCAqYm90aCosIHNpbmNlIGJv dGggdGhlICdwb3J0cycgbm9kZSBhbmQgdGhlICdwb3J0QDAnIG5vZGUKd2lsbCBoYXZlIGNoaWxk cmVuIHdpdGggYWRkcmVzc2VzLgoKQnJpYW4KCj4gIAo+ICAJCQkJbWlwaV9pbl92b3BiOiBlbmRw b2ludEAwIHsKPiAgCQkJCQlyZWcgPSA8MD47Cj4gLS0gCj4gMS45LjEKPiAKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752059AbdK2Shk (ORCPT ); Wed, 29 Nov 2017 13:37:40 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:40503 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751564AbdK2Shh (ORCPT ); Wed, 29 Nov 2017 13:37:37 -0500 X-Google-Smtp-Source: AGs4zMaGagpuB4Z6byjmcI1DsdR1yCtiJEoFX6tTzirrdREHMyRXhcX/sJCyUQAFk+0+GEIh5OilWA== Date: Wed, 29 Nov 2017 10:37:33 -0800 From: Brian Norris To: Nickey Yang Cc: robh+dt@kernel.org, heiko@sntech.de, mark.rutland@arm.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, seanpaul@chromium.org, mka@chromium.org, hoegsberg@gmail.com, architt@codeaurora.org, philippe.cornu@st.com, yannick.fertre@st.com, hl@rock-chips.com, zyw@rock-chips.com, xbl@rock-chips.com, Doug Anderson Subject: Re: [PATCH v3 5/5] arm64: dts: rockchip: update mipi node for RK3399 Message-ID: <20171129183732.GA74243@google.com> References: <1511868006-27130-1-git-send-email-nickey.yang@rock-chips.com> <1511868006-27130-6-git-send-email-nickey.yang@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511868006-27130-6-git-send-email-nickey.yang@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + Doug, since he was asking these things elsewhere On Tue, Nov 28, 2017 at 07:20:06PM +0800, Nickey Yang wrote: > This patch update mipi node for RK3399 DSI controller > based on the Synopsys DesignWare MIPI DSI host controller. > > Signed-off-by: Nickey Yang > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index d340b58a..0ac67a9 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -1652,9 +1652,11 @@ > status = "disabled"; > > ports { > - mipi_in: port { > - #address-cells = <1>; > - #size-cells = <0>; > + #address-cells = <1>; > + #size-cells = <0>; ^^ It's good to add these here, since child nodes are going to have unit addresses. > + > + mipi_in: port@0 { > + reg = <0>; ^^ But you're removing the #{address,size}-cells from the port, while still using unit addresses on its subnodes (the endpoint@... nodes). You should keep *both*, since both the 'ports' node and the 'port@0' node will have children with addresses. Brian > > mipi_in_vopb: endpoint@0 { > reg = <0>; > -- > 1.9.1 >