From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753082AbdK3C66 (ORCPT ); Wed, 29 Nov 2017 21:58:58 -0500 Received: from smtprelay0019.hostedemail.com ([216.40.44.19]:47244 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752418AbdK3C64 (ORCPT ); Wed, 29 Nov 2017 21:58:56 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:960:973:982:988:989:1183:1260:1277:1311:1313:1314:1345:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:3138:3139:3140:3141:3142:3352:3865:3866:3867:3868:3870:3872:3873:3874:5007:6119:6120:6261:7875:7901:7903:10004:10400:10848:11232:11657:11658:11914:12043:12760:12895:13069:13138:13231:13311:13357:13439:14093:14097:14181:14394:14659:14721:21080:21433:21434:21451:21627:30029:30054,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: shoes68_6afcc0c931548 X-Filterd-Recvd-Size: 2284 Date: Wed, 29 Nov 2017 21:58:53 -0500 From: Steven Rostedt To: LKML Cc: Trond Myklebust , Anna Schumaker , Linus Torvalds , Andrew Morton Subject: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4 Message-ID: <20171129215853.20172851@vmware.local.home> X-Mailer: Claws Mail 3.15.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Just letting you know that this commit: fcd8843c406 ('NFSv4: Replace closed stateids with the "invalid special stateid"') causes gcc 4.5.4 to fail the build with this error: CC [M] fs/nfs/nfs4state.o /work/git/linux-trace.git/fs/nfs/nfs4state.c:75:4: error: field name not in record or union initializer /work/git/linux-trace.git/fs/nfs/nfs4state.c:75:4: error: (near initialization for 'invalid_stateid..data') /work/git/linux-trace.git/fs/nfs/nfs4state.c:75:4: warning: overflow in implicit constant conversion /work/git/linux-trace.git/fs/nfs/nfs4state.c:76:4: error: field name not in record or union initializer /work/git/linux-trace.git/fs/nfs/nfs4state.c:76:4: error: (near initialization for 'invalid_stateid..data') /work/git/linux-trace.git/fs/nfs/nfs4state.c:76:4: warning: braces around scalar initializer /work/git/linux-trace.git/fs/nfs/nfs4state.c:76:4: warning: (near initialization for 'invalid_stateid..data[1]') make[3]: *** [/work/git/linux-trace.git/scripts/Makefile.build:310: fs/nfs/nfs4state.o] Error 1 make[2]: *** [/work/git/linux-trace.git/scripts/Makefile.build:569: fs/nfs] Error 2 make[1]: *** [/work/git/linux-trace.git/Makefile:1012: fs] Error 2 make[1]: Leaving directory '/work/git/nobackup/bxtest/trace' Seems it can't handle the initialization of an anonymous struct within an anonymous union. I switched to gcc 4.6.3 and it compiles fine. -- Steve