From: Stephen Hemminger <stephen@networkplumber.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, sthemmin@microsoft.com
Subject: Re: [PATCH RFC 0/2] veth, bridge, and GSO maximums
Date: Thu, 30 Nov 2017 09:11:30 -0800 [thread overview]
Message-ID: <20171130091130.0400d8a5@xeon-e3> (raw)
In-Reply-To: <20171130.104721.823106331151241632.davem@davemloft.net>
On Thu, 30 Nov 2017 10:47:21 -0500 (EST)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
> Date: Sun, 26 Nov 2017 10:17:47 -0800
>
> > This pair of patchesimproves the performance when running
> > containers in an environment where underlying device has lower
> > GSO maximum (such as Azure).
> >
> > With containers a veth pair is created and one end is attached
> > to the bridge device. The bridge device correctly reports
> > computes GSO parameters that are the minimum of the lower devices.
> >
> > The problem is that the other end of the veth device (in container)
> > reports the full GSO size. This patch propogates the upper
> > (bridge device) parameters to the other end of the veth device.
> >
> > Please consider it as alternative to the sysfs GSO changes.
>
> I like this approach a lot, please resubmit this formally.
Will do and add netif_needs_gso check as well.
next prev parent reply other threads:[~2017-11-30 17:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-26 18:17 [PATCH RFC 0/2] veth, bridge, and GSO maximums Stephen Hemminger
2017-11-26 18:17 ` [PATCH RFC 1/2] br: add notifier for when bridge changes it " Stephen Hemminger
2017-11-26 18:17 ` [PATCH RFC 2/2] veth: propagate bridge GSO to peer Stephen Hemminger
2017-11-27 3:13 ` David Ahern
2017-11-27 7:07 ` Stephen Hemminger
2017-11-27 20:14 ` Solio Sarabia
2017-11-27 21:15 ` Stephen Hemminger
2017-11-28 1:42 ` Solio Sarabia
2017-11-28 2:02 ` David Ahern
2017-11-30 0:35 ` Solio Sarabia
2017-11-30 17:10 ` Stephen Hemminger
2017-11-30 17:26 ` Eric Dumazet
2017-11-30 17:36 ` Stephen Hemminger
2017-11-30 17:38 ` David Miller
2017-11-30 17:49 ` Stephen Hemminger
2017-11-30 17:59 ` Eric Dumazet
2017-11-30 18:08 ` Stephen Hemminger
2017-11-30 18:10 ` Eric Dumazet
2017-12-01 20:30 ` Stephen Hemminger
2017-11-30 15:47 ` [PATCH RFC 0/2] veth, bridge, and GSO maximums David Miller
2017-11-30 17:11 ` Stephen Hemminger [this message]
2017-11-30 20:50 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130091130.0400d8a5@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.