From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay02.ispgateway.de ([80.67.18.14]:48246 "EHLO smtprelay02.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943AbdK3L4H (ORCPT ); Thu, 30 Nov 2017 06:56:07 -0500 Date: Thu, 30 Nov 2017 11:53:16 +0100 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Sascha Hauer Cc: linux-kernel-dev@beckhoff.com, Mark Rutland , Alessandro Zummo , Patrick Bruenn , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , Rob Herring , Russell King , Noel Vellemans , Alexandre Belloni , Sascha Hauer , Fabio Estevam , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:REAL TIME CLOCK \(RTC\) SUBSYSTEM" Subject: Re: [PATCH] rtc: add mxc driver for i.MX53 Message-ID: <20171130115316.1dcd86d8@karo-electronics.de> In-Reply-To: <20171130095047.4sl7rfa5cc6rtmig@pengutronix.de> References: <20171128073927.12035-1-linux-kernel-dev@beckhoff.com> <20171130095047.4sl7rfa5cc6rtmig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-rtc-owner@vger.kernel.org List-ID: Hi, On Thu, 30 Nov 2017 10:50:47 +0100 Sascha Hauer wrote: > On Tue, Nov 28, 2017 at 08:39:27AM +0100, linux-kernel-dev@beckhoff.com wrote: [...] > > +/*! MXC RTC Power management control */ > > +static int mxc_rtc_probe(struct platform_device *pdev) > > +{ > > + struct timespec tv; > > + struct resource *res; > > + struct rtc_drv_data *pdata = NULL; > > No need to initialize. > > > + void __iomem *ioaddr; > > + int ret = 0; > Same here. Lothar Waßmann From mboxrd@z Thu Jan 1 00:00:00 1970 From: LW@KARO-electronics.de (Lothar =?UTF-8?B?V2HDn21hbm4=?=) Date: Thu, 30 Nov 2017 11:53:16 +0100 Subject: [PATCH] rtc: add mxc driver for i.MX53 In-Reply-To: <20171130095047.4sl7rfa5cc6rtmig@pengutronix.de> References: <20171128073927.12035-1-linux-kernel-dev@beckhoff.com> <20171130095047.4sl7rfa5cc6rtmig@pengutronix.de> Message-ID: <20171130115316.1dcd86d8@karo-electronics.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Thu, 30 Nov 2017 10:50:47 +0100 Sascha Hauer wrote: > On Tue, Nov 28, 2017 at 08:39:27AM +0100, linux-kernel-dev at beckhoff.com wrote: [...] > > +/*! MXC RTC Power management control */ > > +static int mxc_rtc_probe(struct platform_device *pdev) > > +{ > > + struct timespec tv; > > + struct resource *res; > > + struct rtc_drv_data *pdata = NULL; > > No need to initialize. > > > + void __iomem *ioaddr; > > + int ret = 0; > Same here. Lothar Wa?mann From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= Subject: Re: [PATCH] rtc: add mxc driver for i.MX53 Date: Thu, 30 Nov 2017 11:53:16 +0100 Message-ID: <20171130115316.1dcd86d8@karo-electronics.de> References: <20171128073927.12035-1-linux-kernel-dev@beckhoff.com> <20171130095047.4sl7rfa5cc6rtmig@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20171130095047.4sl7rfa5cc6rtmig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sascha Hauer Cc: linux-kernel-dev-QonKdJ6Bx35Wk0Htik3J/w@public.gmane.org, Mark Rutland , Alessandro Zummo , Patrick Bruenn , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , Rob Herring , Russell King , Noel Vellemans , Alexandre Belloni , Sascha Hauer , Fabio Estevam , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" List-Id: devicetree@vger.kernel.org Hi, On Thu, 30 Nov 2017 10:50:47 +0100 Sascha Hauer wrote: > On Tue, Nov 28, 2017 at 08:39:27AM +0100, linux-kernel-dev-QonKdJ6Bx35Wk0Htik3J/w@public.gmane.org wrote: [...] > > +/*! MXC RTC Power management control */ > > +static int mxc_rtc_probe(struct platform_device *pdev) > > +{ > > + struct timespec tv; > > + struct resource *res; > > + struct rtc_drv_data *pdata = NULL; > > No need to initialize. > > > + void __iomem *ioaddr; > > + int ret = 0; > Same here. Lothar Waßmann -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html