From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752126AbdK3Iyf (ORCPT ); Thu, 30 Nov 2017 03:54:35 -0500 Received: from smtp49.i.mail.ru ([94.100.177.109]:56824 "EHLO smtp49.i.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbdK3Iye (ORCPT ); Thu, 30 Nov 2017 03:54:34 -0500 X-Greylist: delayed 83235 seconds by postgrey-1.27 at vger.kernel.org; Thu, 30 Nov 2017 03:54:33 EST Date: Thu, 30 Nov 2017 11:54:07 +0300 From: Mikhail Zaytsev To: Alan Stern Cc: Greg Kroah-Hartman , , , Subject: [PATCH v1] USB: storage: Remove obsolete "FIXME" Message-ID: <20171130115407.35e5e8a2@zaitsev.tver.pg> In-Reply-To: References: <20171130000353.6de42104@debian> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: smtp49.i.mail.ru; auth=pass smtp.auth=flashed@mail.ru smtp.mailfrom=flashed@mail.ru X-7FA49CB5: 0D63561A33F958A512FC8D2217B594FE552AD35A3D77034AD9E02EBB24879C6C725E5C173C3A84C37795E77BD711CB35770AC3BA4C1921AC789C969B8F27C422C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F2AF38021CC9F462D574AF45C6390F7469DAA53EE0834AAEE X-Mailru-Sender: DBE5340C3C7EDD8787CAD35FD0EDB6C30885AF9A4D598F402ACF19926C62256EB8F38F170EB25BFC3C8BDCE45491770B027D9DD7AE851095372E3D06A1D6CBE64DA9DA30EEEEBA7A0D4ABDE8C577C2ED X-Mras: OK Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The fix of "FIXME: Notify the subdrivers..." doesn't actually have any real effect. The "FIXME" changed to simple comment. Signed-off-by: Mikhail Zaytsev --- drivers/usb/storage/usb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c index a0c07e0..3eb9347 100644 --- a/drivers/usb/storage/usb.c +++ b/drivers/usb/storage/usb.c @@ -211,8 +211,8 @@ int usb_stor_reset_resume(struct usb_interface *iface) usb_stor_report_bus_reset(us); /* - * FIXME: Notify the subdrivers that they need to reinitialize - * the device + * If any of the subdrivers implemented a reinitialization scheme, + * this is where the callback would be invoked. */ return 0; } @@ -243,8 +243,8 @@ int usb_stor_post_reset(struct usb_interface *iface) usb_stor_report_bus_reset(us); /* - * FIXME: Notify the subdrivers that they need to reinitialize - * the device + * If any of the subdrivers implemented a reinitialization scheme, + * this is where the callback would be invoked. */ mutex_unlock(&us->dev_mutex); -- 2.1.4