From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH v3 3/5] dt-bindings: display: rockchip: update DSI controller Date: Thu, 30 Nov 2017 08:58:24 -0800 Message-ID: <20171130165823.GA140320@google.com> References: <1511868006-27130-1-git-send-email-nickey.yang@rock-chips.com> <1511868006-27130-4-git-send-email-nickey.yang@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1511868006-27130-4-git-send-email-nickey.yang@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nickey Yang Cc: mark.rutland@arm.com, airlied@linux.ie, hoegsberg@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, philippe.cornu@st.com, yannick.fertre@st.com, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, zyw@rock-chips.com, xbl@rock-chips.com, mka@chromium.org, hl@rock-chips.com List-Id: linux-rockchip.vger.kernel.org T24gVHVlLCBOb3YgMjgsIDIwMTcgYXQgMDc6MjA6MDRQTSArMDgwMCwgTmlja2V5IFlhbmcgd3Jv dGU6Cj4gVGhpcyBwYXRjaCB1cGRhdGUgZG9jdW1lbnRhdGlvbiBvZiBkZXZpY2UgdHJlZSBiaW5k aW5ncyBmb3IgdGhlIHJvY2tjaGlwCj4gRFNJIGNvbnRyb2xsZXIgYmFzZWQgb24gdGhlIFN5bm9w c3lzIERlc2lnbldhcmUgTUlQSSBEU0kgaG9zdCBjb250cm9sbGVyLgoKSXQgbWlnaHQgaGVscCB0 byBkZXNjcmliZSB3aHkgeW91J3JlIGRvaW5nIHRoaXMuIEp1c3Qgc2F5aW5nICJ1cGRhdGUiIGlz CnByZXR0eSB2YWd1ZS4gSW4gdGhpcyBjYXNlLCBpdCdzIHNvbWV0aGluZyBsaWtlICJkZXNjcmli ZSBwYW5lbC9wb3J0CmxpbmtzLCBpbmNsdWRpbmcgdW5pdCBhZGRyZXNzZXMiLgoKPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBOaWNrZXkgWWFuZyA8bmlja2V5LnlhbmdAcm9jay1jaGlwcy5jb20+Cj4gLS0t Cj4gIC4uLi9kaXNwbGF5L3JvY2tjaGlwL2R3X21pcGlfZHNpX3JvY2tjaGlwLnR4dCAgICAgIHwg MjMgKysrKysrKysrKysrKysrKysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9u cygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcm9ja2NoaXAvZHdfbWlwaV9kc2lfcm9ja2NoaXAudHh0 IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcm9ja2NoaXAvZHdf bWlwaV9kc2lfcm9ja2NoaXAudHh0Cj4gaW5kZXggNmJiNTlhYi4uMzM2OTA5ZCAxMDA2NDQKPiAt LS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9yb2NrY2hpcC9k d19taXBpX2RzaV9yb2NrY2hpcC50eHQKPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3MvZGlzcGxheS9yb2NrY2hpcC9kd19taXBpX2RzaV9yb2NrY2hpcC50eHQKPiBAQCAt MTQsNiArMTQsOCBAQCBSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ICAtIHJvY2tjaGlwLGdyZjogdGhp cyBzb2Mgc2hvdWxkIHNldCBHUkYgcmVncyB0byBtdXggdm9wbC92b3BiLgo+ICAtIHBvcnRzOiBj b250YWluIGEgcG9ydCBub2RlIHdpdGggZW5kcG9pbnQgZGVmaW5pdGlvbnMgYXMgZGVmaW5lZCBp biBbMl0uCj4gICAgRm9yIHZvcGIsc2V0IHRoZSByZWcgPSA8MD4gYW5kIHNldCB0aGUgcmVnID0g PDE+IGZvciB2b3BsLgo+ICstIHZpZGVvIHBvcnQgMCBmb3IgdGhlIFZPUCBpbnB1dCwgdGhlIHJl bW90ZSBlbmRwb2ludCBtYXliZSB2b3BiIG9yIHZvcGwKPiArLSB2aWRlbyBwb3J0IDEgZm9yIGVp dGhlciBhIHBhbmVsIG9yIHN1YnNlcXVlbnQgZW5jb2Rlcgo+ICAKPiAgT3B0aW9uYWwgcHJvcGVy dGllczoKPiAgLSBwb3dlci1kb21haW5zOiBhIHBoYW5kbGUgdG8gbWlwaSBkc2kgcG93ZXIgZG9t YWluIG5vZGUuCj4gQEAgLTQwLDExICs0MiwxMCBAQCBFeGFtcGxlOgo+ICAJCXBvcnRzIHsKPiAg CQkJI2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4gIAkJCSNzaXplLWNlbGxzID0gPDA+Owo+IC0JCQly ZWcgPSA8MT47Cj4gIAo+IC0JCQltaXBpX2luOiBwb3J0IHsKPiAtCQkJCSNhZGRyZXNzLWNlbGxz ID0gPDE+Owo+IC0JCQkJI3NpemUtY2VsbHMgPSA8MD47CgpeXiBZb3UncmUgcmVtb3ZpbmcgI3th ZGRyZXNzLHNpemV9LWNlbGxzIGhlcmUsIGJ1dCB0aGVuIHBvcnRAMCB3aWxsCnN0aWxsIGhhdmUg c3Vibm9kZXMgdGhhdCBoYXZlICdyZWcnIHByb3BlcnRpZXMsIHNvIEkgdGhpbmsgeW91IG5lZWQg dG8Ka2VlcCB0aGUgLWNlbGxzIHByb3BlcnRpZXMuCgpCcmlhbgoKPiArCQkJbWlwaV9pbjogcG9y dEAwIHsKPiArCQkJCXJlZyA9IDwwPjsKPiArCj4gIAkJCQltaXBpX2luX3ZvcGI6IGVuZHBvaW50 QDAgewo+ICAJCQkJCXJlZyA9IDwwPjsKPiAgCQkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8JnZvcGJf b3V0X21pcGk+Owo+IEBAIC01NCw2ICs1NSwxNCBAQCBFeGFtcGxlOgo+ICAJCQkJCXJlbW90ZS1l bmRwb2ludCA9IDwmdm9wbF9vdXRfbWlwaT47Cj4gIAkJCQl9Owo+ICAJCQl9Owo+ICsKPiArCQkJ bWlwaV9vdXQ6IHBvcnRAMSB7Cj4gKwkJCQlyZWcgPSA8MT47Cj4gKwo+ICsJCQkJbWlwaV9vdXRf cGFuZWw6IGVuZHBvaW50IHsKPiArCQkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8JnBhbmVsX2luX21p cGk+Owo+ICsJCQkJfTsKPiArCQkJfTsKPiAgCQl9Owo+ICAKPiAgCQlwYW5lbCB7Cj4gQEAgLTY0 LDUgKzczLDExIEBAIEV4YW1wbGU6Cj4gIAkJCXBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7Cj4g IAkJCXBpbmN0cmwtMCA9IDwmbGNkX2VuPjsKPiAgCQkJYmFja2xpZ2h0ID0gPCZiYWNrbGlnaHQ+ Owo+ICsKPiArCQkJcG9ydCB7Cj4gKwkJCQlwYW5lbF9pbl9taXBpOiBlbmRwb2ludCB7Cj4gKwkJ CQkJcmVtb3RlLWVuZHBvaW50ID0gPCZtaXBpX291dF9wYW5lbD47Cj4gKwkJCQl9Owo+ICsJCQl9 Owo+ICAJCX07Cj4gIAl9Owo+IC0tIAo+IDEuOS4xCj4gCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753553AbdK3Q63 (ORCPT ); Thu, 30 Nov 2017 11:58:29 -0500 Received: from mail-io0-f193.google.com ([209.85.223.193]:38025 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752831AbdK3Q62 (ORCPT ); Thu, 30 Nov 2017 11:58:28 -0500 X-Google-Smtp-Source: AGs4zMYoQU1mM5fDacYWxuhle1J9gd3wd9GNmqCBVDmBDlzyxsiebGyjQYmMnhGnN3u4XWvwBujSAQ== Date: Thu, 30 Nov 2017 08:58:24 -0800 From: Brian Norris To: Nickey Yang Cc: robh+dt@kernel.org, heiko@sntech.de, mark.rutland@arm.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, seanpaul@chromium.org, mka@chromium.org, hoegsberg@gmail.com, architt@codeaurora.org, philippe.cornu@st.com, yannick.fertre@st.com, hl@rock-chips.com, zyw@rock-chips.com, xbl@rock-chips.com Subject: Re: [PATCH v3 3/5] dt-bindings: display: rockchip: update DSI controller Message-ID: <20171130165823.GA140320@google.com> References: <1511868006-27130-1-git-send-email-nickey.yang@rock-chips.com> <1511868006-27130-4-git-send-email-nickey.yang@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511868006-27130-4-git-send-email-nickey.yang@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2017 at 07:20:04PM +0800, Nickey Yang wrote: > This patch update documentation of device tree bindings for the rockchip > DSI controller based on the Synopsys DesignWare MIPI DSI host controller. It might help to describe why you're doing this. Just saying "update" is pretty vague. In this case, it's something like "describe panel/port links, including unit addresses". > > Signed-off-by: Nickey Yang > --- > .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 ++++++++++++++++++---- > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > index 6bb59ab..336909d 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > +++ b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > @@ -14,6 +14,8 @@ Required properties: > - rockchip,grf: this soc should set GRF regs to mux vopl/vopb. > - ports: contain a port node with endpoint definitions as defined in [2]. > For vopb,set the reg = <0> and set the reg = <1> for vopl. > +- video port 0 for the VOP input, the remote endpoint maybe vopb or vopl > +- video port 1 for either a panel or subsequent encoder > > Optional properties: > - power-domains: a phandle to mipi dsi power domain node. > @@ -40,11 +42,10 @@ Example: > ports { > #address-cells = <1>; > #size-cells = <0>; > - reg = <1>; > > - mipi_in: port { > - #address-cells = <1>; > - #size-cells = <0>; ^^ You're removing #{address,size}-cells here, but then port@0 will still have subnodes that have 'reg' properties, so I think you need to keep the -cells properties. Brian > + mipi_in: port@0 { > + reg = <0>; > + > mipi_in_vopb: endpoint@0 { > reg = <0>; > remote-endpoint = <&vopb_out_mipi>; > @@ -54,6 +55,14 @@ Example: > remote-endpoint = <&vopl_out_mipi>; > }; > }; > + > + mipi_out: port@1 { > + reg = <1>; > + > + mipi_out_panel: endpoint { > + remote-endpoint = <&panel_in_mipi>; > + }; > + }; > }; > > panel { > @@ -64,5 +73,11 @@ Example: > pinctrl-names = "default"; > pinctrl-0 = <&lcd_en>; > backlight = <&backlight>; > + > + port { > + panel_in_mipi: endpoint { > + remote-endpoint = <&mipi_out_panel>; > + }; > + }; > }; > }; > -- > 1.9.1 >