From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-path: Received: from mail.free-electrons.com ([62.4.15.54]:40563 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752367AbdK3R0S (ORCPT ); Thu, 30 Nov 2017 12:26:18 -0500 Date: Thu, 30 Nov 2017 18:26:06 +0100 From: Alexandre Belloni To: Guenter Roeck Cc: Peter Rosin , linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland , Nicolas Ferre , Russell King , Jean Delvare , Ludovic Desroches , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org Subject: Re: [PATCH v2 2/2] ARM: dts: at91: disable the nxp,se97b SMBUS timeout on the TSE-850 Message-ID: <20171130172606.GZ21126@piout.net> References: <20171127163101.27859-1-peda@axentia.se> <20171127163101.27859-3-peda@axentia.se> <20171129205311.GA20551@roeck-us.net> <20171129205629.GO21126@piout.net> <20171130171638.GA17788@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171130171638.GA17788@roeck-us.net> Sender: linux-hwmon-owner@vger.kernel.org List-Id: linux-hwmon@vger.kernel.org On 30/11/2017 at 09:16:38 -0800, Guenter Roeck wrote: > On Wed, Nov 29, 2017 at 09:56:29PM +0100, Alexandre Belloni wrote: > > On 29/11/2017 at 12:53:11 -0800, Guenter Roeck wrote: > > > On Mon, Nov 27, 2017 at 05:31:01PM +0100, Peter Rosin wrote: > > > > The I2C adapter driver is sometimes slow, causing the SCL line to > > > > be stuck low for more than the stipulated SMBUS timeout of 25-35 ms. > > > > This causes the client device to give up which in turn causes silent > > > > corruption of data. So, disable the SMBUS timeout in the client device. > > > > > > > > Signed-off-by: Peter Rosin > > > > > > Acked-by: Guenter Roeck > > > > > > I assume this will be sent upstream through an arm tree. > > > > > > > Yes, I'm applying it right now. > > > Are you going to apply the patch for 4.15, or queue it up for 4.16 ? > I have been arguing with myself if this is a feature or a bug fix. > So far I queued the driver change up for 4.16, but I am open to > applying it to 4.15. Any thoughts ? > I was wondering that myself. I'm open to have it as a fix in 4.15. Or maybe Peter can send the series to stable if he needs it in 4.14. Peter, what do you think/want? -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.belloni@free-electrons.com (Alexandre Belloni) Date: Thu, 30 Nov 2017 18:26:06 +0100 Subject: [PATCH v2 2/2] ARM: dts: at91: disable the nxp,se97b SMBUS timeout on the TSE-850 In-Reply-To: <20171130171638.GA17788@roeck-us.net> References: <20171127163101.27859-1-peda@axentia.se> <20171127163101.27859-3-peda@axentia.se> <20171129205311.GA20551@roeck-us.net> <20171129205629.GO21126@piout.net> <20171130171638.GA17788@roeck-us.net> Message-ID: <20171130172606.GZ21126@piout.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 30/11/2017 at 09:16:38 -0800, Guenter Roeck wrote: > On Wed, Nov 29, 2017 at 09:56:29PM +0100, Alexandre Belloni wrote: > > On 29/11/2017 at 12:53:11 -0800, Guenter Roeck wrote: > > > On Mon, Nov 27, 2017 at 05:31:01PM +0100, Peter Rosin wrote: > > > > The I2C adapter driver is sometimes slow, causing the SCL line to > > > > be stuck low for more than the stipulated SMBUS timeout of 25-35 ms. > > > > This causes the client device to give up which in turn causes silent > > > > corruption of data. So, disable the SMBUS timeout in the client device. > > > > > > > > Signed-off-by: Peter Rosin > > > > > > Acked-by: Guenter Roeck > > > > > > I assume this will be sent upstream through an arm tree. > > > > > > > Yes, I'm applying it right now. > > > Are you going to apply the patch for 4.15, or queue it up for 4.16 ? > I have been arguing with myself if this is a feature or a bug fix. > So far I queued the driver change up for 4.16, but I am open to > applying it to 4.15. Any thoughts ? > I was wondering that myself. I'm open to have it as a fix in 4.15. Or maybe Peter can send the series to stable if he needs it in 4.14. Peter, what do you think/want? -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v2 2/2] ARM: dts: at91: disable the nxp,se97b SMBUS timeout on the TSE-850 Date: Thu, 30 Nov 2017 18:26:06 +0100 Message-ID: <20171130172606.GZ21126@piout.net> References: <20171127163101.27859-1-peda@axentia.se> <20171127163101.27859-3-peda@axentia.se> <20171129205311.GA20551@roeck-us.net> <20171129205629.GO21126@piout.net> <20171130171638.GA17788@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20171130171638.GA17788-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Guenter Roeck Cc: Peter Rosin , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Mark Rutland , Nicolas Ferre , Russell King , Jean Delvare , Ludovic Desroches , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-hwmon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 30/11/2017 at 09:16:38 -0800, Guenter Roeck wrote: > On Wed, Nov 29, 2017 at 09:56:29PM +0100, Alexandre Belloni wrote: > > On 29/11/2017 at 12:53:11 -0800, Guenter Roeck wrote: > > > On Mon, Nov 27, 2017 at 05:31:01PM +0100, Peter Rosin wrote: > > > > The I2C adapter driver is sometimes slow, causing the SCL line to > > > > be stuck low for more than the stipulated SMBUS timeout of 25-35 ms. > > > > This causes the client device to give up which in turn causes silent > > > > corruption of data. So, disable the SMBUS timeout in the client device. > > > > > > > > Signed-off-by: Peter Rosin > > > > > > Acked-by: Guenter Roeck > > > > > > I assume this will be sent upstream through an arm tree. > > > > > > > Yes, I'm applying it right now. > > > Are you going to apply the patch for 4.15, or queue it up for 4.16 ? > I have been arguing with myself if this is a feature or a bug fix. > So far I queued the driver change up for 4.16, but I am open to > applying it to 4.15. Any thoughts ? > I was wondering that myself. I'm open to have it as a fix in 4.15. Or maybe Peter can send the series to stable if he needs it in 4.14. Peter, what do you think/want? -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html