All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] Make libnftables a local static library
Date: Thu, 30 Nov 2017 19:30:08 +0100	[thread overview]
Message-ID: <20171130183008.GP32305@orbyte.nwl.cc> (raw)
In-Reply-To: <nycvar.YFH.7.76.1711301835250.31793@n3.vanv.qr>

On Thu, Nov 30, 2017 at 06:36:04PM +0100, Jan Engelhardt wrote:
> 
> On Thursday 2017-11-30 18:11, Phil Sutter wrote:
> 
> >This changes Makefiles so that libnftables is built into a static
> >library which is not installed. This allows for incompatible changes
> >while still providing a library to link to for testing purposes.
> >
> >diff --git a/src/Makefile.am b/src/Makefile.am
> >index 9f7a4bfbb90a4..07ddfd590dd8f 100644
> >--- a/src/Makefile.am
> >+++ b/src/Makefile.am
> >@@ -27,9 +27,9 @@ parser_bison.o scanner.o: AM_CFLAGS += -Wno-missing-prototypes -Wno-missing-decl
> > 
> > BUILT_SOURCES = parser_bison.h
> > 
> >-lib_LTLIBRARIES = libnftables.la
> >+noinst_LIBRARIES = libnftables.a
> 
> Making it a noinst_LTLIBRARIES would have the benefit that its dependencies are
> at least recorded.

Oh, thanks for the hint! I wasn't aware this is supported at all. In
fact, doing so shrinks my patch to a one-liner. :)

Thanks, Phil

  reply	other threads:[~2017-11-30 18:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-24 14:02 static libnftables by now? Pablo Neira Ayuso
2017-11-30 17:11 ` [nft PATCH] Make libnftables a local static library Phil Sutter
2017-11-30 17:36   ` Jan Engelhardt
2017-11-30 18:30     ` Phil Sutter [this message]
2017-11-30 18:36       ` [nft PATCH v2] " Phil Sutter
2017-12-04 10:06         ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171130183008.GP32305@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=jengelh@inai.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.