Re: [PATCH 1/5] xfs_db: print structure padding fields consistently

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Thu, Nov 30, 2017 at 03:57:16PM -0600, Eric Sandeen wrote:
> 
> 
> On 11/30/17 3:51 PM, Darrick J. Wong wrote:
> > On Thu, Nov 30, 2017 at 03:37:54PM -0600, Eric Sandeen wrote:
> >> On 11/17/17 1:56 PM, Darrick J. Wong wrote:
> >>> From: Darrick J. Wong <darrick.wong@oracle.com>
> >>>
> >>> We are very inconsistent about how we print padding fields in on-disk
> >>> structures -- sometimes we hide it from printall, sometimes we deviate
> >>> from unsigned hex values, etc.  Make this all consistent -- never hide
> >>> padding values, always print them as unsigned hex integers.
> >>
> >> I'm not sure I see the point to cluttering up structure printing
> >> with padding, and would prefer to hide them /all/ by default (and
> >> set them all to hex printing when explicitly asked for).
> >>
> >> Consistency is good but I'm not sure we need to consistently print
> >> values that are never even used...?
> > 
> > Ok.  Will you take a patch that changes them all to FLD_SKIPALL?
> 
> and sets them all to hex type, and adds missing ones?  Sure.
> 
> If you love the idea of printing padding or need it, that's ok,
> I'd just like a little justification for the extra clutter,
> if you need it. :)

Originally it was so that the fuzz tests could test whether or not
fsck/scrub notice garbage in the padding fields but then I observed that
we don't consistently write zeroes to padd fields, which means that we
can't check them in any meaningful manner.

--D

> Thanks,
> -Eric
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html