All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Linux perf users list <linux-perf-users@vger.kernel.org>,
	Linux s390 list <linux-s390@vger.kernel.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Thomas Richter <tmricht@linux.vnet.ibm.com>,
	jonathan.hermann@de.ibm.com, kernel-team@lge.com,
	jolsa@kernel.org
Subject: Re: [PATCH] perf s390: always build with -fPIC
Date: Fri, 1 Dec 2017 11:17:09 +0900	[thread overview]
Message-ID: <20171201021709.GB30867@sejong> (raw)
In-Reply-To: <1512031765-9382-1-git-send-email-brueckner@linux.vnet.ibm.com>

(+ Jiri)

Hello,

On Thu, Nov 30, 2017 at 09:49:25AM +0100, Hendrik Brueckner wrote:
> On s390, object files must be compiled with position-indepedent code
> in order to be incrementally linked or linked to shared libraries.
> Therefore, add -fPIC to the CFLAGS for s390 to ensure each object
> file is built properly.

Could you please tell me what was the actual problem?  I guess this is
somewhat related to the Jiri's Fedora build fix.

Thanks,
Namhyung


> 
> Reported-by: Jonathan Hermann <jonathan.hermann@de.ibm.com>
> Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
> ---
>  tools/perf/Makefile.config | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index ed65e82..0833d9f 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -55,6 +55,7 @@ endif
>  
>  ifeq ($(ARCH),s390)
>    NO_PERF_REGS := 0
> +  CFLAGS += -fPIC
>  endif
>  
>  ifeq ($(NO_PERF_REGS),0)
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-perf-users" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-12-01  2:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30  8:49 [PATCH] perf s390: always build with -fPIC Hendrik Brueckner
2017-12-01  2:17 ` Namhyung Kim [this message]
2017-12-01 14:12   ` Hendrik Brueckner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171201021709.GB30867@sejong \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=brueckner@linux.vnet.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jolsa@kernel.org \
    --cc=jonathan.hermann@de.ibm.com \
    --cc=kernel-team@lge.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=tmricht@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.