From mboxrd@z Thu Jan  1 00:00:00 1970
From: Brian Norris <briannorris@chromium.org>
Subject: Re: [RESENT PATCH] drm/panel: support Innolux P097PFG panel
Date: Thu, 30 Nov 2017 18:28:50 -0800
Message-ID: <20171201022848.GA137960@google.com>
References: <1512022480-7015-1-git-send-email-hl@rock-chips.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-it0-x243.google.com (mail-it0-x243.google.com
 [IPv6:2607:f8b0:4001:c0b::243])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 3BDEB6E072
 for <dri-devel@lists.freedesktop.org>; Fri,  1 Dec 2017 02:28:54 +0000 (UTC)
Received: by mail-it0-x243.google.com with SMTP id t1so857701ite.5
 for <dri-devel@lists.freedesktop.org>; Thu, 30 Nov 2017 18:28:54 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1512022480-7015-1-git-send-email-hl@rock-chips.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Lin Huang <hl@rock-chips.com>
Cc: airlied@linux.ie, Derek Basehore <dbasehore@chromium.org>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, nickey.yang@rock-chips.com, thierry.reding@gmail.com, zyw@rock-chips.com
List-Id: dri-devel@lists.freedesktop.org

KyBEZXJlawoKT24gVGh1LCBOb3YgMzAsIDIwMTcgYXQgMDI6MTQ6NDBQTSArMDgwMCwgTGluIEh1
YW5nIHdyb3RlOgo+IFN1cHBvcnQgSW5ub2x1eCBQMDk3UEZHIDkuNyIgMTUzNngyMDQ4IFRGVCBM
Q0QgcGFuZWwsCj4gaXQgcmVmYWN0b3IgSW5ub2x1eCBQMDc5WkNBIHBhbmVsIGRyaXZlciwgbGV0
IGl0IHN1cHBvcnQKPiBtdWx0aSBwYW5lbCwgYW5kIGFkZCBzdXBwb3J0IFAwOTdQRkcgcGFuZWwg
aW4gdGhpcyBkcml2ZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogTGluIEh1YW5nIDxobEByb2NrLWNo
aXBzLmNvbT4KPiAKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLWlubm9sdXgt
cDA3OXpjYS5jIHwgMTc4ICsrKysrKysrKysrKysrKysrKysrLS0tLS0tCj4gIDEgZmlsZSBjaGFu
Z2VkLCAxMzYgaW5zZXJ0aW9ucygrKSwgNDIgZGVsZXRpb25zKC0pCgpZb3UnbGwgd2FudCB0byBh
ZGQgdGhpcyB0byB0aGUgZGV2aWNlIHRyZWUgYmluZGluZ3MuCgpCcmlhbgoKPiAKPiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLWlubm9sdXgtcDA3OXpjYS5jIGIvZHJp
dmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLWlubm9sdXgtcDA3OXpjYS5jCj4gaW5kZXggNmJhOTM0
NC4uYTQwNzk4ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtaW5u
b2x1eC1wMDc5emNhLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtaW5ub2x1
eC1wMDc5emNhLmMKPiBAQCAtMjAsMTIgKzIwLDMyIEBACj4gIAo+ICAjaW5jbHVkZSA8dmlkZW8v
bWlwaV9kaXNwbGF5Lmg+Cj4gIAo+ICtzdHJ1Y3QgcGFuZWxfZGVzYyB7Cj4gKwljb25zdCBzdHJ1
Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZXM7Cj4gKwl1bnNpZ25lZCBpbnQgYnBjOwo+ICsJc3Ry
dWN0IHsKPiArCQl1bnNpZ25lZCBpbnQgd2lkdGg7Cj4gKwkJdW5zaWduZWQgaW50IGhlaWdodDsK
PiArCX0gc2l6ZTsKPiArfTsKPiArCj4gK3N0cnVjdCBwYW5lbF9kZXNjX2RzaSB7Cj4gKwlzdHJ1
Y3QgcGFuZWxfZGVzYyBkZXNjOwo+ICsKPiArCXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4gKwllbnVt
IG1pcGlfZHNpX3BpeGVsX2Zvcm1hdCBmb3JtYXQ7Cj4gKwl1bnNpZ25lZCBpbnQgbGFuZXM7Cj4g
K307Cj4gKwo+ICBzdHJ1Y3QgaW5ub2x1eF9wYW5lbCB7Cj4gIAlzdHJ1Y3QgZHJtX3BhbmVsIGJh
c2U7Cj4gIAlzdHJ1Y3QgbWlwaV9kc2lfZGV2aWNlICpsaW5rOwo+ICsJY29uc3Qgc3RydWN0IHBh
bmVsX2Rlc2NfZHNpICpkc2lfZGVzYzsKPiAgCj4gIAlzdHJ1Y3QgYmFja2xpZ2h0X2RldmljZSAq
YmFja2xpZ2h0Owo+IC0Jc3RydWN0IHJlZ3VsYXRvciAqc3VwcGx5Owo+ICsJc3RydWN0IHJlZ3Vs
YXRvciAqdmRkaTsKPiArCXN0cnVjdCByZWd1bGF0b3IgKmF2ZGQ7Cj4gKwlzdHJ1Y3QgcmVndWxh
dG9yICphdmVlOwo+ICAJc3RydWN0IGdwaW9fZGVzYyAqZW5hYmxlX2dwaW87Cj4gIAo+ICAJYm9v
bCBwcmVwYXJlZDsKPiBAQCAtNzgsOSArOTgsOSBAQCBzdGF0aWMgaW50IGlubm9sdXhfcGFuZWxf
dW5wcmVwYXJlKHN0cnVjdCBkcm1fcGFuZWwgKnBhbmVsKQo+ICAJLyogVDg6IDgwbXMgLSAxMDAw
bXMgKi8KPiAgCW1zbGVlcCg4MCk7Cj4gIAo+IC0JZXJyID0gcmVndWxhdG9yX2Rpc2FibGUoaW5u
b2x1eC0+c3VwcGx5KTsKPiAtCWlmIChlcnIgPCAwKQo+IC0JCXJldHVybiBlcnI7Cj4gKwlyZWd1
bGF0b3JfZGlzYWJsZShpbm5vbHV4LT5hdmVlKTsKPiArCXJlZ3VsYXRvcl9kaXNhYmxlKGlubm9s
dXgtPmF2ZGQpOwo+ICsJcmVndWxhdG9yX2Rpc2FibGUoaW5ub2x1eC0+dmRkaSk7Cj4gIAo+ICAJ
aW5ub2x1eC0+cHJlcGFyZWQgPSBmYWxzZTsKPiAgCj4gQEAgLTk3LDEwICsxMTcsMTggQEAgc3Rh
dGljIGludCBpbm5vbHV4X3BhbmVsX3ByZXBhcmUoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwpCj4g
IAo+ICAJZ3Bpb2Rfc2V0X3ZhbHVlX2NhbnNsZWVwKGlubm9sdXgtPmVuYWJsZV9ncGlvLCAwKTsK
PiAgCj4gLQllcnIgPSByZWd1bGF0b3JfZW5hYmxlKGlubm9sdXgtPnN1cHBseSk7Cj4gKwllcnIg
PSByZWd1bGF0b3JfZW5hYmxlKGlubm9sdXgtPnZkZGkpOwo+ICAJaWYgKGVyciA8IDApCj4gIAkJ
cmV0dXJuIGVycjsKPiAgCj4gKwllcnIgPSByZWd1bGF0b3JfZW5hYmxlKGlubm9sdXgtPmF2ZGQp
Owo+ICsJaWYgKGVyciA8IDApCj4gKwkJZ290byBkaXNhYmxlX3ZkZGk7Cj4gKwo+ICsJZXJyID0g
cmVndWxhdG9yX2VuYWJsZShpbm5vbHV4LT5hdmVlKTsKPiArCWlmIChlcnIgPCAwKQo+ICsJCWdv
dG8gZGlzYWJsZV9hdmRkOwo+ICsKPiAgCS8qIFQyOiAxNW1zIC0gMTAwMG1zICovCj4gIAl1c2xl
ZXBfcmFuZ2UoMTUwMDAsIDE2MDAwKTsKPiAgCj4gQEAgLTEzNCwxMiArMTYyLDEzIEBAIHN0YXRp
YyBpbnQgaW5ub2x1eF9wYW5lbF9wcmVwYXJlKHN0cnVjdCBkcm1fcGFuZWwgKnBhbmVsKQo+ICAJ
cmV0dXJuIDA7Cj4gIAo+ICBwb3dlcm9mZjoKPiAtCXJlZ3VsYXRvcl9lcnIgPSByZWd1bGF0b3Jf
ZGlzYWJsZShpbm5vbHV4LT5zdXBwbHkpOwo+IC0JaWYgKHJlZ3VsYXRvcl9lcnIpCj4gLQkJRFJN
X0RFVl9FUlJPUihwYW5lbC0+ZGV2LCAiZmFpbGVkIHRvIGRpc2FibGUgcmVndWxhdG9yOiAlZFxu
IiwKPiAtCQkJICAgICAgcmVndWxhdG9yX2Vycik7Cj4gLQo+ICAJZ3Bpb2Rfc2V0X3ZhbHVlX2Nh
bnNsZWVwKGlubm9sdXgtPmVuYWJsZV9ncGlvLCAwKTsKPiArCXJlZ3VsYXRvcl9kaXNhYmxlKGlu
bm9sdXgtPmF2ZWUpOwo+ICtkaXNhYmxlX2F2ZGQ6Cj4gKwlyZWd1bGF0b3JfZGlzYWJsZShpbm5v
bHV4LT5hdmRkKTsKPiArZGlzYWJsZV92ZGRpOgo+ICsJcmVndWxhdG9yX2Rpc2FibGUoaW5ub2x1
eC0+dmRkaSk7Cj4gKwo+ICAJcmV0dXJuIGVycjsKPiAgfQo+ICAKPiBAQCAtMTY0LDcgKzE5Myw3
IEBAIHN0YXRpYyBpbnQgaW5ub2x1eF9wYW5lbF9lbmFibGUoc3RydWN0IGRybV9wYW5lbCAqcGFu
ZWwpCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiAtc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZGlz
cGxheV9tb2RlIGRlZmF1bHRfbW9kZSA9IHsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZGlz
cGxheV9tb2RlIGlubm9sdXhfcDA3OXpjYV9tb2RlID0gewo+ICAJLmNsb2NrID0gNTY5MDAsCj4g
IAkuaGRpc3BsYXkgPSA3NjgsCj4gIAkuaHN5bmNfc3RhcnQgPSA3NjggKyA0MCwKPiBAQCAtMTc3
LDE1ICsyMDYsNTkgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlIGRlZmF1
bHRfbW9kZSA9IHsKPiAgCS52cmVmcmVzaCA9IDYwLAo+ICB9Owo+ICAKPiArc3RhdGljIGNvbnN0
IHN0cnVjdCBwYW5lbF9kZXNjX2RzaSBpbm5vbHV4X3AwNzl6Y2FfcGFuZWxfZGVzYyA9IHsKPiAr
CS5kZXNjID0gewo+ICsJCS5tb2RlcyA9ICZpbm5vbHV4X3AwNzl6Y2FfbW9kZSwKPiArCQkuYnBj
ID0gOCwKPiArCQkuc2l6ZSA9IHsKPiArCQkJLndpZHRoID0gMTIwLAo+ICsJCQkuaGVpZ2h0ID0g
MTYwLAo+ICsJCX0sCj4gKwl9LAo+ICsJLmZsYWdzID0gTUlQSV9EU0lfTU9ERV9WSURFTyB8IE1J
UElfRFNJX01PREVfVklERU9fU1lOQ19QVUxTRSB8Cj4gKwkJIE1JUElfRFNJX01PREVfTFBNLAo+
ICsJLmZvcm1hdCA9IE1JUElfRFNJX0ZNVF9SR0I4ODgsCj4gKwkubGFuZXMgPSA0LAo+ICt9Owo+
ICsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlIGlubm9sdXhfcDA5N3Bm
Z19tb2RlID0gewo+ICsJLmNsb2NrID0gMjIwMDAwLAo+ICsJLmhkaXNwbGF5ID0gMTUzNiwKPiAr
CS5oc3luY19zdGFydCA9IDE1MzYgKyAxMDAsCj4gKwkuaHN5bmNfZW5kID0gMTUzNiArIDEwMCAr
IDI0LAo+ICsJLmh0b3RhbCA9IDE1MzYgKyAxMDAgKyAyNCArIDEwMCwKPiArCS52ZGlzcGxheSA9
IDIwNDgsCj4gKwkudnN5bmNfc3RhcnQgPSAyMDQ4ICsgMTgsCj4gKwkudnN5bmNfZW5kID0gMjA0
OCArIDE4ICsgMiwKPiArCS52dG90YWwgPSAyMDQ4ICsgMTggKyAyICsgMTgsCj4gKwkudnJlZnJl
c2ggPSA2MCwKPiArfTsKPiArCj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgcGFuZWxfZGVzY19kc2kg
aW5ub2x1eF9wMDk3cGZnX3BhbmVsX2Rlc2MgPSB7Cj4gKwkuZGVzYyA9IHsKPiArCQkubW9kZXMg
PSAmaW5ub2x1eF9wMDk3cGZnX21vZGUsCj4gKwkJLmJwYyA9IDgsCj4gKwkJLnNpemUgPSB7Cj4g
KwkJCS53aWR0aCA9IDE0NywKPiArCQkJLmhlaWdodCA9IDE5NiwKPiArCQl9LAo+ICsJfSwKPiAr
CS5mbGFncyA9IE1JUElfRFNJX01PREVfVklERU8gfCBNSVBJX0RTSV9NT0RFX1ZJREVPX1NZTkNf
UFVMU0UgfAo+ICsJCSBNSVBJX0RTSV9NT0RFX0xQTSwKPiArCS5mb3JtYXQgPSBNSVBJX0RTSV9G
TVRfUkdCODg4LAo+ICsJLmxhbmVzID0gOCwKPiArfTsKPiArCj4gIHN0YXRpYyBpbnQgaW5ub2x1
eF9wYW5lbF9nZXRfbW9kZXMoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwpCj4gIHsKPiAgCXN0cnVj
dCBkcm1fZGlzcGxheV9tb2RlICptb2RlOwo+ICsJc3RydWN0IGlubm9sdXhfcGFuZWwgKmlubm9s
dXggPSB0b19pbm5vbHV4X3BhbmVsKHBhbmVsKTsKPiArCWNvbnN0IHN0cnVjdCBkcm1fZGlzcGxh
eV9tb2RlICptID0gaW5ub2x1eC0+ZHNpX2Rlc2MtPmRlc2MubW9kZXM7Cj4gIAo+IC0JbW9kZSA9
IGRybV9tb2RlX2R1cGxpY2F0ZShwYW5lbC0+ZHJtLCAmZGVmYXVsdF9tb2RlKTsKPiArCW1vZGUg
PSBkcm1fbW9kZV9kdXBsaWNhdGUocGFuZWwtPmRybSwgbSk7Cj4gIAlpZiAoIW1vZGUpIHsKPiAg
CQlEUk1fREVWX0VSUk9SKHBhbmVsLT5kcm0tPmRldiwgImZhaWxlZCB0byBhZGQgbW9kZSAldXgl
dXhAJXVcbiIsCj4gLQkJCSAgICAgIGRlZmF1bHRfbW9kZS5oZGlzcGxheSwgZGVmYXVsdF9tb2Rl
LnZkaXNwbGF5LAo+IC0JCQkgICAgICBkZWZhdWx0X21vZGUudnJlZnJlc2gpOwo+ICsJCQkgICAg
ICBtLT5oZGlzcGxheSwgbS0+dmRpc3BsYXksIG0tPnZyZWZyZXNoKTsKPiAgCQlyZXR1cm4gLUVO
T01FTTsKPiAgCX0KPiAgCj4gQEAgLTE5Myw5ICsyNjYsMTEgQEAgc3RhdGljIGludCBpbm5vbHV4
X3BhbmVsX2dldF9tb2RlcyhzdHJ1Y3QgZHJtX3BhbmVsICpwYW5lbCkKPiAgCj4gIAlkcm1fbW9k
ZV9wcm9iZWRfYWRkKHBhbmVsLT5jb25uZWN0b3IsIG1vZGUpOwo+ICAKPiAtCXBhbmVsLT5jb25u
ZWN0b3ItPmRpc3BsYXlfaW5mby53aWR0aF9tbSA9IDEyMDsKPiAtCXBhbmVsLT5jb25uZWN0b3It
PmRpc3BsYXlfaW5mby5oZWlnaHRfbW0gPSAxNjA7Cj4gLQlwYW5lbC0+Y29ubmVjdG9yLT5kaXNw
bGF5X2luZm8uYnBjID0gODsKPiArCXBhbmVsLT5jb25uZWN0b3ItPmRpc3BsYXlfaW5mby53aWR0
aF9tbSA9Cj4gKwkJCWlubm9sdXgtPmRzaV9kZXNjLT5kZXNjLnNpemUud2lkdGg7Cj4gKwlwYW5l
bC0+Y29ubmVjdG9yLT5kaXNwbGF5X2luZm8uaGVpZ2h0X21tID0KPiArCQkJaW5ub2x1eC0+ZHNp
X2Rlc2MtPmRlc2Muc2l6ZS5oZWlnaHQ7Cj4gKwlwYW5lbC0+Y29ubmVjdG9yLT5kaXNwbGF5X2lu
Zm8uYnBjID0gaW5ub2x1eC0+ZHNpX2Rlc2MtPmRlc2MuYnBjOwo+ICAKPiAgCXJldHVybiAxOwo+
ICB9Cj4gQEAgLTIwOSwyMCArMjg0LDM5IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX3BhbmVs
X2Z1bmNzIGlubm9sdXhfcGFuZWxfZnVuY3MgPSB7Cj4gIH07Cj4gIAo+ICBzdGF0aWMgY29uc3Qg
c3RydWN0IG9mX2RldmljZV9pZCBpbm5vbHV4X29mX21hdGNoW10gPSB7Cj4gLQl7IC5jb21wYXRp
YmxlID0gImlubm9sdXgscDA3OXpjYSIsIH0sCj4gLQl7IH0KPiArCXsgLmNvbXBhdGlibGUgPSAi
aW5ub2x1eCxwMDc5emNhIiwKPiArCSAgLmRhdGEgPSAmaW5ub2x1eF9wMDc5emNhX3BhbmVsX2Rl
c2MKPiArCX0sCj4gKwl7IC5jb21wYXRpYmxlID0gImlubm9sdXgscDA5N3BmZyIsCj4gKwkgIC5k
YXRhID0gJmlubm9sdXhfcDA5N3BmZ19wYW5lbF9kZXNjCj4gKwl9Cj4gIH07Cj4gIE1PRFVMRV9E
RVZJQ0VfVEFCTEUob2YsIGlubm9sdXhfb2ZfbWF0Y2gpOwo+ICAKPiAtc3RhdGljIGludCBpbm5v
bHV4X3BhbmVsX2FkZChzdHJ1Y3QgaW5ub2x1eF9wYW5lbCAqaW5ub2x1eCkKPiArc3RhdGljIGlu
dCBpbm5vbHV4X3BhbmVsX2FkZChzdHJ1Y3QgbWlwaV9kc2lfZGV2aWNlICpkc2ksCj4gKwkJCSAg
ICAgY29uc3Qgc3RydWN0IHBhbmVsX2Rlc2NfZHNpICpkZXNjKQo+ICB7Cj4gLQlzdHJ1Y3QgZGV2
aWNlICpkZXYgPSAmaW5ub2x1eC0+bGluay0+ZGV2Owo+ICsJc3RydWN0IGlubm9sdXhfcGFuZWwg
Kmlubm9sdXg7Cj4gKwlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmZHNpLT5kZXY7Cj4gIAlzdHJ1Y3Qg
ZGV2aWNlX25vZGUgKm5wOwo+ICAJaW50IGVycjsKPiAgCj4gLQlpbm5vbHV4LT5zdXBwbHkgPSBk
ZXZtX3JlZ3VsYXRvcl9nZXQoZGV2LCAicG93ZXIiKTsKPiAtCWlmIChJU19FUlIoaW5ub2x1eC0+
c3VwcGx5KSkKPiAtCQlyZXR1cm4gUFRSX0VSUihpbm5vbHV4LT5zdXBwbHkpOwo+ICsJaW5ub2x1
eCA9IGRldm1fa3phbGxvYyhkZXYsIHNpemVvZigqaW5ub2x1eCksIEdGUF9LRVJORUwpOwo+ICsJ
aWYgKCFpbm5vbHV4KQo+ICsJCXJldHVybiAtRU5PTUVNOwo+ICsKPiArCWlubm9sdXgtPmRzaV9k
ZXNjID0gZGVzYzsKPiArCWlubm9sdXgtPnZkZGkgPSBkZXZtX3JlZ3VsYXRvcl9nZXRfb3B0aW9u
YWwoZGV2LCAicG93ZXIiKTsKPiArCWlmIChJU19FUlIoaW5ub2x1eC0+dmRkaSkpCj4gKwkJcmV0
dXJuIFBUUl9FUlIoaW5ub2x1eC0+dmRkaSk7Cj4gKwo+ICsJaW5ub2x1eC0+YXZkZCA9IGRldm1f
cmVndWxhdG9yX2dldChkZXYsICJwcHZhcnAiKTsKPiArCWlmIChJU19FUlIoaW5ub2x1eC0+YXZk
ZCkpCj4gKwkJcmV0dXJuIFBUUl9FUlIoaW5ub2x1eC0+YXZkZCk7Cj4gKwo+ICsJaW5ub2x1eC0+
YXZlZSA9IGRldm1fcmVndWxhdG9yX2dldChkZXYsICJwcHZhcm4iKTsKPiArCWlmIChJU19FUlIo
aW5ub2x1eC0+YXZlZSkpCj4gKwkJcmV0dXJuIFBUUl9FUlIoaW5ub2x1eC0+YXZlZSk7Cj4gIAo+
ICAJaW5ub2x1eC0+ZW5hYmxlX2dwaW8gPSBkZXZtX2dwaW9kX2dldF9vcHRpb25hbChkZXYsICJl
bmFibGUiLAo+ICAJCQkJCQkgICAgICAgR1BJT0RfT1VUX0hJR0gpOwo+IEBAIC0yNDMsMTQgKzMz
NywxNiBAQCBzdGF0aWMgaW50IGlubm9sdXhfcGFuZWxfYWRkKHN0cnVjdCBpbm5vbHV4X3BhbmVs
ICppbm5vbHV4KQo+ICAKPiAgCWRybV9wYW5lbF9pbml0KCZpbm5vbHV4LT5iYXNlKTsKPiAgCWlu
bm9sdXgtPmJhc2UuZnVuY3MgPSAmaW5ub2x1eF9wYW5lbF9mdW5jczsKPiAtCWlubm9sdXgtPmJh
c2UuZGV2ID0gJmlubm9sdXgtPmxpbmstPmRldjsKPiArCWlubm9sdXgtPmJhc2UuZGV2ID0gZGV2
Owo+ICAKPiAgCWVyciA9IGRybV9wYW5lbF9hZGQoJmlubm9sdXgtPmJhc2UpOwo+ICAJaWYgKGVy
ciA8IDApCj4gIAkJZ290byBwdXRfYmFja2xpZ2h0Owo+ICAKPiAtCXJldHVybiAwOwo+ICsJZGV2
X3NldF9kcnZkYXRhKGRldiwgaW5ub2x1eCk7Cj4gKwlpbm5vbHV4LT5saW5rID0gZHNpOwo+ICAK
PiArCXJldHVybiAwOwo+ICBwdXRfYmFja2xpZ2h0Ogo+ICAJcHV0X2RldmljZSgmaW5ub2x1eC0+
YmFja2xpZ2h0LT5kZXYpOwo+ICAKPiBAQCAtMjY3LDI4ICszNjMsMjUgQEAgc3RhdGljIHZvaWQg
aW5ub2x1eF9wYW5lbF9kZWwoc3RydWN0IGlubm9sdXhfcGFuZWwgKmlubm9sdXgpCj4gIAo+ICBz
dGF0aWMgaW50IGlubm9sdXhfcGFuZWxfcHJvYmUoc3RydWN0IG1pcGlfZHNpX2RldmljZSAqZHNp
KQo+ICB7Cj4gLQlzdHJ1Y3QgaW5ub2x1eF9wYW5lbCAqaW5ub2x1eDsKPiAtCWludCBlcnI7Cj4g
LQo+IC0JZHNpLT5sYW5lcyA9IDQ7Cj4gLQlkc2ktPmZvcm1hdCA9IE1JUElfRFNJX0ZNVF9SR0I4
ODg7Cj4gLQlkc2ktPm1vZGVfZmxhZ3MgPSBNSVBJX0RTSV9NT0RFX1ZJREVPIHwgTUlQSV9EU0lf
TU9ERV9WSURFT19TWU5DX1BVTFNFIHwKPiAtCQkJICBNSVBJX0RTSV9NT0RFX0xQTTsKPiAgCj4g
LQlpbm5vbHV4ID0gZGV2bV9remFsbG9jKCZkc2ktPmRldiwgc2l6ZW9mKCppbm5vbHV4KSwgR0ZQ
X0tFUk5FTCk7Cj4gLQlpZiAoIWlubm9sdXgpCj4gLQkJcmV0dXJuIC1FTk9NRU07Cj4gKwljb25z
dCBzdHJ1Y3QgcGFuZWxfZGVzY19kc2kgKmRzaV9kZXNjOwo+ICsJY29uc3Qgc3RydWN0IG9mX2Rl
dmljZV9pZCAqaWQ7Cj4gKwlpbnQgZXJyOwo+ICAKPiAtCW1pcGlfZHNpX3NldF9kcnZkYXRhKGRz
aSwgaW5ub2x1eCk7Cj4gKwlpZCA9IG9mX21hdGNoX25vZGUoaW5ub2x1eF9vZl9tYXRjaCwgZHNp
LT5kZXYub2Zfbm9kZSk7Cj4gKwlpZiAoIWlkKQo+ICsJCXJldHVybiAtRU5PREVWOwo+ICAKPiAt
CWlubm9sdXgtPmxpbmsgPSBkc2k7Cj4gKwlkc2lfZGVzYyA9IGlkLT5kYXRhOwo+ICsJZHNpLT5t
b2RlX2ZsYWdzID0gZHNpX2Rlc2MtPmZsYWdzOwo+ICsJZHNpLT5mb3JtYXQgPSBkc2lfZGVzYy0+
Zm9ybWF0Owo+ICsJZHNpLT5sYW5lcyA9IGRzaV9kZXNjLT5sYW5lczsKPiAgCj4gLQllcnIgPSBp
bm5vbHV4X3BhbmVsX2FkZChpbm5vbHV4KTsKPiArCWVyciA9IGlubm9sdXhfcGFuZWxfYWRkKGRz
aSwgZHNpX2Rlc2MpOwo+ICAJaWYgKGVyciA8IDApCj4gIAkJcmV0dXJuIGVycjsKPiAgCj4gLQll
cnIgPSBtaXBpX2RzaV9hdHRhY2goZHNpKTsKPiAtCXJldHVybiBlcnI7Cj4gKwlyZXR1cm4gbWlw
aV9kc2lfYXR0YWNoKGRzaSk7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgaW5ub2x1eF9wYW5lbF9y
ZW1vdmUoc3RydWN0IG1pcGlfZHNpX2RldmljZSAqZHNpKQo+IEBAIC0zMjYsNyArNDE5LDcgQEAg
c3RhdGljIHZvaWQgaW5ub2x1eF9wYW5lbF9zaHV0ZG93bihzdHJ1Y3QgbWlwaV9kc2lfZGV2aWNl
ICpkc2kpCj4gIAo+ICBzdGF0aWMgc3RydWN0IG1pcGlfZHNpX2RyaXZlciBpbm5vbHV4X3BhbmVs
X2RyaXZlciA9IHsKPiAgCS5kcml2ZXIgPSB7Cj4gLQkJLm5hbWUgPSAicGFuZWwtaW5ub2x1eC1w
MDc5emNhIiwKPiArCQkubmFtZSA9ICJwYW5lbC1pbm5vbHV4LWRzaSIsCj4gIAkJLm9mX21hdGNo
X3RhYmxlID0gaW5ub2x1eF9vZl9tYXRjaCwKPiAgCX0sCj4gIAkucHJvYmUgPSBpbm5vbHV4X3Bh
bmVsX3Byb2JlLAo+IEBAIC0zMzYsNSArNDI5LDYgQEAgc3RhdGljIHN0cnVjdCBtaXBpX2RzaV9k
cml2ZXIgaW5ub2x1eF9wYW5lbF9kcml2ZXIgPSB7Cj4gIG1vZHVsZV9taXBpX2RzaV9kcml2ZXIo
aW5ub2x1eF9wYW5lbF9kcml2ZXIpOwo+ICAKPiAgTU9EVUxFX0FVVEhPUigiQ2hyaXMgWmhvbmcg
PHp5d0Byb2NrLWNoaXBzLmNvbT4iKTsKPiArTU9EVUxFX0FVVEhPUigiTGluIEh1YW5nIDxobEBy
b2NrLWNoaXBzLmNvbT4iKTsKPiAgTU9EVUxFX0RFU0NSSVBUSU9OKCJJbm5vbHV4IFAwNzlaQ0Eg
cGFuZWwgZHJpdmVyIik7Cj4gIE1PRFVMRV9MSUNFTlNFKCJHUEwgdjIiKTsKPiAtLSAKPiAyLjcu
NAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt
ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6
Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752031AbdLAC2z (ORCPT <rfc822;w@1wt.eu>);
        Thu, 30 Nov 2017 21:28:55 -0500
Received: from mail-it0-f65.google.com ([209.85.214.65]:39185 "EHLO
        mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751007AbdLAC2y (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Nov 2017 21:28:54 -0500
X-Google-Smtp-Source: AGs4zMYz2EHScEcSoEsDrAeMr7Pi73ebZBDyDT/ipocBOYX9gtPeSR3R2efRLQjB7VmPeE669OhRRg==
Date: Thu, 30 Nov 2017 18:28:50 -0800
From: Brian Norris <briannorris@chromium.org>
To: Lin Huang <hl@rock-chips.com>
Cc: thierry.reding@gmail.com, zyw@rock-chips.com, seanpaul@chromium.org,
        nickey.yang@rock-chips.com, airlied@linux.ie,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Derek Basehore <dbasehore@chromium.org>
Subject: Re: [RESENT PATCH] drm/panel: support Innolux P097PFG panel
Message-ID: <20171201022848.GA137960@google.com>
References: <1512022480-7015-1-git-send-email-hl@rock-chips.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1512022480-7015-1-git-send-email-hl@rock-chips.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+ Derek

On Thu, Nov 30, 2017 at 02:14:40PM +0800, Lin Huang wrote:
> Support Innolux P097PFG 9.7" 1536x2048 TFT LCD panel,
> it refactor Innolux P079ZCA panel driver, let it support
> multi panel, and add support P097PFG panel in this driver.
> 
> Signed-off-by: Lin Huang <hl@rock-chips.com>
> 
> ---
>  drivers/gpu/drm/panel/panel-innolux-p079zca.c | 178 ++++++++++++++++++++------
>  1 file changed, 136 insertions(+), 42 deletions(-)

You'll want to add this to the device tree bindings.

Brian

> 
> diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> index 6ba9344..a40798f 100644
> --- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> +++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> @@ -20,12 +20,32 @@
>  
>  #include <video/mipi_display.h>
>  
> +struct panel_desc {
> +	const struct drm_display_mode *modes;
> +	unsigned int bpc;
> +	struct {
> +		unsigned int width;
> +		unsigned int height;
> +	} size;
> +};
> +
> +struct panel_desc_dsi {
> +	struct panel_desc desc;
> +
> +	unsigned long flags;
> +	enum mipi_dsi_pixel_format format;
> +	unsigned int lanes;
> +};
> +
>  struct innolux_panel {
>  	struct drm_panel base;
>  	struct mipi_dsi_device *link;
> +	const struct panel_desc_dsi *dsi_desc;
>  
>  	struct backlight_device *backlight;
> -	struct regulator *supply;
> +	struct regulator *vddi;
> +	struct regulator *avdd;
> +	struct regulator *avee;
>  	struct gpio_desc *enable_gpio;
>  
>  	bool prepared;
> @@ -78,9 +98,9 @@ static int innolux_panel_unprepare(struct drm_panel *panel)
>  	/* T8: 80ms - 1000ms */
>  	msleep(80);
>  
> -	err = regulator_disable(innolux->supply);
> -	if (err < 0)
> -		return err;
> +	regulator_disable(innolux->avee);
> +	regulator_disable(innolux->avdd);
> +	regulator_disable(innolux->vddi);
>  
>  	innolux->prepared = false;
>  
> @@ -97,10 +117,18 @@ static int innolux_panel_prepare(struct drm_panel *panel)
>  
>  	gpiod_set_value_cansleep(innolux->enable_gpio, 0);
>  
> -	err = regulator_enable(innolux->supply);
> +	err = regulator_enable(innolux->vddi);
>  	if (err < 0)
>  		return err;
>  
> +	err = regulator_enable(innolux->avdd);
> +	if (err < 0)
> +		goto disable_vddi;
> +
> +	err = regulator_enable(innolux->avee);
> +	if (err < 0)
> +		goto disable_avdd;
> +
>  	/* T2: 15ms - 1000ms */
>  	usleep_range(15000, 16000);
>  
> @@ -134,12 +162,13 @@ static int innolux_panel_prepare(struct drm_panel *panel)
>  	return 0;
>  
>  poweroff:
> -	regulator_err = regulator_disable(innolux->supply);
> -	if (regulator_err)
> -		DRM_DEV_ERROR(panel->dev, "failed to disable regulator: %d\n",
> -			      regulator_err);
> -
>  	gpiod_set_value_cansleep(innolux->enable_gpio, 0);
> +	regulator_disable(innolux->avee);
> +disable_avdd:
> +	regulator_disable(innolux->avdd);
> +disable_vddi:
> +	regulator_disable(innolux->vddi);
> +
>  	return err;
>  }
>  
> @@ -164,7 +193,7 @@ static int innolux_panel_enable(struct drm_panel *panel)
>  	return 0;
>  }
>  
> -static const struct drm_display_mode default_mode = {
> +static const struct drm_display_mode innolux_p079zca_mode = {
>  	.clock = 56900,
>  	.hdisplay = 768,
>  	.hsync_start = 768 + 40,
> @@ -177,15 +206,59 @@ static const struct drm_display_mode default_mode = {
>  	.vrefresh = 60,
>  };
>  
> +static const struct panel_desc_dsi innolux_p079zca_panel_desc = {
> +	.desc = {
> +		.modes = &innolux_p079zca_mode,
> +		.bpc = 8,
> +		.size = {
> +			.width = 120,
> +			.height = 160,
> +		},
> +	},
> +	.flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> +		 MIPI_DSI_MODE_LPM,
> +	.format = MIPI_DSI_FMT_RGB888,
> +	.lanes = 4,
> +};
> +
> +static const struct drm_display_mode innolux_p097pfg_mode = {
> +	.clock = 220000,
> +	.hdisplay = 1536,
> +	.hsync_start = 1536 + 100,
> +	.hsync_end = 1536 + 100 + 24,
> +	.htotal = 1536 + 100 + 24 + 100,
> +	.vdisplay = 2048,
> +	.vsync_start = 2048 + 18,
> +	.vsync_end = 2048 + 18 + 2,
> +	.vtotal = 2048 + 18 + 2 + 18,
> +	.vrefresh = 60,
> +};
> +
> +static const struct panel_desc_dsi innolux_p097pfg_panel_desc = {
> +	.desc = {
> +		.modes = &innolux_p097pfg_mode,
> +		.bpc = 8,
> +		.size = {
> +			.width = 147,
> +			.height = 196,
> +		},
> +	},
> +	.flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> +		 MIPI_DSI_MODE_LPM,
> +	.format = MIPI_DSI_FMT_RGB888,
> +	.lanes = 8,
> +};
> +
>  static int innolux_panel_get_modes(struct drm_panel *panel)
>  {
>  	struct drm_display_mode *mode;
> +	struct innolux_panel *innolux = to_innolux_panel(panel);
> +	const struct drm_display_mode *m = innolux->dsi_desc->desc.modes;
>  
> -	mode = drm_mode_duplicate(panel->drm, &default_mode);
> +	mode = drm_mode_duplicate(panel->drm, m);
>  	if (!mode) {
>  		DRM_DEV_ERROR(panel->drm->dev, "failed to add mode %ux%ux@%u\n",
> -			      default_mode.hdisplay, default_mode.vdisplay,
> -			      default_mode.vrefresh);
> +			      m->hdisplay, m->vdisplay, m->vrefresh);
>  		return -ENOMEM;
>  	}
>  
> @@ -193,9 +266,11 @@ static int innolux_panel_get_modes(struct drm_panel *panel)
>  
>  	drm_mode_probed_add(panel->connector, mode);
>  
> -	panel->connector->display_info.width_mm = 120;
> -	panel->connector->display_info.height_mm = 160;
> -	panel->connector->display_info.bpc = 8;
> +	panel->connector->display_info.width_mm =
> +			innolux->dsi_desc->desc.size.width;
> +	panel->connector->display_info.height_mm =
> +			innolux->dsi_desc->desc.size.height;
> +	panel->connector->display_info.bpc = innolux->dsi_desc->desc.bpc;
>  
>  	return 1;
>  }
> @@ -209,20 +284,39 @@ static const struct drm_panel_funcs innolux_panel_funcs = {
>  };
>  
>  static const struct of_device_id innolux_of_match[] = {
> -	{ .compatible = "innolux,p079zca", },
> -	{ }
> +	{ .compatible = "innolux,p079zca",
> +	  .data = &innolux_p079zca_panel_desc
> +	},
> +	{ .compatible = "innolux,p097pfg",
> +	  .data = &innolux_p097pfg_panel_desc
> +	}
>  };
>  MODULE_DEVICE_TABLE(of, innolux_of_match);
>  
> -static int innolux_panel_add(struct innolux_panel *innolux)
> +static int innolux_panel_add(struct mipi_dsi_device *dsi,
> +			     const struct panel_desc_dsi *desc)
>  {
> -	struct device *dev = &innolux->link->dev;
> +	struct innolux_panel *innolux;
> +	struct device *dev = &dsi->dev;
>  	struct device_node *np;
>  	int err;
>  
> -	innolux->supply = devm_regulator_get(dev, "power");
> -	if (IS_ERR(innolux->supply))
> -		return PTR_ERR(innolux->supply);
> +	innolux = devm_kzalloc(dev, sizeof(*innolux), GFP_KERNEL);
> +	if (!innolux)
> +		return -ENOMEM;
> +
> +	innolux->dsi_desc = desc;
> +	innolux->vddi = devm_regulator_get_optional(dev, "power");
> +	if (IS_ERR(innolux->vddi))
> +		return PTR_ERR(innolux->vddi);
> +
> +	innolux->avdd = devm_regulator_get(dev, "ppvarp");
> +	if (IS_ERR(innolux->avdd))
> +		return PTR_ERR(innolux->avdd);
> +
> +	innolux->avee = devm_regulator_get(dev, "ppvarn");
> +	if (IS_ERR(innolux->avee))
> +		return PTR_ERR(innolux->avee);
>  
>  	innolux->enable_gpio = devm_gpiod_get_optional(dev, "enable",
>  						       GPIOD_OUT_HIGH);
> @@ -243,14 +337,16 @@ static int innolux_panel_add(struct innolux_panel *innolux)
>  
>  	drm_panel_init(&innolux->base);
>  	innolux->base.funcs = &innolux_panel_funcs;
> -	innolux->base.dev = &innolux->link->dev;
> +	innolux->base.dev = dev;
>  
>  	err = drm_panel_add(&innolux->base);
>  	if (err < 0)
>  		goto put_backlight;
>  
> -	return 0;
> +	dev_set_drvdata(dev, innolux);
> +	innolux->link = dsi;
>  
> +	return 0;
>  put_backlight:
>  	put_device(&innolux->backlight->dev);
>  
> @@ -267,28 +363,25 @@ static void innolux_panel_del(struct innolux_panel *innolux)
>  
>  static int innolux_panel_probe(struct mipi_dsi_device *dsi)
>  {
> -	struct innolux_panel *innolux;
> -	int err;
> -
> -	dsi->lanes = 4;
> -	dsi->format = MIPI_DSI_FMT_RGB888;
> -	dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> -			  MIPI_DSI_MODE_LPM;
>  
> -	innolux = devm_kzalloc(&dsi->dev, sizeof(*innolux), GFP_KERNEL);
> -	if (!innolux)
> -		return -ENOMEM;
> +	const struct panel_desc_dsi *dsi_desc;
> +	const struct of_device_id *id;
> +	int err;
>  
> -	mipi_dsi_set_drvdata(dsi, innolux);
> +	id = of_match_node(innolux_of_match, dsi->dev.of_node);
> +	if (!id)
> +		return -ENODEV;
>  
> -	innolux->link = dsi;
> +	dsi_desc = id->data;
> +	dsi->mode_flags = dsi_desc->flags;
> +	dsi->format = dsi_desc->format;
> +	dsi->lanes = dsi_desc->lanes;
>  
> -	err = innolux_panel_add(innolux);
> +	err = innolux_panel_add(dsi, dsi_desc);
>  	if (err < 0)
>  		return err;
>  
> -	err = mipi_dsi_attach(dsi);
> -	return err;
> +	return mipi_dsi_attach(dsi);
>  }
>  
>  static int innolux_panel_remove(struct mipi_dsi_device *dsi)
> @@ -326,7 +419,7 @@ static void innolux_panel_shutdown(struct mipi_dsi_device *dsi)
>  
>  static struct mipi_dsi_driver innolux_panel_driver = {
>  	.driver = {
> -		.name = "panel-innolux-p079zca",
> +		.name = "panel-innolux-dsi",
>  		.of_match_table = innolux_of_match,
>  	},
>  	.probe = innolux_panel_probe,
> @@ -336,5 +429,6 @@ static struct mipi_dsi_driver innolux_panel_driver = {
>  module_mipi_dsi_driver(innolux_panel_driver);
>  
>  MODULE_AUTHOR("Chris Zhong <zyw@rock-chips.com>");
> +MODULE_AUTHOR("Lin Huang <hl@rock-chips.com>");
>  MODULE_DESCRIPTION("Innolux P079ZCA panel driver");
>  MODULE_LICENSE("GPL v2");
> -- 
> 2.7.4
>