From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [RESENT PATCH] drm/panel: support Innolux P097PFG panel Date: Thu, 30 Nov 2017 18:54:59 -0800 Message-ID: <20171201025457.GA142685@google.com> References: <1512022480-7015-1-git-send-email-hl@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id B9F296EBBE for ; Fri, 1 Dec 2017 02:55:02 +0000 (UTC) Received: by mail-io0-x244.google.com with SMTP id w127so9755876iow.11 for ; Thu, 30 Nov 2017 18:55:02 -0800 (PST) Content-Disposition: inline In-Reply-To: <1512022480-7015-1-git-send-email-hl@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lin Huang Cc: airlied@linux.ie, Derek Basehore , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, nickey.yang@rock-chips.com, thierry.reding@gmail.com, zyw@rock-chips.com List-Id: dri-devel@lists.freedesktop.org T25lIG1vcmUgY29tbWVudDoKCk9uIFRodSwgTm92IDMwLCAyMDE3IGF0IDAyOjE0OjQwUE0gKzA4 MDAsIExpbiBIdWFuZyB3cm90ZToKPiBTdXBwb3J0IElubm9sdXggUDA5N1BGRyA5LjciIDE1MzZ4 MjA0OCBURlQgTENEIHBhbmVsLAo+IGl0IHJlZmFjdG9yIElubm9sdXggUDA3OVpDQSBwYW5lbCBk cml2ZXIsIGxldCBpdCBzdXBwb3J0Cj4gbXVsdGkgcGFuZWwsIGFuZCBhZGQgc3VwcG9ydCBQMDk3 UEZHIHBhbmVsIGluIHRoaXMgZHJpdmVyLgo+IAo+IFNpZ25lZC1vZmYtYnk6IExpbiBIdWFuZyA8 aGxAcm9jay1jaGlwcy5jb20+Cj4gCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5l bC1pbm5vbHV4LXAwNzl6Y2EuYyB8IDE3OCArKysrKysrKysrKysrKysrKysrKy0tLS0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgMTM2IGluc2VydGlvbnMoKyksIDQyIGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtaW5ub2x1eC1wMDc5emNhLmMg Yi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtaW5ub2x1eC1wMDc5emNhLmMKPiBpbmRleCA2 YmE5MzQ0Li5hNDA3OThmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5l bC1pbm5vbHV4LXAwNzl6Y2EuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1p bm5vbHV4LXAwNzl6Y2EuYwouLi4KCj4gQEAgLTIwOSwyMCArMjg0LDM5IEBAIHN0YXRpYyBjb25z dCBzdHJ1Y3QgZHJtX3BhbmVsX2Z1bmNzIGlubm9sdXhfcGFuZWxfZnVuY3MgPSB7Cj4gIH07Cj4g IAo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBpbm5vbHV4X29mX21hdGNoW10g PSB7Cj4gLQl7IC5jb21wYXRpYmxlID0gImlubm9sdXgscDA3OXpjYSIsIH0sCj4gLQl7IH0KPiAr CXsgLmNvbXBhdGlibGUgPSAiaW5ub2x1eCxwMDc5emNhIiwKPiArCSAgLmRhdGEgPSAmaW5ub2x1 eF9wMDc5emNhX3BhbmVsX2Rlc2MKPiArCX0sCj4gKwl7IC5jb21wYXRpYmxlID0gImlubm9sdXgs cDA5N3BmZyIsCj4gKwkgIC5kYXRhID0gJmlubm9sdXhfcDA5N3BmZ19wYW5lbF9kZXNjCj4gKwl9 Cj4gIH07Cj4gIE1PRFVMRV9ERVZJQ0VfVEFCTEUob2YsIGlubm9sdXhfb2ZfbWF0Y2gpOwo+ICAK PiAtc3RhdGljIGludCBpbm5vbHV4X3BhbmVsX2FkZChzdHJ1Y3QgaW5ub2x1eF9wYW5lbCAqaW5u b2x1eCkKPiArc3RhdGljIGludCBpbm5vbHV4X3BhbmVsX2FkZChzdHJ1Y3QgbWlwaV9kc2lfZGV2 aWNlICpkc2ksCj4gKwkJCSAgICAgY29uc3Qgc3RydWN0IHBhbmVsX2Rlc2NfZHNpICpkZXNjKQo+ ICB7Cj4gLQlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmaW5ub2x1eC0+bGluay0+ZGV2Owo+ICsJc3Ry dWN0IGlubm9sdXhfcGFuZWwgKmlubm9sdXg7Cj4gKwlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmZHNp LT5kZXY7Cj4gIAlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wOwo+ICAJaW50IGVycjsKPiAgCj4gLQlp bm5vbHV4LT5zdXBwbHkgPSBkZXZtX3JlZ3VsYXRvcl9nZXQoZGV2LCAicG93ZXIiKTsKPiAtCWlm IChJU19FUlIoaW5ub2x1eC0+c3VwcGx5KSkKPiAtCQlyZXR1cm4gUFRSX0VSUihpbm5vbHV4LT5z dXBwbHkpOwo+ICsJaW5ub2x1eCA9IGRldm1fa3phbGxvYyhkZXYsIHNpemVvZigqaW5ub2x1eCks IEdGUF9LRVJORUwpOwo+ICsJaWYgKCFpbm5vbHV4KQo+ICsJCXJldHVybiAtRU5PTUVNOwo+ICsK PiArCWlubm9sdXgtPmRzaV9kZXNjID0gZGVzYzsKPiArCWlubm9sdXgtPnZkZGkgPSBkZXZtX3Jl Z3VsYXRvcl9nZXRfb3B0aW9uYWwoZGV2LCAicG93ZXIiKTsKPiArCWlmIChJU19FUlIoaW5ub2x1 eC0+dmRkaSkpCj4gKwkJcmV0dXJuIFBUUl9FUlIoaW5ub2x1eC0+dmRkaSk7Cj4gKwo+ICsJaW5u b2x1eC0+YXZkZCA9IGRldm1fcmVndWxhdG9yX2dldChkZXYsICJwcHZhcnAiKTsKClRoaXMgbmFt ZSAoInBwdmFycCIgYW5kIHRoZSAicHB2YXJuIiBiZWxvdykgYXJlIG5hbWVzIGZyb20gb3VyIGJv YXJkCnNjaGVtYXRpY3MsIG5vdCBmcm9tIHRoZSBwYW5lbCBkYXRhc2hlZXQuIEkgd291bGQgdGhp bmsgdGhlc2Ugc2hvdWxkIGJlCiJ2ZGQiIGFuZCAidmVlIiwgbGlrZSB5b3VyIHZhcmlhYmxlIG5h bWVzLgoKQnJpYW4KCj4gKwlpZiAoSVNfRVJSKGlubm9sdXgtPmF2ZGQpKQo+ICsJCXJldHVybiBQ VFJfRVJSKGlubm9sdXgtPmF2ZGQpOwo+ICsKPiArCWlubm9sdXgtPmF2ZWUgPSBkZXZtX3JlZ3Vs YXRvcl9nZXQoZGV2LCAicHB2YXJuIik7Cj4gKwlpZiAoSVNfRVJSKGlubm9sdXgtPmF2ZWUpKQo+ ICsJCXJldHVybiBQVFJfRVJSKGlubm9sdXgtPmF2ZWUpOwo+ICAKPiAgCWlubm9sdXgtPmVuYWJs ZV9ncGlvID0gZGV2bV9ncGlvZF9nZXRfb3B0aW9uYWwoZGV2LCAiZW5hYmxlIiwKPiAgCQkJCQkJ ICAgICAgIEdQSU9EX09VVF9ISUdIKTsKLi4uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752386AbdLACzE (ORCPT ); Thu, 30 Nov 2017 21:55:04 -0500 Received: from mail-io0-f193.google.com ([209.85.223.193]:43169 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751793AbdLACzC (ORCPT ); Thu, 30 Nov 2017 21:55:02 -0500 X-Google-Smtp-Source: AGs4zMZd8IAsnHp/6yPL+M7iBSKTix3r1SxBiQ9m3+s/xyPHvuEMkOl9m7hrBplQE0F/ub53i/5a4A== Date: Thu, 30 Nov 2017 18:54:59 -0800 From: Brian Norris To: Lin Huang Cc: thierry.reding@gmail.com, zyw@rock-chips.com, seanpaul@chromium.org, nickey.yang@rock-chips.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Derek Basehore Subject: Re: [RESENT PATCH] drm/panel: support Innolux P097PFG panel Message-ID: <20171201025457.GA142685@google.com> References: <1512022480-7015-1-git-send-email-hl@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512022480-7015-1-git-send-email-hl@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org One more comment: On Thu, Nov 30, 2017 at 02:14:40PM +0800, Lin Huang wrote: > Support Innolux P097PFG 9.7" 1536x2048 TFT LCD panel, > it refactor Innolux P079ZCA panel driver, let it support > multi panel, and add support P097PFG panel in this driver. > > Signed-off-by: Lin Huang > > --- > drivers/gpu/drm/panel/panel-innolux-p079zca.c | 178 ++++++++++++++++++++------ > 1 file changed, 136 insertions(+), 42 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c > index 6ba9344..a40798f 100644 > --- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c > +++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c ... > @@ -209,20 +284,39 @@ static const struct drm_panel_funcs innolux_panel_funcs = { > }; > > static const struct of_device_id innolux_of_match[] = { > - { .compatible = "innolux,p079zca", }, > - { } > + { .compatible = "innolux,p079zca", > + .data = &innolux_p079zca_panel_desc > + }, > + { .compatible = "innolux,p097pfg", > + .data = &innolux_p097pfg_panel_desc > + } > }; > MODULE_DEVICE_TABLE(of, innolux_of_match); > > -static int innolux_panel_add(struct innolux_panel *innolux) > +static int innolux_panel_add(struct mipi_dsi_device *dsi, > + const struct panel_desc_dsi *desc) > { > - struct device *dev = &innolux->link->dev; > + struct innolux_panel *innolux; > + struct device *dev = &dsi->dev; > struct device_node *np; > int err; > > - innolux->supply = devm_regulator_get(dev, "power"); > - if (IS_ERR(innolux->supply)) > - return PTR_ERR(innolux->supply); > + innolux = devm_kzalloc(dev, sizeof(*innolux), GFP_KERNEL); > + if (!innolux) > + return -ENOMEM; > + > + innolux->dsi_desc = desc; > + innolux->vddi = devm_regulator_get_optional(dev, "power"); > + if (IS_ERR(innolux->vddi)) > + return PTR_ERR(innolux->vddi); > + > + innolux->avdd = devm_regulator_get(dev, "ppvarp"); This name ("ppvarp" and the "ppvarn" below) are names from our board schematics, not from the panel datasheet. I would think these should be "vdd" and "vee", like your variable names. Brian > + if (IS_ERR(innolux->avdd)) > + return PTR_ERR(innolux->avdd); > + > + innolux->avee = devm_regulator_get(dev, "ppvarn"); > + if (IS_ERR(innolux->avee)) > + return PTR_ERR(innolux->avee); > > innolux->enable_gpio = devm_gpiod_get_optional(dev, "enable", > GPIOD_OUT_HIGH); ...