From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 1/5] mtd: nand: use usual return values for the ->erase() hook Date: Fri, 1 Dec 2017 10:39:20 +0100 Message-ID: <20171201103920.1ed36f99@bbrezillon> References: <20171130170132.27522-1-miquel.raynal@free-electrons.com> <20171130170132.27522-2-miquel.raynal@free-electrons.com> <20171130215113.458d616f@bbrezillon> <20171130230246.61a9ed19@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171130230246.61a9ed19@xps13> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Miquel RAYNAL Cc: Hanna Hawa , Stefan Agner , Nadav Haklai , Masahiro Yamada , linux-mtd@lists.infradead.org, Gregory Clement , devel@driverdev.osuosl.org, Maxim Levitsky , Kamal Dasu , Richard Weinberger , Marek Vasut , Chen-Yu Tsai , bcm-kernel-feedback-list@broadcom.com, Ezequiel Garcia , Sylvain Lemieux , Marc Gonzalez , Vladimir Zapolskiy , linux-mediatek@lists.infradead.org, Matthias Brugger , Han Xu , Ofer Heifetz , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman List-Id: linux-mediatek@lists.infradead.org T24gVGh1LCAzMCBOb3YgMjAxNyAyMzowMjo0NiArMDEwMApNaXF1ZWwgUkFZTkFMIDxtaXF1ZWwu cmF5bmFsQGZyZWUtZWxlY3Ryb25zLmNvbT4gd3JvdGU6Cgo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9tdGQvbmFuZC9uYW5kX2Jhc2UuYwo+ID4gPiBiL2RyaXZlcnMvbXRkL25hbmQvbmFuZF9i YXNlLmMgaW5kZXggNjMwMDQ4ZjVhYmRjLi40ZDFmMmJkYTYwOTUKPiA+ID4gMTAwNjQ0IC0tLSBh L2RyaXZlcnMvbXRkL25hbmQvbmFuZF9iYXNlLmMKPiA+ID4gKysrIGIvZHJpdmVycy9tdGQvbmFu ZC9uYW5kX2Jhc2UuYwo+ID4gPiBAQCAtMzA3Nyw3ICszMDc3LDcgQEAgaW50IG5hbmRfZXJhc2Vf bmFuZChzdHJ1Y3QgbXRkX2luZm8gKm10ZCwKPiA+ID4gc3RydWN0IGVyYXNlX2luZm8gKmluc3Ry LCBzdGF0dXMgPSBjaGlwLT5lcmFzZShtdGQsIHBhZ2UgJgo+ID4gPiBjaGlwLT5wYWdlbWFzayk7 IAo+ID4gPiAgCQkvKiBTZWUgaWYgYmxvY2sgZXJhc2Ugc3VjY2VlZGVkICovCj4gPiA+IC0JCWlm IChzdGF0dXMgJiBOQU5EX1NUQVRVU19GQUlMKSB7Cj4gPiA+ICsJCWlmIChzdGF0dXMpIHsKPiA+ ID4gIAkJCXByX2RlYnVnKCIlczogZmFpbGVkIGVyYXNlLCBwYWdlIDB4JTA4eFxuIiwKPiA+ID4g IAkJCQkJX19mdW5jX18sIHBhZ2UpOwo+ID4gPiAgCQkJaW5zdHItPnN0YXRlID0gTVREX0VSQVNF X0ZBSUxFRDsgICAgCj4gPiAKPiA+IFlvdSBmb3Jnb3QgdG8gcGF0Y2ggc2luZ2xlX2VyYXNlKCkg YWNjb3JkaW5nbHkuICAKPiAKPiBSaWdodCwgc29ycnkgYWJvdXQgdGhhdCwgSSB3aWxsIGZpeCB0 aGF0LgoKSWYgZml4ZWQgaXQgd2hlbiBhcHBseWluZywgbm8gbmVlZCB0byByZXNlbmQuCgpUaGFu a3MsCgpCb3JpcwoKPiAKPiBUaGFua3MsCj4gTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2ZWwgbWFpbGluZyBsaXN0CmRldmVsQGxpbnV4 ZHJpdmVycHJvamVjdC5vcmcKaHR0cDovL2RyaXZlcmRldi5saW51eGRyaXZlcnByb2plY3Qub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpdmVyZGV2LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 1 Dec 2017 10:39:20 +0100 From: Boris Brezillon To: Miquel RAYNAL Cc: Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , linux-mtd@lists.infradead.org, Wenyou Yang , Nicolas Ferre , Alexandre Belloni , Kamal Dasu , Masahiro Yamada , Han Xu , Vladimir Zapolskiy , Sylvain Lemieux , Matthias Brugger , Ezequiel Garcia , Maxim Levitsky , Maxime Ripard , Chen-Yu Tsai , Marc Gonzalez , Stefan Agner , Greg Kroah-Hartman , Thomas Petazzoni , Gregory Clement , Antoine Tenart , Nadav Haklai , Ofer Heifetz , Hanna Hawa , linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-mediatek@lists.infradead.org, devel@driverdev.osuosl.org Subject: Re: [PATCH 1/5] mtd: nand: use usual return values for the ->erase() hook Message-ID: <20171201103920.1ed36f99@bbrezillon> In-Reply-To: <20171130230246.61a9ed19@xps13> References: <20171130170132.27522-1-miquel.raynal@free-electrons.com> <20171130170132.27522-2-miquel.raynal@free-electrons.com> <20171130215113.458d616f@bbrezillon> <20171130230246.61a9ed19@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 30 Nov 2017 23:02:46 +0100 Miquel RAYNAL wrote: > > > diff --git a/drivers/mtd/nand/nand_base.c > > > b/drivers/mtd/nand/nand_base.c index 630048f5abdc..4d1f2bda6095 > > > 100644 --- a/drivers/mtd/nand/nand_base.c > > > +++ b/drivers/mtd/nand/nand_base.c > > > @@ -3077,7 +3077,7 @@ int nand_erase_nand(struct mtd_info *mtd, > > > struct erase_info *instr, status =3D chip->erase(mtd, page & > > > chip->pagemask);=20 > > > /* See if block erase succeeded */ > > > - if (status & NAND_STATUS_FAIL) { > > > + if (status) { > > > pr_debug("%s: failed erase, page 0x%08x\n", > > > __func__, page); > > > instr->state =3D MTD_ERASE_FAILED; =20 > >=20 > > You forgot to patch single_erase() accordingly. =20 >=20 > Right, sorry about that, I will fix that. If fixed it when applying, no need to resend. Thanks, Boris >=20 > Thanks, > Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@free-electrons.com (Boris Brezillon) Date: Fri, 1 Dec 2017 10:39:20 +0100 Subject: [PATCH 1/5] mtd: nand: use usual return values for the ->erase() hook In-Reply-To: <20171130230246.61a9ed19@xps13> References: <20171130170132.27522-1-miquel.raynal@free-electrons.com> <20171130170132.27522-2-miquel.raynal@free-electrons.com> <20171130215113.458d616f@bbrezillon> <20171130230246.61a9ed19@xps13> Message-ID: <20171201103920.1ed36f99@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 30 Nov 2017 23:02:46 +0100 Miquel RAYNAL wrote: > > > diff --git a/drivers/mtd/nand/nand_base.c > > > b/drivers/mtd/nand/nand_base.c index 630048f5abdc..4d1f2bda6095 > > > 100644 --- a/drivers/mtd/nand/nand_base.c > > > +++ b/drivers/mtd/nand/nand_base.c > > > @@ -3077,7 +3077,7 @@ int nand_erase_nand(struct mtd_info *mtd, > > > struct erase_info *instr, status = chip->erase(mtd, page & > > > chip->pagemask); > > > /* See if block erase succeeded */ > > > - if (status & NAND_STATUS_FAIL) { > > > + if (status) { > > > pr_debug("%s: failed erase, page 0x%08x\n", > > > __func__, page); > > > instr->state = MTD_ERASE_FAILED; > > > > You forgot to patch single_erase() accordingly. > > Right, sorry about that, I will fix that. If fixed it when applying, no need to resend. Thanks, Boris > > Thanks, > Miqu?l