From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from osg.samsung.com ([64.30.133.232]:42069 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752553AbdLAN7q (ORCPT ); Fri, 1 Dec 2017 08:59:46 -0500 Date: Fri, 1 Dec 2017 11:59:33 -0200 From: Mauro Carvalho Chehab To: Sakari Ailus Cc: Linux Media Mailing List , Mauro Carvalho Chehab , lkml@vger.kernel.org, Sean Young , Philippe Ombredanne , Hans Verkuil , Colin Ian King , Andi Shyti , David =?UTF-8?B?SMOkcmRlbWFu?= , Bhumika Goyal , Markus Elfring , Arvind Yadav , Julia Lawall , Christophe JAILLET , Santosh Kumar Singh Subject: Re: [PATCH v2 4/7] media: usb: add SPDX identifiers to some code I wrote Message-ID: <20171201115933.587528d4@vento.lan> In-Reply-To: <20171201135255.vc5duelcqc7n52hm@paasikivi.fi.intel.com> References: <87092e1fd6509e7272bd7b95865cdc4b793c714e.1512135871.git.mchehab@s-opensource.com> <20171201135255.vc5duelcqc7n52hm@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Fri, 1 Dec 2017 15:52:55 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Fri, Dec 01, 2017 at 11:47:10AM -0200, Mauro Carvalho Chehab wrote: > > diff --git a/drivers/media/usb/au0828/au0828-input.c b/drivers/media/usb/au0828/au0828-input.c > > index af68afe085b5..832ed9f25784 100644 > > --- a/drivers/media/usb/au0828/au0828-input.c > > +++ b/drivers/media/usb/au0828/au0828-input.c > > @@ -1,21 +1,10 @@ > > -/* > > - handle au0828 IR remotes via linux kernel input layer. > > - > > - Copyright (C) 2014 Mauro Carvalho Chehab > > - Copyright (c) 2014 Samsung Electronics Co., Ltd. > > - > > - Based on em28xx-input.c. > > - > > - This program is free software; you can redistribute it and/or modify > > - it under the terms of the GNU General Public License as published by > > - the Free Software Foundation; either version 2 of the License, or > > - (at your option) any later version. > > - > > - This program is distributed in the hope that it will be useful, > > - but WITHOUT ANY WARRANTY; without even the implied warranty of > > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > - GNU General Public License for more details. > > - */ > > +// SPDX-License-Identifier: GPL-2.0+ > > +// handle au0828 IR remotes via linux kernel input layer. > > +// > > +// Copyright (c) 2014 Mauro Carvalho Chehab > > +// Copyright (c) 2014 Samsung Electronics Co., Ltd. > > +// > > +// Based on em28xx-input.c. > > Is the intention really to use C++ comments? Yes. > I see that the SPDX license identifiers elsewhere use C comments. Linus defined this way: https://www.spinics.net/lists/linux-xfs/msg13289.html Regards, Mauro