From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752688AbdLAMIf (ORCPT ); Fri, 1 Dec 2017 07:08:35 -0500 Received: from mga02.intel.com ([134.134.136.20]:57555 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752403AbdLAMIe (ORCPT ); Fri, 1 Dec 2017 07:08:34 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,344,1508828400"; d="scan'208";a="7984100" From: Mika Westerberg To: Greg Kroah-Hartman Cc: Mika Westerberg , linux-kernel@vger.kernel.org Subject: [PATCH 3/3] thunderbolt: Mask ring interrupt properly when polling starts Date: Fri, 1 Dec 2017 15:08:05 +0300 Message-Id: <20171201120805.60852-4-mika.westerberg@linux.intel.com> X-Mailer: git-send-email 2.15.0 In-Reply-To: <20171201120805.60852-1-mika.westerberg@linux.intel.com> References: <20171201120805.60852-1-mika.westerberg@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When ring enters polling mode we are expected to mask the ring interrupt before the callback is called. However, the current code actually unmasks it probably because of a copy-paste mistake. Mask the interrupt properly from now on. Fixes: 4ffe722eefcb ("thunderbolt: Add polling mode for rings") Signed-off-by: Mika Westerberg Acked-by: Yehezkel Bernat --- drivers/thunderbolt/nhi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c index 419a7a90bce0..f45bcbc63738 100644 --- a/drivers/thunderbolt/nhi.c +++ b/drivers/thunderbolt/nhi.c @@ -339,7 +339,7 @@ static void __ring_interrupt(struct tb_ring *ring) return; if (ring->start_poll) { - __ring_interrupt_mask(ring, false); + __ring_interrupt_mask(ring, true); ring->start_poll(ring->poll_data); } else { schedule_work(&ring->work); -- 2.15.0