All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Arturo Borrero Gonzalez <arturo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>,
	Netfilter Development Mailing list
	<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nf-next] netfilter: meta: secpath support
Date: Fri, 1 Dec 2017 14:07:47 +0100	[thread overview]
Message-ID: <20171201130747.GD27820@breakpoint.cc> (raw)
In-Reply-To: <CAOkSjBjtc2EUCK5e-50uy6dvwPjhFdc91PyAe1_=cvDMRwMj9A@mail.gmail.com>

Arturo Borrero Gonzalez <arturo@netfilter.org> wrote:
> > +       if (priv->key != NFT_META_SECPATH)
> > +               return 0;
> > +
> 
> Would it worth adding here something like this?
> 
> #ifnfdef CONFIG_XFRM
>             return -EOPNOTSUPP;
> #endif
> 
> I mean, if CONFIG_XFRM is not defined, then _get_eval() is doing nothing, right?

Right, I'll add it.

  reply	other threads:[~2017-12-01 13:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 12:40 [PATCH next] nftables: add inbound ipsec matching Florian Westphal
2017-12-01 12:40 ` [PATCH nf-next] netfilter: meta: secpath support Florian Westphal
2017-12-01 12:40   ` Florian Westphal
2017-12-01 12:53   ` Arturo Borrero Gonzalez
2017-12-01 13:07     ` Florian Westphal [this message]
2017-12-13  7:16   ` kbuild test robot
2017-12-13  7:16   ` [RFC PATCH] netfilter: meta: nft_meta_get_validate() can be static kbuild test robot
2017-12-13 16:42     ` Pablo Neira Ayuso
2017-12-01 12:40 ` [PATCH libnftnl] meta: secpath support Florian Westphal
2017-12-01 12:40 ` [PATCH nft] meta: add " Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171201130747.GD27820@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=arturo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.