Re: [PATCH] perf test shell: Fix check open filename arg using 'perf trace'

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Fri, Dec 01, 2017 at 11:33:14AM +0900, Namhyung Kim escreveu:
> On Thu, Nov 30, 2017 at 01:56:42PM -0200, Arnaldo de Melo wrote:
> > Em Thu, Nov 30, 2017 at 11:28:33AM +0100, Thomas-Mich Richter escreveu:
> > > On 11/29/2017 06:27 PM, Michael Petlan wrote:
> > > > The commit f231af789b11a2f1a3795acc3228a3e178a80c21 adds an exception for s390x to
> > > > use openat() syscall instead of open(). This exception is not s390x-only, thus I
> > > > adjusted the test to accept both open and openat syscalls, no matter which arch it
> > > > runs on. Does it sound reasonable to you?
 
> It seems glibc 2.26 changed the behavior:
 
>   https://lwn.net/Articles/738694/

interesting
 
> > What differs from x86 to others is that x86 uses syscalltbl, not requiring
> > audit-libs to map syscall numbers to names, so perhaps it is something in there...
 
> If it only needs to consider open or openat, why not specifying the
> both directly?
 
>   # perf trace -e open -e openat touch /etc/passwd

Same effect, works with other perf trace versions, but one suggestion to
make it shorter:

	perf trace -e open,openat touch /etc/passwd

Does the same thing :-)

Michael, can you please take that into account and resubmit the patch?

- Arnaldo