From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH v4 2/3] dt-bindings: display: rockchip: update DSI controller Date: Fri, 1 Dec 2017 10:21:19 -0800 Message-ID: <20171201182118.GA66630@google.com> References: <1512100685-4015-1-git-send-email-nickey.yang@rock-chips.com> <1512100685-4015-3-git-send-email-nickey.yang@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1512100685-4015-3-git-send-email-nickey.yang@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nickey Yang Cc: mark.rutland@arm.com, airlied@linux.ie, hoegsberg@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, philippe.cornu@st.com, yannick.fertre@st.com, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, laurent.pinchart@ideasonboard.com, zyw@rock-chips.com, xbl@rock-chips.com, mka@chromium.org, hl@rock-chips.com List-Id: linux-rockchip.vger.kernel.org T24gRnJpLCBEZWMgMDEsIDIwMTcgYXQgMTE6NTg6MDRBTSArMDgwMCwgTmlja2V5IFlhbmcgd3Jv dGU6Cj4gVGhpcyBwYXRjaCB1cGRhdGUgZGVzY3JpYmUgcGFuZWwvcG9ydCBsaW5rcywgaW5jbHVk aW5nCj4gdW5pdCBhZGRyZXNzZXMgaW4gZG9jdW1lbnRhdGlvbiBvZiBkZXZpY2UgdHJlZSBiaW5k aW5ncwo+IGZvciB0aGUgcm9ja2NoaXAgRFNJIGNvbnRyb2xsZXIgYmFzZWQgb24gdGhlIFN5bm9w c3lzCj4gRGVzaWduV2FyZSBNSVBJIERTSSBob3N0IGNvbnRyb2xsZXIuCj4gCj4gU2lnbmVkLW9m Zi1ieTogTmlja2V5IFlhbmcgPG5pY2tleS55YW5nQHJvY2stY2hpcHMuY29tPgoKU2VlbXMgT0sg dG8gbWU6CgpSZXZpZXdlZC1ieTogQnJpYW4gTm9ycmlzIDxicmlhbm5vcnJpc0BjaHJvbWl1bS5v cmc+Cgo+IAo+IC0tLQo+IENoYW5nZXMgaW4gdjQ6Cj4gLSBrZWVwIHRoZSAtY2VsbHMgcHJvcGVy dGllcwo+IAo+ICAuLi4vZGlzcGxheS9yb2NrY2hpcC9kd19taXBpX2RzaV9yb2NrY2hpcC50eHQg ICAgICB8IDIzICsrKysrKysrKysrKysrKysrKysrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIxIGlu c2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3JvY2tjaGlwL2R3X21pcGlfZHNpX3JvY2tj aGlwLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3JvY2tj aGlwL2R3X21pcGlfZHNpX3JvY2tjaGlwLnR4dAo+IGluZGV4IDZiYjU5YWIuLmNlNGMxZmMgMTAw NjQ0Cj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcm9j a2NoaXAvZHdfbWlwaV9kc2lfcm9ja2NoaXAudHh0Cj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcm9ja2NoaXAvZHdfbWlwaV9kc2lfcm9ja2NoaXAudHh0 Cj4gQEAgLTE0LDYgKzE0LDggQEAgUmVxdWlyZWQgcHJvcGVydGllczoKPiAgLSByb2NrY2hpcCxn cmY6IHRoaXMgc29jIHNob3VsZCBzZXQgR1JGIHJlZ3MgdG8gbXV4IHZvcGwvdm9wYi4KPiAgLSBw b3J0czogY29udGFpbiBhIHBvcnQgbm9kZSB3aXRoIGVuZHBvaW50IGRlZmluaXRpb25zIGFzIGRl ZmluZWQgaW4gWzJdLgo+ICAgIEZvciB2b3BiLHNldCB0aGUgcmVnID0gPDA+IGFuZCBzZXQgdGhl IHJlZyA9IDwxPiBmb3Igdm9wbC4KPiArLSB2aWRlbyBwb3J0IDAgZm9yIHRoZSBWT1AgaW5wdXQs IHRoZSByZW1vdGUgZW5kcG9pbnQgbWF5YmUgdm9wYiBvciB2b3BsCj4gKy0gdmlkZW8gcG9ydCAx IGZvciBlaXRoZXIgYSBwYW5lbCBvciBzdWJzZXF1ZW50IGVuY29kZXIKPiAgCj4gIE9wdGlvbmFs IHByb3BlcnRpZXM6Cj4gIC0gcG93ZXItZG9tYWluczogYSBwaGFuZGxlIHRvIG1pcGkgZHNpIHBv d2VyIGRvbWFpbiBub2RlLgo+IEBAIC00MCwxMSArNDIsMTIgQEAgRXhhbXBsZToKPiAgCQlwb3J0 cyB7Cj4gIAkJCSNhZGRyZXNzLWNlbGxzID0gPDE+Owo+ICAJCQkjc2l6ZS1jZWxscyA9IDwwPjsK PiAtCQkJcmVnID0gPDE+Owo+ICAKPiAtCQkJbWlwaV9pbjogcG9ydCB7Cj4gKwkJCW1pcGlfaW46 IHBvcnRAMCB7Cj4gKwkJCQlyZWcgPSA8MD47Cj4gIAkJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsK PiAgCQkJCSNzaXplLWNlbGxzID0gPDA+Owo+ICsKPiAgCQkJCW1pcGlfaW5fdm9wYjogZW5kcG9p bnRAMCB7Cj4gIAkJCQkJcmVnID0gPDA+Owo+ICAJCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwmdm9w Yl9vdXRfbWlwaT47Cj4gQEAgLTU0LDYgKzU3LDE2IEBAIEV4YW1wbGU6Cj4gIAkJCQkJcmVtb3Rl LWVuZHBvaW50ID0gPCZ2b3BsX291dF9taXBpPjsKPiAgCQkJCX07Cj4gIAkJCX07Cj4gKwo+ICsJ CQltaXBpX291dDogcG9ydEAxIHsKPiArCQkJCXJlZyA9IDwxPjsKPiArCQkJCSNhZGRyZXNzLWNl bGxzID0gPDE+Owo+ICsJCQkJI3NpemUtY2VsbHMgPSA8MD47Cj4gKwo+ICsJCQkJbWlwaV9vdXRf cGFuZWw6IGVuZHBvaW50IHsKPiArCQkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8JnBhbmVsX2luX21p cGk+Owo+ICsJCQkJfTsKPiArCQkJfTsKPiAgCQl9Owo+ICAKPiAgCQlwYW5lbCB7Cj4gQEAgLTY0 LDUgKzc3LDExIEBAIEV4YW1wbGU6Cj4gIAkJCXBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7Cj4g IAkJCXBpbmN0cmwtMCA9IDwmbGNkX2VuPjsKPiAgCQkJYmFja2xpZ2h0ID0gPCZiYWNrbGlnaHQ+ Owo+ICsKPiArCQkJcG9ydCB7Cj4gKwkJCQlwYW5lbF9pbl9taXBpOiBlbmRwb2ludCB7Cj4gKwkJ CQkJcmVtb3RlLWVuZHBvaW50ID0gPCZtaXBpX291dF9wYW5lbD47Cj4gKwkJCQl9Owo+ICsJCQl9 Owo+ICAJCX07Cj4gIAl9Owo+IC0tIAo+IDEuOS4xCj4gCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751845AbdLASV0 (ORCPT ); Fri, 1 Dec 2017 13:21:26 -0500 Received: from mail-it0-f66.google.com ([209.85.214.66]:40134 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872AbdLASVY (ORCPT ); Fri, 1 Dec 2017 13:21:24 -0500 X-Google-Smtp-Source: AGs4zMY4fA08ypEzsocpqwp4yuwZvtkCq/rCsVSZYR6dM2AlmIx4J6mN+muHN6BUTO3yvehO8rEoUA== Date: Fri, 1 Dec 2017 10:21:19 -0800 From: Brian Norris To: Nickey Yang Cc: robh+dt@kernel.org, heiko@sntech.de, mark.rutland@arm.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, laurent.pinchart@ideasonboard.com, seanpaul@chromium.org, mka@chromium.org, hoegsberg@gmail.com, architt@codeaurora.org, philippe.cornu@st.com, yannick.fertre@st.com, hl@rock-chips.com, zyw@rock-chips.com, xbl@rock-chips.com Subject: Re: [PATCH v4 2/3] dt-bindings: display: rockchip: update DSI controller Message-ID: <20171201182118.GA66630@google.com> References: <1512100685-4015-1-git-send-email-nickey.yang@rock-chips.com> <1512100685-4015-3-git-send-email-nickey.yang@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512100685-4015-3-git-send-email-nickey.yang@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 01, 2017 at 11:58:04AM +0800, Nickey Yang wrote: > This patch update describe panel/port links, including > unit addresses in documentation of device tree bindings > for the rockchip DSI controller based on the Synopsys > DesignWare MIPI DSI host controller. > > Signed-off-by: Nickey Yang Seems OK to me: Reviewed-by: Brian Norris > > --- > Changes in v4: > - keep the -cells properties > > .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 ++++++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > index 6bb59ab..ce4c1fc 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > +++ b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > @@ -14,6 +14,8 @@ Required properties: > - rockchip,grf: this soc should set GRF regs to mux vopl/vopb. > - ports: contain a port node with endpoint definitions as defined in [2]. > For vopb,set the reg = <0> and set the reg = <1> for vopl. > +- video port 0 for the VOP input, the remote endpoint maybe vopb or vopl > +- video port 1 for either a panel or subsequent encoder > > Optional properties: > - power-domains: a phandle to mipi dsi power domain node. > @@ -40,11 +42,12 @@ Example: > ports { > #address-cells = <1>; > #size-cells = <0>; > - reg = <1>; > > - mipi_in: port { > + mipi_in: port@0 { > + reg = <0>; > #address-cells = <1>; > #size-cells = <0>; > + > mipi_in_vopb: endpoint@0 { > reg = <0>; > remote-endpoint = <&vopb_out_mipi>; > @@ -54,6 +57,16 @@ Example: > remote-endpoint = <&vopl_out_mipi>; > }; > }; > + > + mipi_out: port@1 { > + reg = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + mipi_out_panel: endpoint { > + remote-endpoint = <&panel_in_mipi>; > + }; > + }; > }; > > panel { > @@ -64,5 +77,11 @@ Example: > pinctrl-names = "default"; > pinctrl-0 = <&lcd_en>; > backlight = <&backlight>; > + > + port { > + panel_in_mipi: endpoint { > + remote-endpoint = <&mipi_out_panel>; > + }; > + }; > }; > }; > -- > 1.9.1 >