From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Fri, 1 Dec 2017 20:12:50 +0100 Subject: [PATCH 1/1] phy: Add 2.5G SGMII interface mode In-Reply-To: References: <1512016235-15909-1-git-send-email-Bhaskar.Upadhaya@nxp.com> <20171130155050.GD7483@lunn.ch> <20171130174127.GA28828@lunn.ch> <20171130181520.GF10595@n2100.armlinux.org.uk> <20171130182621.GC28828@lunn.ch> <20171130185300.GG10595@n2100.armlinux.org.uk> Message-ID: <20171201191250.GG22599@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > So do we need to introduce a new interface type > PHY_INTERFACE_MODE_2500SGMII or is there a way to deal with 2.5G > SGMII ? And just adding to what Florian said, you don't just add a new define like this, you also need to add a user of it. Posting your MAC and PHY driver making use of this symbol will make it a lot clearer why it is needed and how it should be used. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 1/1] phy: Add 2.5G SGMII interface mode Date: Fri, 1 Dec 2017 20:12:50 +0100 Message-ID: <20171201191250.GG22599@lunn.ch> References: <1512016235-15909-1-git-send-email-Bhaskar.Upadhaya@nxp.com> <20171130155050.GD7483@lunn.ch> <20171130174127.GA28828@lunn.ch> <20171130181520.GF10595@n2100.armlinux.org.uk> <20171130182621.GC28828@lunn.ch> <20171130185300.GG10595@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Russell King - ARM Linux , "netdev@vger.kernel.org" , "davem@davemloft.net" , "linux-arm-kernel@lists.infradead.org" To: Bhaskar Upadhaya Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:43608 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750984AbdLATM4 (ORCPT ); Fri, 1 Dec 2017 14:12:56 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: > So do we need to introduce a new interface type > PHY_INTERFACE_MODE_2500SGMII or is there a way to deal with 2.5G > SGMII ? And just adding to what Florian said, you don't just add a new define like this, you also need to add a user of it. Posting your MAC and PHY driver making use of this symbol will make it a lot clearer why it is needed and how it should be used. Andrew