From: Christoph Hellwig <hch@lst.de>
To: Jason Baron <jbaron@akamai.com>
Cc: Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: waitqueue lockdep annotation
Date: Fri, 1 Dec 2017 23:02:39 +0100 [thread overview]
Message-ID: <20171201220239.GA32542@lst.de> (raw)
In-Reply-To: <57869c0c-764c-ff99-93cd-8020f8ceea9e@akamai.com>
On Fri, Dec 01, 2017 at 02:00:33PM -0500, Jason Baron wrote:
> You could leave the annotation and do something like:
> s/ep->lock/ep->wq->lock. And then that would remove the ep->lock saving
> a bit of space.
Looks like this isn't going to work due to ep_poll_safewake taking
another waitqueue lock. If we had a strict lock order it might work,
but the mess in ep_call_nested makes me fear it doesn't.
next prev parent reply other threads:[~2017-12-01 22:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 14:20 waitqueue lockdep annotation Christoph Hellwig
2017-11-30 14:20 ` [PATCH 1/2] sched/wait: assert the wait_queue_head lock is held in __wake_up_common Christoph Hellwig
2017-11-30 14:20 ` [PATCH 2/2] epoll: use proper wake_up variant in ep_poll_callback Christoph Hellwig
2017-11-30 20:50 ` waitqueue lockdep annotation Andrew Morton
2017-11-30 21:38 ` Jason Baron
2017-11-30 22:11 ` Christoph Hellwig
2017-11-30 22:18 ` Jason Baron
2017-12-01 17:11 ` Christoph Hellwig
2017-12-01 19:00 ` Jason Baron
2017-12-01 22:02 ` Christoph Hellwig [this message]
2017-12-01 22:34 ` Jason Baron
2017-12-01 23:03 ` Christoph Hellwig
2017-12-05 15:24 ` Jason Baron
2017-12-05 15:36 ` Davidlohr Bueso
2017-12-06 23:51 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2017-12-06 23:52 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201220239.GA32542@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=jbaron@akamai.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.