Re: [Patch net-next] act_mirred: use tcfm_dev in tcf_mirred_get_dev()

[Jiri Pirko <jiri@resnulli.us>]

Fri, Dec 01, 2017 at 10:46:42PM CET, xiyou.wangcong@gmail.com wrote:
>On Fri, Dec 1, 2017 at 9:56 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>>
>> Isn't this here so user may specify a ifindex of netdev which is not yet
>> present on the system (not sure how much sense that would make though...)
>
>How is this even possible? If an ifindex is not present, we return ENODEV:

Right, I missed this. Thanks.

>
>        if (parm->ifindex) {
>                dev = __dev_get_by_index(net, parm->ifindex);
>                if (dev == NULL) {
>                        if (exists)
>                                tcf_idr_release(*a, bind);
>                        return -ENODEV;
>                }