From: Leon Romanovsky <leon@kernel.org>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org, Riad Abo Raed <riada@mellanox.com>,
Guy Ergas <guye@mellanox.com>
Subject: Re: [PATCH iproute2] iproute2: Fix undeclared __kernel_long_t type build error in RHEL 6.8
Date: Sat, 2 Dec 2017 10:22:58 +0200 [thread overview]
Message-ID: <20171202082258.GE8126@mtr-leonro.local> (raw)
In-Reply-To: <20171201195624.udh62qoeezydnlah@unicorn.suse.cz>
[-- Attachment #1: Type: text/plain, Size: 1874 bytes --]
On Fri, Dec 01, 2017 at 08:56:24PM +0100, Michal Kubecek wrote:
> On Fri, Dec 01, 2017 at 08:48:07AM -0800, Stephen Hemminger wrote:
> > On Fri, 1 Dec 2017 13:04:51 +0200
> > Leon Romanovsky <leon@kernel.org> wrote:
> >
> > > From: Leon Romanovsky <leonro@mellanox.com>
> > >
> > > Add asm/posix_types.h header file to the list of needed includes,
> > > because the headers files in RHEL 6.8 are too old and doesn't
> > > have declaration of __kernel_long_t.
> > >
> > > In file included from ../include/uapi/linux/kernel.h:5,
> > > from ../include/uapi/linux/netfilter/x_tables.h:4,
> > > from ../include/xtables.h:20,
> > > from em_ipset.c:26:
> > > ../include/uapi/linux/sysinfo.h:9: error: expected specifier-qualifier-list before ‘__kernel_long_t’
> > >
> > > Cc: Riad Abo Raed <riada@mellanox.com>
> > > Cc: Guy Ergas <guye@mellanox.com>
> > > Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> >
> > I see the problem, but the solution of dragging in posix_types.h
> > would be too much of a long term maintenance issue.
> > All the headers in uapi are regularly generated from upstream
> > kernel headers; I don't want to start making exceptions.
> >
> > Is it just the xtables stuff (which has always been problematic)?
>
> Actually, the only place where __kernel_long_t and __kernel_ulong_t
> appear is struct sysinfo in include/uapi/linux/sysinfo.h and this
> structure isn't even used anywhere in iproute2 source (not even in the
> include/uapi/linux/kernel.h file which includes <linux/sysinfo.h>).
>
> So one could work around the problem by defining _LINUX_SYSINFO_H but
> that seems a bit dirty hack.
It is too dirty :). It can cause to completely unpredictable compilation
failures in the future, which won't be easy to track down.
>
> Michal Kubecek
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-12-02 8:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 11:04 [PATCH iproute2] iproute2: Fix undeclared __kernel_long_t type build error in RHEL 6.8 Leon Romanovsky
2017-12-01 16:48 ` Stephen Hemminger
2017-12-01 19:56 ` Michal Kubecek
2017-12-02 8:22 ` Leon Romanovsky [this message]
2017-12-02 8:28 ` Leon Romanovsky
2017-12-06 0:59 ` Stephen Hemminger
2017-12-06 1:33 ` Stephen Hemminger
2017-12-06 5:01 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171202082258.GE8126@mtr-leonro.local \
--to=leon@kernel.org \
--cc=guye@mellanox.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=riada@mellanox.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.