From: Steven Rostedt <rostedt@goodmis.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Daniel Wagner <wagi@monom.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] sched/rt: Do not do push/pull when there is only one CPU
Date: Sat, 2 Dec 2017 12:12:52 -0500 [thread overview]
Message-ID: <20171202121252.0bada310@vmware.local.home> (raw)
In-Reply-To: <20171202125330.xrxspjeedbpr4hk5@linutronix.de>
On Sat, 2 Dec 2017 13:53:31 +0100
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> what about a check next to sched_feat(RT_PUSH_IPI)? I don't know if this
> is a hot path or not (due to bitmap_weight). If it is, then I would
> suggest something like a jump-label which is enabled if more than one
> CPU has been enabled on boot.
Yeah I didn't like that because of the overhead. But I was being
optimistic that the cpu weight function would be a nit to the actual
pull logic. But I have a better plan.
I would like to disable RT_PUSH_IPI, but that's a sched feature and
that is a constant if we build without sched debugging.
v2 coming up.
-- Steve
next prev parent reply other threads:[~2017-12-02 17:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 18:32 [PATCH] sched/rt: Do not do push/pull when there is only one CPU Steven Rostedt
2017-12-02 12:53 ` Sebastian Andrzej Siewior
2017-12-02 13:55 ` Peter Zijlstra
2017-12-02 17:12 ` Steven Rostedt [this message]
2017-12-02 18:05 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171202121252.0bada310@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.