All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Marcus Wolf <linux@wolf-entwicklungen.de>
Cc: dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: Removed some obsolete or duplicated defines; moved two defines to better locations
Date: Sat, 2 Dec 2017 15:55:49 +0000	[thread overview]
Message-ID: <20171202155549.GA5960@kroah.com> (raw)
In-Reply-To: <1512227648-16008-1-git-send-email-linux@wolf-entwicklungen.de>

On Sat, Dec 02, 2017 at 05:14:08PM +0200, Marcus Wolf wrote:
> The define FIFO_SIZE was moved to rf69_registers.h. Although it is not a register,
> it is a value, that is given by hardware (like the registers).
> 
> The define FIFO_THRESHOLD was moved to pi433_if.c, since it is a value, that is
> freely choosen by the interface implementation. The better the response time of
> the driver, the lower threshold can be set.

Shouldn't this be two separate patches?

Remember, each patch just does one thing.

thanks,

greg k-h

  reply	other threads:[~2017-12-02 15:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-02 15:14 [PATCH] staging: pi433: Removed some obsolete or duplicated defines; moved two defines to better locations Marcus Wolf
2017-12-02 15:55 ` Greg KH [this message]
2017-12-02 16:00   ` Marcus Wolf
2017-12-02 16:09     ` Greg KH
2017-12-02 16:35       ` Marcus Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171202155549.GA5960@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@wolf-entwicklungen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.