From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLMVG-0002ZC-MU for qemu-devel@nongnu.org; Sun, 03 Dec 2017 00:07:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLMVD-00076j-H5 for qemu-devel@nongnu.org; Sun, 03 Dec 2017 00:07:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41620) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eLMVD-000768-A3 for qemu-devel@nongnu.org; Sun, 03 Dec 2017 00:07:43 -0500 Date: Sun, 3 Dec 2017 07:07:36 +0200 From: "Michael S. Tsirkin" Message-ID: <20171203070618-mutt-send-email-mst@kernel.org> References: <20171129084628.12336-1-david@gibson.dropbear.id.au> <20171129084628.12336-4-david@gibson.dropbear.id.au> <20171130040248.GU3023@umbus.fritz.box> <20171201182840-mutt-send-email-mst@kernel.org> <20171202005920.GB2130@umbus.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171202005920.GB2130@umbus.fritz.box> Subject: Re: [Qemu-devel] [for-2.12 3/7] pci: Fold pci_bus.h into pci.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: Marcel Apfelbaum , Eduardo Habkost , Igor Mammedov , qemu-devel@nongnu.org On Sat, Dec 02, 2017 at 11:59:20AM +1100, David Gibson wrote: > On Fri, Dec 01, 2017 at 06:29:39PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 30, 2017 at 03:02:48PM +1100, David Gibson wrote: > > > On Wed, Nov 29, 2017 at 12:38:00PM +0200, Marcel Apfelbaum wrote: > > > > On 29/11/2017 10:46, David Gibson wrote: > > > > > include/hw/pci/pci_bus.h is now very small and can only safely be included > > > > > after hw/pci/pci.h. So, just fold it into pci.h. > > > > > > > > > > > > > I don't get the benefit from merging the header files. > > > > I would go the other way around and find stuff specific > > > > to pci_bus and add it there, like the pci_bus_new* > > > > you touched in the prev patch. > > > > > > Hrm. Except the point of the earlier patch was that those are > > > actually spoecific to root buses, so would really belong in say > > > pci-host.h, rather than pci-bus.h. > > > > > > A log of PCI stuff deals with interaction between the device and bus > > > though, so it just seemed like more trouble than it was worth to go > > > disentangling them properly. > > > > > > > Maybe if *all* code files requiring pci.h would automatically > > > > need pci_bus.h would make sense, but I didn't check that. > > > > > > Yeah, I don't think every user of pci.h needs pci_bus.h, although a > > > fair few do as you can see from the diff. Well, I guess it's up to > > > Michael. I'll be tolerably content either way - I'd say this is the > > > least important patch of the series. > > > > I'm inclined to agree with Marcel also because it's lots of noise for no > > real win. The next patch depends on this one. I skipped this and next > > one, pls feel free to repost next one. > > Ok, will do. Is the tree you've merged the others to public > somewhere, so I can rebase on it? git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git branch is named pci pls note this is a rebased branch, commit IDs won't be stable. > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson