From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH V6 1/3] eal/arm64: remove the braces {} for dmb() and dsb() Date: Sun, 3 Dec 2017 16:41:16 +0530 Message-ID: <20171203111115.GA602@jerin> References: <1510291392-33251-1-git-send-email-hejianet@gmail.com> <1511748024-7245-1-git-send-email-hejianet@gmail.com> <1511748024-7245-2-git-send-email-hejianet@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com, olivier.matz@6wind.com, jianbo.liu@arm.com, hemant.agrawal@nxp.com, stable@dpdk.org, Jia He To: Jia He Return-path: Content-Disposition: inline In-Reply-To: <1511748024-7245-2-git-send-email-hejianet@gmail.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Sun, 26 Nov 2017 18:00:22 -0800 > From: Jia He > To: jerin.jacob@caviumnetworks.com, dev@dpdk.org, > bruce.richardson@intel.com, konstantin.ananyev@intel.com > Cc: olivier.matz@6wind.com, jianbo.liu@arm.com, hemant.agrawal@nxp.com, Jia > He , stable@dpdk.org, Jia He > Subject: [PATCH V6 1/3] eal/arm64: remove the braces {} for dmb() and dsb() > X-Mailer: git-send-email 2.7.4 > > for the code as follows: > if (condition) > rte_smp_rmb(); > else > rte_smp_wmb(); > Without this patch, compiler will report this error: > error: 'else' without a previous 'if' > > Fixes: 84733fd0d75e ("eal/arm: fix memory barrier definition") > Cc: stable@dpdk.org > Signed-off-by: Jia He Please fix the below checkpatch errors. Wrong tag: Suggested-by: Ananyev, Konstantin Wrong 'Fixes' reference: Fixes: 84733fd0d75e ("eal/arm: fix memory barrier definition") With above fix: Acked-by: Jerin Jacob