From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH V6 2/3] ring: introduce new header file to
 include common functions
Date: Sun, 3 Dec 2017 17:43:21 +0530
Message-ID: <20171203121320.GA12755@jerin>
References: <1510291392-33251-1-git-send-email-hejianet@gmail.com>
 <1511748024-7245-1-git-send-email-hejianet@gmail.com>
 <1511748024-7245-3-git-send-email-hejianet@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com,
 olivier.matz@6wind.com, jianbo.liu@arm.com, hemant.agrawal@nxp.com,
 Jia He <jia.he@hxt-semitech.com>
To: Jia He <hejianet@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam03on0080.outbound.protection.outlook.com [104.47.41.80])
 by dpdk.org (Postfix) with ESMTP id 9FFDC1D90
 for <dev@dpdk.org>; Sun,  3 Dec 2017 13:13:44 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1511748024-7245-3-git-send-email-hejianet@gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Sun, 26 Nov 2017 18:00:23 -0800
> From: Jia He <hejianet@gmail.com>
> To: jerin.jacob@caviumnetworks.com, dev@dpdk.org,
>  bruce.richardson@intel.com, konstantin.ananyev@intel.com
> Cc: olivier.matz@6wind.com, jianbo.liu@arm.com, hemant.agrawal@nxp.com, Jia
>  He <hejianet@gmail.com>, Jia He <jia.he@hxt-semitech.com>
> Subject: [PATCH V6 2/3] ring: introduce new header file to include common
>  functions
> X-Mailer: git-send-email 2.7.4
> 
> move the common part of rte_ring.h into rte_ring_generic.h.
> move the memory barrier part into update_tail().
> 
> no functional changes here.
> 
> Signed-off-by: Jia He <jia.he@hxt-semitech.com>
> Suggested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Suggested-by: Ananyev, Konstantin <konstantin.ananyev@intel.com>

Wrong tag: complaint from checkpatch.
	Suggested-by: Ananyev, Konstantin <konstantin.ananyev@intel.com>

> ---
> + */
> +
> +#ifndef _RTE_RING_GENERIC_H_
> +#define _RTE_RING_GENERIC_H_
> +
> +static __rte_always_inline void
> +update_tail(struct rte_ring_headtail *ht, uint32_t old_val, uint32_t new_val,
> +		uint32_t single, uint32_t enqueue)
> +{

How about making enqueue as const. ie. const uint32_t enqueue ?

> +	if (enqueue)
> +		rte_smp_wmb();
> +	else
> +		rte_smp_rmb();

Other than that, it looks good to me.

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>