From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2 3/7] xfs: fix up agi unlinked list reservations
Date: Mon, 4 Dec 2017 08:45:22 +1100 [thread overview]
Message-ID: <20171203214522.GS5858@dastard> (raw)
In-Reply-To: <20171130185836.18481-4-bfoster@redhat.com>
On Thu, Nov 30, 2017 at 01:58:32PM -0500, Brian Foster wrote:
> The current AGI unlinked list addition and removal reservations do
> not reflect the worst case log usage. An unlinked list removal can
> log up to two on-disk inode clusters but only includes reservation
> for one. An unlinked list addition logs the on-disk cluster but
> includes reservation for an in-core inode.
>
> Update the AGI unlinked list reservation helpers to calculate the
> correct worst case reservation for the associated operations.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
looks sane.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2017-12-03 21:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 18:58 [PATCH v2 0/7] xfs: inode transaction reservation fixups Brian Foster
2017-11-30 18:58 ` [PATCH v2 1/7] xfs: print transaction log reservation on overrun Brian Foster
2017-12-07 21:34 ` Darrick J. Wong
2017-11-30 18:58 ` [PATCH v2 2/7] xfs: include inobt buffers in ifree tx log reservation Brian Foster
2017-12-03 21:44 ` Dave Chinner
2017-12-07 21:40 ` Darrick J. Wong
2017-11-30 18:58 ` [PATCH v2 3/7] xfs: fix up agi unlinked list reservations Brian Foster
2017-12-03 21:45 ` Dave Chinner [this message]
2017-12-07 21:41 ` Darrick J. Wong
2017-11-30 18:58 ` [PATCH v2 4/7] xfs: truncate transaction does not modify the inobt Brian Foster
2017-12-03 21:46 ` Dave Chinner
2017-12-07 21:44 ` Darrick J. Wong
2017-11-30 18:58 ` [PATCH v2 5/7] xfs: include an allocfree res for inobt modifications Brian Foster
2017-12-07 21:47 ` Darrick J. Wong
2017-11-30 18:58 ` [PATCH v2 6/7] xfs: refactor inode chunk alloc/free tx reservation Brian Foster
2017-12-03 21:52 ` Dave Chinner
2017-12-04 12:17 ` Brian Foster
2017-12-04 12:21 ` [PATCH v3 " Brian Foster
2017-12-07 21:53 ` Darrick J. Wong
2017-11-30 18:58 ` [PATCH v2 7/7] xfs: eliminate duplicate icreate tx reservation functions Brian Foster
2017-12-03 21:54 ` Dave Chinner
2017-12-07 21:57 ` Darrick J. Wong
2018-01-08 14:08 ` [PATCH v2 0/7] xfs: inode transaction reservation fixups Brian Foster
2018-01-08 18:06 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171203214522.GS5858@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.