From: David Gibson <david@gibson.dropbear.id.au>
To: Benjamin Herrenschmidt <benh@au1.ibm.com>
Cc: "Cédric Le Goater" <clg@kaod.org>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 14/25] spapr: push the XIVE EQ data in OS event queue
Date: Mon, 4 Dec 2017 12:20:29 +1100 [thread overview]
Message-ID: <20171204012029.GI2130@umbus.fritz.box> (raw)
In-Reply-To: <1512225979.2224.70.camel@au1.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]
On Sat, Dec 02, 2017 at 08:46:19AM -0600, Benjamin Herrenschmidt wrote:
> On Sat, 2017-12-02 at 08:45 -0600, Benjamin Herrenschmidt wrote:
> > On Fri, 2017-12-01 at 15:10 +1100, David Gibson wrote:
> > >
> > > Hm, ok. Guest endian (or at least, not definitively host-endian) data
> > > in a plain uint32_t makes me uncomfortable. Could we use char data[4]
> > > instead, to make it clear it's a byte-ordered buffer, rather than a
> > > number as far as the XIVE is concerned.
> > >
> > > Hm.. except that doesn't quite work, because the hardware must define
> > > which end that generation bit ends up in...
> >
> > It also needs to be written atomically. Just say it's big endian.
>
> Also the guest reads it using be32_to_cpup...
Ok. Definitely should be treated as BE and read/written with the be32
DMA helper functions.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-12-04 1:52 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 13:29 [Qemu-devel] [PATCH 00/25] spapr: Guest exploitation of the XIVE interrupt controller (POWER9) Cédric Le Goater
2017-11-23 13:29 ` [Qemu-devel] [PATCH 01/25] ppc/xics: introduce an icp_create() helper Cédric Le Goater
2017-11-24 2:51 ` David Gibson
2017-11-24 7:57 ` Cédric Le Goater
2017-11-24 9:55 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2017-11-27 7:20 ` David Gibson
2017-11-24 9:08 ` Greg Kurz
2017-11-23 13:29 ` [Qemu-devel] [PATCH 02/25] ppc/xics: assign of the CPU 'intc' pointer under the core Cédric Le Goater
2017-11-24 2:57 ` David Gibson
2017-11-24 9:21 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2017-11-23 13:29 ` [Qemu-devel] [PATCH 03/25] spapr: introduce a spapr_icp_create() helper Cédric Le Goater
2017-11-24 10:09 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2017-11-24 12:26 ` Cédric Le Goater
2017-11-28 10:56 ` Greg Kurz
2017-11-23 13:29 ` [Qemu-devel] [PATCH 04/25] spapr: move the IRQ allocation routines under the machine Cédric Le Goater
2017-11-24 3:13 ` David Gibson
2017-11-28 10:57 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2017-11-23 13:29 ` [Qemu-devel] [PATCH 05/25] spapr: introduce a spapr_irq_set() helper Cédric Le Goater
2017-11-24 3:16 ` David Gibson
2017-11-24 8:32 ` Cédric Le Goater
2017-11-23 13:29 ` [Qemu-devel] [PATCH 06/25] spapr: introduce a spapr_irq_get_qirq() helper Cédric Le Goater
2017-11-24 3:18 ` David Gibson
2017-11-24 8:01 ` Cédric Le Goater
2017-11-23 13:29 ` [Qemu-devel] [PATCH 07/25] migration: add VMSTATE_STRUCT_VARRAY_UINT32_ALLOC Cédric Le Goater
2017-11-23 13:29 ` [Qemu-devel] [PATCH 08/25] spapr: introduce a skeleton for the XIVE interrupt controller Cédric Le Goater
2017-11-28 5:40 ` David Gibson
2017-11-28 10:44 ` Cédric Le Goater
2017-11-29 4:47 ` David Gibson
2017-11-29 11:49 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2017-11-29 13:46 ` Cédric Le Goater
2017-11-29 15:51 ` Greg Kurz
2017-11-29 16:41 ` Cédric Le Goater
2017-11-30 4:23 ` David Gibson
2017-11-30 4:22 ` David Gibson
2017-11-23 13:29 ` [Qemu-devel] [PATCH 09/25] spapr: introduce handlers for XIVE interrupt sources Cédric Le Goater
2017-11-28 5:45 ` David Gibson
2017-11-28 18:18 ` Cédric Le Goater
2017-12-02 14:26 ` Benjamin Herrenschmidt
2017-11-23 13:29 ` [Qemu-devel] [PATCH 10/25] spapr: add MMIO handlers for the " Cédric Le Goater
2017-11-28 6:38 ` David Gibson
2017-11-28 18:33 ` Cédric Le Goater
2017-11-29 4:59 ` David Gibson
2017-11-29 13:56 ` Cédric Le Goater
2017-11-29 16:23 ` Cédric Le Goater
2017-11-30 4:28 ` David Gibson
2017-11-30 16:05 ` Cédric Le Goater
2017-12-02 14:33 ` Benjamin Herrenschmidt
2017-12-02 14:28 ` Benjamin Herrenschmidt
2017-12-02 14:47 ` Cédric Le Goater
2017-11-30 4:26 ` David Gibson
2017-11-30 15:40 ` Cédric Le Goater
2017-12-02 14:23 ` Benjamin Herrenschmidt
2017-11-23 13:29 ` [Qemu-devel] [PATCH 11/25] spapr: describe the XIVE interrupt source flags Cédric Le Goater
2017-11-28 6:40 ` David Gibson
2017-11-28 18:23 ` Cédric Le Goater
2017-12-02 14:24 ` Benjamin Herrenschmidt
2017-12-02 14:38 ` Cédric Le Goater
2017-12-02 14:48 ` Benjamin Herrenschmidt
2017-12-02 14:50 ` Cédric Le Goater
2017-11-23 13:29 ` [Qemu-devel] [PATCH 12/25] spapr: introduce a XIVE interrupt presenter model Cédric Le Goater
2017-11-29 5:11 ` David Gibson
2017-11-29 9:55 ` Cédric Le Goater
2017-11-30 4:06 ` David Gibson
2017-11-30 13:44 ` Cédric Le Goater
2017-12-01 4:03 ` David Gibson
2017-12-01 8:02 ` Cédric Le Goater
2017-11-23 13:29 ` [Qemu-devel] [PATCH 13/25] spapr: introduce the XIVE Event Queues Cédric Le Goater
2017-11-23 20:31 ` Benjamin Herrenschmidt
2017-11-24 8:15 ` Cédric Le Goater
2017-11-26 21:52 ` Benjamin Herrenschmidt
2017-11-30 4:38 ` David Gibson
2017-11-30 14:06 ` Cédric Le Goater
2017-11-30 23:35 ` David Gibson
2017-12-01 16:36 ` Cédric Le Goater
2017-12-04 1:09 ` David Gibson
2017-12-04 16:31 ` Cédric Le Goater
2017-12-02 14:39 ` Benjamin Herrenschmidt
2017-12-02 14:41 ` Benjamin Herrenschmidt
2017-11-23 13:29 ` [Qemu-devel] [PATCH 14/25] spapr: push the XIVE EQ data in OS event queue Cédric Le Goater
2017-11-30 4:49 ` David Gibson
2017-11-30 14:16 ` Cédric Le Goater
2017-12-01 4:10 ` David Gibson
2017-12-01 16:43 ` Cédric Le Goater
2017-12-02 14:45 ` Benjamin Herrenschmidt
2017-12-02 14:46 ` Benjamin Herrenschmidt
2017-12-04 1:20 ` David Gibson [this message]
2017-12-05 10:58 ` Cédric Le Goater
2017-11-23 13:29 ` [Qemu-devel] [PATCH 15/25] spapr: notify the CPU when the XIVE interrupt priority is more privileged Cédric Le Goater
2017-11-30 5:00 ` David Gibson
2017-11-30 16:17 ` Cédric Le Goater
2017-12-02 14:40 ` Benjamin Herrenschmidt
2017-12-04 1:17 ` David Gibson
2017-12-04 16:09 ` Benjamin Herrenschmidt
2017-12-07 11:55 ` Cédric Le Goater
2017-11-23 13:29 ` [Qemu-devel] [PATCH 16/25] spapr: add support for the SET_OS_PENDING command (XIVE) Cédric Le Goater
2017-11-23 13:29 ` [Qemu-devel] [PATCH 17/25] spapr: add a sPAPRXive object to the machine Cédric Le Goater
2017-11-30 5:55 ` David Gibson
2017-11-30 15:15 ` Cédric Le Goater
2017-12-01 4:14 ` David Gibson
2017-12-01 8:10 ` Cédric Le Goater
2017-12-04 1:59 ` David Gibson
2017-12-04 8:32 ` Cédric Le Goater
2017-12-04 8:40 ` David Gibson
2017-11-30 15:38 ` Cédric Le Goater
2017-12-01 4:17 ` David Gibson
2017-11-23 13:29 ` [Qemu-devel] [PATCH 18/25] spapr: allocate IRQ numbers for the XIVE interrupt mode Cédric Le Goater
2017-11-23 13:29 ` [Qemu-devel] [PATCH 19/25] spapr: add hcalls support " Cédric Le Goater
2017-12-01 4:01 ` David Gibson
2017-12-01 17:46 ` Cédric Le Goater
2017-12-05 7:00 ` David Gibson
2017-12-05 14:50 ` Benjamin Herrenschmidt
2017-12-06 9:20 ` David Gibson
2017-12-06 19:41 ` Benjamin Herrenschmidt
2017-12-05 16:12 ` Cédric Le Goater
2017-11-23 13:29 ` [Qemu-devel] [PATCH 20/25] spapr: add device tree " Cédric Le Goater
2017-12-04 7:49 ` David Gibson
2017-12-04 16:19 ` Cédric Le Goater
2017-12-05 3:38 ` David Gibson
2017-11-23 13:29 ` [Qemu-devel] [PATCH 21/25] spapr: introduce a helper to map the XIVE memory regions Cédric Le Goater
2017-12-04 7:52 ` David Gibson
2017-12-04 15:30 ` Cédric Le Goater
2017-12-05 2:24 ` David Gibson
2017-11-23 13:29 ` [Qemu-devel] [PATCH 22/25] spapr: add XIVE support to spapr_irq_get_qirq() Cédric Le Goater
2017-12-04 7:52 ` David Gibson
2017-11-23 13:29 ` [Qemu-devel] [PATCH 23/25] spapr: toggle the ICP depending on the selected interrupt mode Cédric Le Goater
2017-12-04 7:56 ` David Gibson
2017-11-23 13:29 ` [Qemu-devel] [PATCH 24/25] spapr: add support to dump XIVE information Cédric Le Goater
2017-11-23 13:29 ` [Qemu-devel] [PATCH 25/25] spapr: advertise XIVE exploitation mode in CAS Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204012029.GI2130@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=benh@au1.ibm.com \
--cc=clg@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.