From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Jeremy Cline <jeremy@jcline.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Hans de Goede <hdegoede@redhat.com>,
Lars Kellogg-Stedman <lars@oddbit.com>,
Steven Presser <steve@pressers.name>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH 2/2] iio: accel: bmc150: Check for a second ACPI device for BOSC0200
Date: Mon, 4 Dec 2017 11:58:19 +0200 [thread overview]
Message-ID: <20171204095819.GY22431@lahna.fi.intel.com> (raw)
In-Reply-To: <20171202121927.3b7aa028@archlinux>
On Sat, Dec 02, 2017 at 12:19:27PM +0000, Jonathan Cameron wrote:
> On Wed, 29 Nov 2017 22:31:12 +0000
> Jeremy Cline <jeremy@jcline.org> wrote:
>
> > Some BOSC0200 acpi_device-s describe two accelerometers in a single ACPI
> > device. Check for a companion device and handle a second i2c_client
> > if it is present.
>
> + Mika and Wolfram - please cc them on anything odd and i2c / ACPI related.
> (I like to share the pain)
>
> My usual question, just out of curiosity as we have to cope with this
> fun anyway. Are you actually allowed to do this under the ACPI spec
> or not? I would assume an acpi device is supposed to be just that A
> device... I fall asleep every time I try to read that spec ;)
Yes, it is allowed. Typically you have an ACPI device and it can have
multiple I2cSerialBus() connections.
Linux ACPI/I2C core then picks the first one and creates i2c_client from
that but the additional connections need to be created by the driver in
question.
BTW, there is a function i2c_new_secondary_device() that is supposed to
be used for this but it does not have ACPI support yet (maybe it is good
time to add it now, with this patch series?)
next prev parent reply other threads:[~2017-12-04 9:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171129223016.17848-1-jeremy@jcline.org>
2017-11-29 22:31 ` [PATCH 1/2] iio: accel: bmc150: Move struct definitions into the header Jeremy Cline
2017-11-29 22:31 ` [PATCH 2/2] iio: accel: bmc150: Check for a second ACPI device for BOSC0200 Jeremy Cline
2017-12-02 12:19 ` Jonathan Cameron
2017-12-04 9:58 ` Mika Westerberg [this message]
2017-12-04 10:29 ` Hans de Goede
2017-12-04 10:41 ` Mika Westerberg
2017-12-05 11:27 ` Jonathan Cameron
2017-12-05 11:38 ` Mika Westerberg
2017-12-05 11:54 ` Jonathan Cameron
2017-12-04 18:58 ` Jeremy Cline
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204095819.GY22431@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=jeremy@jcline.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lars@oddbit.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=steve@pressers.name \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.