From: jesse.brandeburg@intel.com (Jesse Brandeburg)
To: cocci@systeme.lip6.fr
Subject: [Cocci] BUG: possible parsing issue
Date: Mon, 4 Dec 2017 10:05:46 -0800 [thread overview]
Message-ID: <20171204100546.000045ab@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1712020913040.2168@hadrien>
On Sat, 2 Dec 2017 09:14:23 +0100
Julia Lawall <julia.lawall@lip6.fr> wrote:
> > - LIST_FOR_EACH_ENTRY(c,f,g,member) S
> > + hlist_for_each_entry(c,f,member) S
>
> Actually, the problem is that you have removed S and dded it back.
> Then you are relying on Coccinelle to do the pretty printing, and all
> comments will be dropped. Just rewrite your rule as follows, and
> everything will be fine:
>
> - LIST_FOR_EACH_ENTRY(c,f,g,member)
> + hlist_for_each_entry(c,f,member)
> S
Wow, thanks for that, it now works. The discussion following this post
was also very educational. Thanks!
prev parent reply other threads:[~2017-12-04 18:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 8:03 [Cocci] BUG: possible parsing issue Brandeburg, Jesse
2017-12-02 8:12 ` Julia Lawall
2017-12-02 8:14 ` Julia Lawall
2017-12-02 9:20 ` [Cocci] Transformation challenges with SmPL around “LIST_FOR_EACH_ENTRY” SF Markus Elfring
2017-12-02 9:47 ` Julia Lawall
2017-12-02 10:03 ` SF Markus Elfring
2017-12-02 10:06 ` Julia Lawall
2017-12-04 18:05 ` Jesse Brandeburg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204100546.000045ab@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.