From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
Florian Westphal <fw@strlen.de>,
linux-kernel@vger.kernel.org, coreteam@netfilter.org,
netfilter-devel@vger.kernel.org,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH net-next] bridge: ebtables: Avoid resetting limit rule state
Date: Mon, 4 Dec 2017 11:13:40 +0100 [thread overview]
Message-ID: <20171204101340.GA7871@salvia> (raw)
In-Reply-To: <20171204052006.GF3307@otheros>
On Mon, Dec 04, 2017 at 06:20:06AM +0100, Linus Lüssing wrote:
> On Mon, Dec 04, 2017 at 05:53:35AM +0100, Linus Lüssing wrote:
> > And so, no I do not have this patch. I looked at it now, but it
> > does not seem to have any relation with .matchinfo, does it?
>
> Relation between .usersize and .checkentry I ment, not
> .usersize and .matchinfo.
In your patch, info->prev comes set to a value from userspace, right?
commit 324318f0248c31be8a08984146e7e4dd7cdd091d
Author: Willem de Bruijn <willemb@google.com>
Date: Tue May 9 16:17:37 2017 -0400
netfilter: xtables: zero padding in data_to_user
Since that patch above, the data area is zero'ed before dumped to
userspace, so we would get a null info->prev, hence defeating the
trick your patch relies on.
Am I missing anything?
next prev parent reply other threads:[~2017-12-04 10:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-25 7:44 [Bridge] [PATCH net-next] bridge: ebtables: Avoid resetting limit rule state Linus Lüssing
2017-11-25 7:44 ` Linus Lüssing
2017-11-27 23:30 ` [Bridge] " Pablo Neira Ayuso
2017-11-27 23:30 ` Pablo Neira Ayuso
2017-12-04 4:53 ` [Bridge] " Linus Lüssing
2017-12-04 4:53 ` Linus Lüssing
2017-12-04 4:53 ` Linus Lüssing
2017-12-04 5:20 ` [Bridge] " Linus Lüssing
2017-12-04 10:13 ` Pablo Neira Ayuso [this message]
2017-12-07 0:26 ` Pablo Neira Ayuso
2017-12-07 0:26 ` Pablo Neira Ayuso
2017-12-07 0:26 ` Pablo Neira Ayuso
2017-12-08 5:46 ` [Bridge] " Linus Lüssing
2017-12-08 5:46 ` Linus Lüssing
2017-12-08 5:49 ` [Bridge] " Linus Lüssing
2017-12-08 5:49 ` Linus Lüssing
2017-12-08 5:49 ` Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204101340.GA7871@salvia \
--to=pablo@netfilter.org \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=linus.luessing@c0d3.blue \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.