Re: [PATCH/RFC] DT: leds: Fix 'label' property description and add 'colour' property

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 2204 bytes --]

Hi!

> Label property was imposed a uniqueness requirement, which was erroneous,
> since ePAPR defines it to "a human readable string describing a device".
> 
> Also the binding description misleadingly suggested direct usage of label
> for LED class device name, whereas it should only define a LED function.
> 
> Therefore an additional 'colour' property is being introduced, which together
> with the parent DT node name used for devicename shall be used for naming LED
> class device according to the patterh
> <devicename>:<colour>:<function>.


> -- label : The label for this LED. If omitted, the label is taken from the node
> -	  name (excluding the unit address). It has to uniquely identify
> -	  a device, i.e. no other LED class device can be assigned the same
> -	  label.
> +- label : The label for this LED. It should describe its function. If omitted,
> +          the label is taken from the node name (excluding the unit address).

So the label contains "as1235:green:capslock"? I guess it might be
nice to mention that. Or just the "capslock" part?

Also.. it would be good to start pushing for more consistency in the
labels: I have these on the thinkpad:

input5::scrolllock/   tpacpi::dock_status2/ tpacpi::unknown_led/
mmc0::/               tpacpi:green:batt/    tpacpi::unknown_led2/
phy0-led/             tpacpi:orange:batt/   tpacpi::unknown_led3/
tpacpi::bay_active/   tpacpi::power/

On embedded system, I'd like to see <devicename> to corespond
to.. device the led belongs to, as opposed to name of the chip that
drives the led. Maybe we should do 'main_camera:white:flash' instead of
'as4132:white:flash' because userspace already has information on what
chip it is (sysfs paths), but can not easily figure out to which
device the flash belongs.

> +- colour : Colour of the LED.
>  
>  - default-state : The initial state of the LED. Valid values are "on", "off",
>    and "keep". If the LED is already on or off and the default-state
> -	  property is

Best regards,
								Pavel


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]