From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.linuxfoundation.org ([140.211.169.12]:57960 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752758AbdLDMCJ (ORCPT
        <rfc822;stable@vger.kernel.org>); Mon, 4 Dec 2017 07:02:09 -0500
Date: Mon, 4 Dec 2017 13:02:15 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bpetkov@suse.de>, Brian Gerst <brgerst@gmail.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        stable <stable@vger.kernel.org>, stable-commits@vger.kernel.org
Subject: Re: Patch "x86/entry/64: Add missing irqflags tracing to
 native_load_gs_index()" has been added to the 4.9-stable tree
Message-ID: <20171204120215.GA12773@kroah.com>
References: <1511786461176251@kroah.com>
 <CALCETrU72v5_9q0DEpPWHvTSUf+rEaZSe7CuQqzOq_o-CC=OVA@mail.gmail.com>
 <20171130084456.GA31634@kroah.com>
 <4758E7DE-0249-482B-9EDC-0B33EF864805@amacapital.net>
 <CALCETrUjaqHfp7Av-wjMywYAsM5t9tHQJ6VhyZtkiSmaU=BzOw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCETrUjaqHfp7Av-wjMywYAsM5t9tHQJ6VhyZtkiSmaU=BzOw@mail.gmail.com>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Thu, Nov 30, 2017 at 10:50:22AM -0800, Andy Lutomirski wrote:
> On Thu, Nov 30, 2017 at 6:29 AM, Andy Lutomirski <luto@amacapital.net> wrote:
> >
> >
> >> On Nov 30, 2017, at 12:44 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >>
> >>> On Wed, Nov 29, 2017 at 08:23:10AM -0800, Andy Lutomirski wrote:
> >>> If this hasn't been released yet, please hold off.  It's buggy.
> >>
> >> Ah crap, I missed this and just released it.  Is there a fix for this in
> >> Linus's tree?  How "buggy" is it?
> >
> > It breaks suspend/resume on some configuration that I haven't quite figured out.  I think it only happens if (lockdep is on and some other unknown condition occurs) or (ftrace is actively tracing irq flags).  I have a fix, but I was waiting to for the OP to test it.
> >
> > I'll send the fix Linusward later today without the Tested-by if I don't hear anything.
> 
> I think the thing to do is to revert the patch from -stable.  The bug
> it fixes is very minor, and the regression is that it made a
> pre-existing bug in some nearly-undebuggable core resume code much
> easier to hit.  I don't feel comfortable with a backport of the latter
> fix until it has a good long soak in Linus' tree.

Ok, now reverted.  Should I do the same thing for the patch in
4.14-stable as well?

thanks,

greg k-h