From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:59148 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752231AbdLDMQd (ORCPT ); Mon, 4 Dec 2017 07:16:33 -0500 Date: Mon, 4 Dec 2017 13:16:39 +0100 From: Greg KH To: NeilBrown Cc: kumba@gentoo.org, shli@fb.com, stable@vger.kernel.org Subject: Re: FAILED: patch "[PATCH] md: forbid a RAID5 from having both a bitmap and a journal." failed to apply to 4.14-stable tree Message-ID: <20171204121639.GF18589@kroah.com> References: <1511796203245200@kroah.com> <877eu9yhc6.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877eu9yhc6.fsf@notabene.neil.brown.name> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Nov 29, 2017 at 01:00:25PM +1100, NeilBrown wrote: > > Subject: [PATCH] md: forbid a RAID5 from having both a bitmap and a journal. > > commit 230b55fa8d64007339319539f8f8e68114d08529 upstream. > > Having both a bitmap and a journal is pointless. > Attempting to do so can corrupt the bitmap if the journal > replay happens before the bitmap is initialized. > Rather than try to avoid this corruption, simply > refuse to allow arrays with both a bitmap and a journal. > So: > - if raid5_run sees both are present, fail. > - if adding a bitmap finds a journal is present, fail > - if adding a journal finds a bitmap is present, fail. > > Cc: stable@vger.kernel.org (4.10+) > Signed-off-by: NeilBrown > Tested-by: Joshua Kinard > Acked-by: Joshua Kinard > Signed-off-by: Shaohua Li > --- > drivers/md/bitmap.c | 6 ++++++ > drivers/md/md.c | 2 +- > drivers/md/raid5.c | 7 +++++++ > 3 files changed, 14 insertions(+), 1 deletion(-) > > This commit only had problems due to a filename change. Oops, I should have caught that one, sorry about that. Thanks for the patch. greg k-h