From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v2 1/2] ethdev: add GENEVE flow pattern item
Date: Mon, 4 Dec 2017 15:03:21 +0100
Message-ID: <20171204140320.GE4062@6wind.com>
References: <1511166121-743-1-git-send-email-arybchenko@solarflare.com>
 <1512124996-13388-1-git-send-email-arybchenko@solarflare.com>
 <1512124996-13388-2-git-send-email-arybchenko@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Jingjing Wu <jingjing.wu@intel.com>,
 Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com
 [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 74BDC239
 for <dev@dpdk.org>; Mon,  4 Dec 2017 15:03:33 +0100 (CET)
Received: by mail-wr0-f194.google.com with SMTP id z34so17413123wrz.10
 for <dev@dpdk.org>; Mon, 04 Dec 2017 06:03:33 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1512124996-13388-2-git-send-email-arybchenko@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Dec 01, 2017 at 10:43:15AM +0000, Andrew Rybchenko wrote:
> From: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
> 
> Add new pattern item RTE_FLOW_ITEM_TYPE_GENEVE in flow API.
> Add default mask for the item.
> 
> Signed-off-by: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Just one remaining nit, please see below. While you could address it through
a subsequent patch, you might as well send v3 directly to make things easier
for Ferruh.

Otherwise it's all good, thanks.

> ---
>  doc/guides/prog_guide/rte_flow.rst | 12 ++++++++++++
>  lib/librte_ether/rte_flow.c        |  1 +
>  lib/librte_ether/rte_flow.h        | 30 ++++++++++++++++++++++++++++++
>  3 files changed, 43 insertions(+)
> 
> diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst
> index d158be5..5b8f9c5 100644
> --- a/doc/guides/prog_guide/rte_flow.rst
> +++ b/doc/guides/prog_guide/rte_flow.rst
> @@ -980,6 +980,18 @@ Matches an ESP header.
>  - ``hdr``: ESP header definition (``rte_esp.h``).
>  - Default ``mask`` matches SPI only.
>  
> +Item: ``GENEVE``
> +^^^^^^^^^^^^^^^

Missing "^" under title, this may trigger a warning during documentation
generation.

-- 
Adrien Mazarguil
6WIND