From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH] ethdev: increase flow type limit from 32 to 64 Date: Mon, 4 Dec 2017 18:43:04 +0100 Message-ID: <20171204174304.GK4062@6wind.com> References: <1511785787-127452-1-git-send-email-kirill.rybalchenko@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, jingjing.wu@intel.com, beilei.xing@intel.com, johndale@cisco.com, neescoba@cisco.com, nelio.laranjeiro@6wind.com, yskoh@mellanox.com, wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, andrey.chilikin@intel.com To: Kirill Rybalchenko Return-path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 4032D14E8 for ; Mon, 4 Dec 2017 18:43:17 +0100 (CET) Received: by mail-wr0-f196.google.com with SMTP id v22so18235034wrb.0 for ; Mon, 04 Dec 2017 09:43:17 -0800 (PST) Content-Disposition: inline In-Reply-To: <1511785787-127452-1-git-send-email-kirill.rybalchenko@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Kirill, On Mon, Nov 27, 2017 at 12:29:47PM +0000, Kirill Rybalchenko wrote: > Increase the internal limit for flow types from 32 to 64 > to support future flow type extensions. > Change type of variables from uint32_t[] to uint64_t[]: > rte_eth_fdir_info.flow_types_mask > rte_eth_hash_global_conf.sym_hash_enable_mask > rte_eth_hash_global_conf.valid_bit_mask > > This modification affects the following components: > net/i40e > net/enic > net/mlx5 > net/ixgbe > app/testpmd > > Signed-off-by: Kirill Rybalchenko Can you elaborate a bit on the need for these changes? Have you considered implementing those future extensions through rte_flow instead? -- Adrien Mazarguil 6WIND